Re: ErrorReportValve styling (CSS) not included when both showReport and showServerInfo set to false

2018-05-10 Thread Mark Thomas
On 10/05/18 17:10, Violeta Georgieva wrote: > 2018-05-10 19:04 GMT+03:00 Violeta Georgieva : >> >> Hi, >> >> 2018-05-10 19:00 GMT+03:00 Mark Thomas : >>> >>> On 10/05/18 16:27, John Palmer wrote: >>> >>> >>> or am I missing (or just ignorant of )

Re: ErrorReportValve styling (CSS) not included when both showReport and showServerInfo set to false

2018-05-10 Thread Violeta Georgieva
2018-05-10 19:04 GMT+03:00 Violeta Georgieva : > > Hi, > > 2018-05-10 19:00 GMT+03:00 Mark Thomas : > > > > On 10/05/18 16:27, John Palmer wrote: > > > > > > > > > or am I missing (or just ignorant of ) something? > > > > Seems reasonable to me looking at

Re: ErrorReportValve styling (CSS) not included when both showReport and showServerInfo set to false

2018-05-10 Thread Violeta Georgieva
Hi, 2018-05-10 19:00 GMT+03:00 Mark Thomas : > > On 10/05/18 16:27, John Palmer wrote: > > > > > or am I missing (or just ignorant of ) something? > > Seems reasonable to me looking at the code. Give me a few minutes to > test it and - assuming all is well - I'll make the

Re: ErrorReportValve styling (CSS) not included when both showReport and showServerInfo set to false

2018-05-10 Thread Mark Thomas
On 10/05/18 16:27, John Palmer wrote: > or am I missing (or just ignorant of ) something? Seems reasonable to me looking at the code. Give me a few minutes to test it and - assuming all is well - I'll make the change. Mark -

ErrorReportValve styling (CSS) not included when both showReport and showServerInfo set to false

2018-05-10 Thread John Palmer
while it's documented that the styling will be lost when both settings for ServerReport/ServerInfo are set to false... eg by adding this to server.xml: (and I confirmed this recently) from looking at the source for ErrorReportValve for tomcat 7.0.78 it LOOKS like this would be easy to fix: