Re: Does maxPostSize has an effect on file upload?

2012-12-18 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17/12/2012 19:11, Christopher Schultz wrote: Nick, On 12/14/12 4:28 PM, Williams, Nick wrote: If it was using the global Content-length header, it would count not only the encoded data bytes, but also the parts separators, headers etc..

Re: Does maxPostSize has an effect on file upload?

2012-12-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Nick, On 12/14/12 4:28 PM, Williams, Nick wrote: If it was using the global Content-length header, it would count not only the encoded data bytes, but also the parts separators, headers etc.. So that's nice. It counts only the net data

Re: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Kai Weber
* Mark Thomas ma...@apache.org: Does a file upload as multipart/form-data not count to the size of the POST? No, as the doc make clear. I asked because I could not find a hint in the docs or the INTERNET. What doc do you mean? I looked into

Re: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/13/12 10:27 AM, Mark Thomas wrote: Kai Weber kai.we...@glorybox.de wrote: I see the following behaviour on Tomcat 6.0.24: The maxPostSize is not set, so uses the default of 2MB. I can upload files bigger than 2MB (5MB for

RE: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Caldarale, Charles R
From: Christopher Schultz [mailto:ch...@christopherschultz.net] Subject: Re: Does maxPostSize has an effect on file upload? Does a file upload as multipart/form-data not count to the size of the POST? No, as the doc make clear. I'm not so sure the docs make it clear. I think you

Re: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chuck, On 12/14/12 12:38 PM, Caldarale, Charles R wrote: From: Christopher Schultz [mailto:ch...@christopherschultz.net] Subject: Re: Does maxPostSize has an effect on file upload? Does a file upload as multipart/form-data not count

Re: Does maxPostSize has an effect on file upload?

2012-12-14 Thread André Warnier
Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chuck, On 12/14/12 12:38 PM, Caldarale, Charles R wrote: From: Christopher Schultz [mailto:ch...@christopherschultz.net] Subject: Re: Does maxPostSize has an effect on file upload? Does a file upload as multipart/form

RE: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Williams, Nick
: Friday, December 14, 2012 1:15 PM To: Tomcat Users List Subject: Re: Does maxPostSize has an effect on file upload? Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chuck, On 12/14/12 12:38 PM, Caldarale, Charles R wrote: From: Christopher Schultz [mailto:ch

Re: Does maxPostSize has an effect on file upload?

2012-12-14 Thread André Warnier
Message- From: André Warnier [mailto:a...@ice-sa.com] Sent: Friday, December 14, 2012 1:15 PM To: Tomcat Users List Subject: Re: Does maxPostSize has an effect on file upload? Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chuck, On 12/14/12 12:38 PM, Caldarale

Re: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Mark Thomas
On 14/12/2012 19:58, Williams, Nick wrote: (Note: It's entirely possible that I'm reading the code wrong. Yes you are. Not completely wrongly but there are errors. The short version is as follows: If Tomcat is responsible for reading the request body such as via a call to a method like

RE: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Williams, Nick
, Mark. Nick -Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Friday, December 14, 2012 3:17 PM To: Tomcat Users List Subject: Re: Does maxPostSize has an effect on file upload? On 14/12/2012 19:58, Williams, Nick wrote: (Note: It's entirely possible that I'm reading

RE: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Williams, Nick
If it was using the global Content-length header, it would count not only the encoded data bytes, but also the parts separators, headers etc.. So that's nice. It counts only the net data bytes, which is easier to compare to the size on disk of a file that you would upload. Indeed. A great

Re: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Mark Thomas
On 14/12/2012 21:13, André Warnier wrote: snip/ If it's multipart/form-data, it delegates to another method, parseParts(). snip/ Why the Content-Length is not checked, I am unsure. It seems it would be less expensive to throw the exception before ever trying to parse the parts. However,

Re: Does maxPostSize has an effect on file upload?

2012-12-14 Thread André Warnier
Mark Thomas wrote: On 14/12/2012 21:13, André Warnier wrote: snip/ If it's multipart/form-data, it delegates to another method, parseParts(). snip/ Why the Content-Length is not checked, I am unsure. It seems it would be less expensive to throw the exception before ever trying to parse

RE: Does maxPostSize has an effect on file upload?

2012-12-14 Thread Williams, Nick
The way Tomcat is apparently doing it now is much more sensible, in my humble opinion, because it does allow a direct and easy comparison with the files being uploaded. And since as per above it needs to be kept in some cases anyway, my vote - if I had one - would be to not change it. I

Re: Does maxPostSize has an effect on file upload?

2012-12-13 Thread Mark Thomas
Kai Weber kai.we...@glorybox.de wrote: I see the following behaviour on Tomcat 6.0.24: The maxPostSize is not set, so uses the default of 2MB. I can upload files bigger than 2MB (5MB for example). I use commons-fileupload to read the file. As expected. Does a file upload as