Re: getAttribute(null)?

2008-06-17 Thread Mark Thomas
Leon Rosenberg wrote: may I suggest that you add the same check also to that method : protected void removeAttributeInternal(String name, boolean notify) { That would help wouldn't it ;). Done. Thanks for catching that. Mark

Re: getAttribute(null)?

2008-06-16 Thread Leon Rosenberg
may I suggest that you add the same check also to that method : protected void removeAttributeInternal(String name, boolean notify) { // Remove this attribute from our collection Object value = attributes.remove(name); ? Thanx Leon. On Mon, Jun 16, 2008 at 9:25 AM, Mark Thomas

Re: getAttribute(null)?

2008-06-16 Thread Mark Thomas
Leon Rosenberg wrote: P.S. probably it would be good if StandartSession would check for it return name==null ? null : (attributes.get(name)); instead of return (attributes.get(name)); but they probably won't do it anyway:-) Oh yea of little faith. http://svn.apache.org/viewvc?re

Re: getAttribute(null)?

2008-06-16 Thread Leon Rosenberg
On Thu, Jun 12, 2008 at 5:36 PM, Leffingwell, Jonathan R CTR FRCSE, JAX 7.2.2 <[EMAIL PROTECTED]> wrote: > It's not the "why is formName null?" that I'm worried about. In this > case, it's supposed to be null. > > What I want to know is this: Is a NullPointerException supposed to be > thrown if th

Re: getAttribute(null)?

2008-06-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jonathan, Leffingwell, Jonathan R CTR FRCSE, JAX 7.2.2 wrote: | I have the following code that worked in Tomcat 5.0, but doesn't work in | Tomcat 5.5.26: | | String formName = mapping.getAttribute(); // mapping is a variable of | type ActionMapping

Re: getAttribute(null)?

2008-06-12 Thread Johnny Kewl
- Original Message - From: "Leffingwell, Jonathan R CTR FRCSE, JAX 7.2.2" <[EMAIL PROTECTED]> To: Sent: Thursday, June 12, 2008 4:44 PM Subject: getAttribute(null)? I have the following code that worked in Tomcat 5.0, but doesn't work in Tomcat 5.5

RE: getAttribute(null)?

2008-06-12 Thread Leffingwell, Jonathan R CTR FRCSE, JAX 7.2.2
IS supposed to be thrown, was this a change put into Tomcat 5.5.x that wasn't in 5.0.x? -Original Message- From: Martin Gainty [mailto:[EMAIL PROTECTED] Sent: Thursday, June 12, 2008 11:24 AM To: Leffingwell, Jonathan R CTR FRCSE, JAX 7.2.2 Subject: RE: getAttribute(null)? At tha

getAttribute(null)?

2008-06-12 Thread Leffingwell, Jonathan R CTR FRCSE, JAX 7.2.2
I have the following code that worked in Tomcat 5.0, but doesn't work in Tomcat 5.5.26: String formName = mapping.getAttribute(); // mapping is a variable of type ActionMapping. In this scenario, formName is null. if (null != session.getAttribute(formName)) { session.removeAttribute(for