Re: File leak in 7.0.23?

2012-01-02 Thread Mike Wertheim
If a simple test case isn't discovered, I'm happy to test out potential fixes (by deploying the fixes to one of my production servers and seeing whether or not the server dies after running for a day). On Sun, Jan 1, 2012 at 7:17 AM, ma...@apache.org wrote: Janne Jalkanen

Re: File leak in 7.0.23?

2012-01-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Janne, On 1/1/12 12:23 PM, Janne Jalkanen wrote: OK. Sounds like APR/native has an issue. There was a fair bit of refactoring in 7.0.22. I'll see if I can reproduce it. A simple test case may help. Should I open a bug now on the issue

Re: File leak in 7.0.23?

2012-01-02 Thread Konstantin Kolinko
2011/12/31 Janne Jalkanen janne.jalka...@ecyrd.com: Hi all! I am seeing odd behaviour with 7.0.23, with the tomcat user's open file count increasing slowly, but consistently. Two other instances running the exact same codebase on identical hardware, BUT with Tomcat 7.0.20, are not

Re: File leak in 7.0.23?

2012-01-02 Thread Mike Wertheim
On Mon, Jan 2, 2012 at 4:31 PM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2011/12/31 Janne Jalkanen janne.jalka...@ecyrd.com: Hi all! I am seeing odd behaviour with 7.0.23, with the tomcat user's open file count increasing slowly, but consistently. Two other instances running the

Re: File leak in 7.0.23?

2012-01-01 Thread Janne Jalkanen
APR + native. Good catch there, I took apr out and I am no longer seeing the FD leak. I was running APR 1.3.8 with TC-native 1.1.19, so I thought that maybe these old versions were the problem. But I upgraded to APR 1.4.5 and tc-native 1.1.22 (the latest stables from both) and am still

Re: File leak in 7.0.23?

2012-01-01 Thread markt
Janne Jalkanen janne.jalka...@ecyrd.com wrote: APR + native. Good catch there, I took apr out and I am no longer seeing the FD leak. OK. Sounds like APR/native has an issue. There was a fair bit of refactoring in 7.0.22. I'll see if I can reproduce it. A simple test case may help. Mark

Re: File leak in 7.0.23?

2012-01-01 Thread Janne Jalkanen
If you take heap dumps can you see an Increase in the number of sockets? What should I be looking for, assuming that the problem is with APR connection? Any particular class? /Janne - To unsubscribe, e-mail:

Re: File leak in 7.0.23?

2012-01-01 Thread Janne Jalkanen
OK. Sounds like APR/native has an issue. There was a fair bit of refactoring in 7.0.22. I'll see if I can reproduce it. A simple test case may help. Should I open a bug now on the issue tracker? /Janne - To unsubscribe,

File leak in 7.0.23?

2011-12-31 Thread Janne Jalkanen
Hi all! I am seeing odd behaviour with 7.0.23, with the tomcat user's open file count increasing slowly, but consistently. Two other instances running the exact same codebase on identical hardware, BUT with Tomcat 7.0.20, are not exhibiting the same behaviour. 7.0.20 is rock solid, 7.0.23 dies

Re: File leak in 7.0.23?

2011-12-31 Thread Pid
On 31/12/2011 13:06, Janne Jalkanen wrote: Hi all! I am seeing odd behaviour with 7.0.23, with the tomcat user's open file count increasing slowly, but consistently. Two other instances running the exact same codebase on identical hardware, BUT with Tomcat 7.0.20, are not exhibiting the

Re: File leak in 7.0.23?

2011-12-31 Thread Janne Jalkanen
Which Connector are you using? Connector port=8080 protocol=HTTP/1.1 connectionTimeout=2 redirectPort=8443 URIEncoding=UTF-8 compression=on

Re: File leak in 7.0.23?

2011-12-31 Thread Pid
On 31/12/2011 13:38, Janne Jalkanen wrote: Which Connector are you using? Connector port=8080 protocol=HTTP/1.1 connectionTimeout=2 redirectPort=8443 URIEncoding=UTF-8 compression=on

Re: File leak in 7.0.23?

2011-12-31 Thread Janne Jalkanen
When did the problem start occurring and what else has changed? Exactly at the time when I upgraded to 7.0.23. I don't recall making any other modifications (I would've suspected them first ;-) I will try to downgrade to 7.0.22 and lower to try and see if there's a difference between Tomcat

Re: File leak in 7.0.23?

2011-12-31 Thread André Warnier
Janne Jalkanen wrote: When did the problem start occurring and what else has changed? Exactly at the time when I upgraded to 7.0.23. I don't recall making any other modifications (I would've suspected them first ;-) I will try to downgrade to 7.0.22 and lower to try and see if there's a

Re: File leak in 7.0.23?

2011-12-31 Thread Mike Wertheim
I'm not sure how useful this comment is, but... I also recently posted about an app that runs fine on Tomcat 7.0.21 and dies a slow horrible death on Tomcat 7.0.23. It would seem that a bug was introduced in either 7.0.22 or 7.0.23. On Sat, Dec 31, 2011 at 6:48 AM, André Warnier

Re: File leak in 7.0.23?

2011-12-31 Thread Janne Jalkanen
ATM my testing looks like 7.0.21 works, whereas 7.0.22 is leaky. Will continue to investigate. /Janne On Dec 31, 2011, at 20:18 , Mike Wertheim wrote: I'm not sure how useful this comment is, but... I also recently posted about an app that runs fine on Tomcat 7.0.21 and dies a slow

Re: File leak in 7.0.23?

2011-12-31 Thread Pid *
On 31 Dec 2011, at 18:19, Mike Wertheim m...@hyperreal.org wrote: I'm not sure how useful this comment is, but... I also recently posted about an app that runs fine on Tomcat 7.0.21 and dies a slow horrible death on Tomcat 7.0.23. It would seem that a bug was introduced in either 7.0.22 or

Re: File leak in 7.0.23?

2011-12-31 Thread Mike Wertheim
Janne's latest email says that 7.0.22 is leaky as well. So the regression most likely happened between 7.0.21 and 7.0.22. I'm not familiar with the Tomcat code base. But I wonder how difficult it would be for someone to review all of the code changes that were checked in between 7.0.21 and

Re: File leak in 7.0.23?

2011-12-31 Thread Janne Jalkanen
What if you remove the command-line switch -Dcom.sun.management.jmxremote.port=redacted ? No effect. Also, what does netstat -pan | grep tomcat pid have to say ? Nothing unusual (i.e. stuff I wouldn't expect) or different from the other instances: Database connections, listening on 8080,

Re: File leak in 7.0.23?

2011-12-31 Thread Pid *
On 31 Dec 2011, at 20:03, Mike Wertheim m...@hyperreal.org wrote: Janne's latest email says that 7.0.22 is leaky as well. So the regression most likely happened between 7.0.21 and 7.0.22. I'm not familiar with the Tomcat code base. But I wonder how difficult it would be for someone to

Re: File leak in 7.0.23?

2011-12-31 Thread Pid *
On 31 Dec 2011, at 20:05, Janne Jalkanen janne.jalka...@ecyrd.com wrote: What if you remove the command-line switch -Dcom.sun.management.jmxremote.port=redacted ? No effect. Also, what does netstat -pan | grep tomcat pid have to say ? Nothing unusual (i.e. stuff I wouldn't expect) or

Re: File leak in 7.0.23?

2011-12-31 Thread Mark Thomas
On 31/12/2011 13:38, Janne Jalkanen wrote: Which Connector are you using? Connector port=8080 protocol=HTTP/1.1 connectionTimeout=2 redirectPort=8443 URIEncoding=UTF-8 compression=on