Re: Proposal : port mod_expires in java as ExpiresFilter Servlet Filter

2010-04-16 Thread Cyrille Le Clerc
Hello Christopher, I imagine the project crew has been very busy these days. Do you have feedbacks on the adaptations and explanations I did ? Is there anything I could iterate on ? To rephrase my previous email : * I reduced the number of comparison against 'nulls' as you suggested. I

Re: Proposal : port mod_expires in java as ExpiresFilter Servlet Filter

2010-03-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Cyrille, On 3/26/2010 12:43 PM, Cyrille Le Clerc wrote: I have proposed with bugzilla 48998 a port of Apache mod_expires in Java as ExpiresFilter Servlet Filter. Cool. I detailed a standalone version of this filter on

Re: Proposal : port mod_expires in java as ExpiresFilter Servlet Filter

2010-03-29 Thread Cyrille Le Clerc
Thanks for your fast feedbacks Christopher, I updated the patch proposed on Bugzilla 48998 to include your advice to limit the number of null checks. The implementation I found is slightly different than your proposal but the idea remain the same. Please note that I only modified the patch and