RE: Skip resource path in TLD scanner?

2017-11-20 Thread Matt Cosentino
Thanks, but I'm talking about resource paths and not jar files.

- Matt

From: Ray Holme [mailto:rayho...@yahoo.com.INVALID]
Sent: Friday, November 17, 2017 1:39 PM
To: Tomcat Users List <users@tomcat.apache.org>
Subject: Re: Skip resource path in TLD scanner?

I use JSP and there are taglibs used.
But you can cut the scan time way down by not scanning any libraries that don't 
have TLDs
 (nested files with name => .tld)
You can find this by using "jar t" or "unzip -l" on each library (thanks Chris).

If you are a Unix (Linux or MAC) user you may cheat a little by using the 
script attached.
You may put any all .jar files in .../apache/lib or 
.../apache/webapps/*/WEB-INF/lib into the
  .../apache/conf/catalina.properties file if they do not have taglibs.
So 90% of what I need does not have taglibs (just jstl-impl-...jar DOES and 
must be left out of the DO NO SCAN line.
This took my startup time from a couple minutes to under a second.

Best of luck.

On Friday, November 17, 2017 1:26 PM, Christopher Schultz 
<ch...@christopherschultz.net<mailto:ch...@christopherschultz.net>> wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Matt,

On 11/16/17 12:11 PM, Matt Cosentino wrote:
> This keeps getting worse, my site was down for over a minute while
> the TLD scanner ran. There must be something I can do.
If you need taglibs, you'll need to do TLS scanning. There really is
no way to avoid that that I know of. One of many reasons I don't like
JSP as a technology.

If you are having a problem with downtime, you have other options that
might help in other areas. For example, you could set up a second
server and load-balance between the two of them. This protects you
from a number of downtime-causing issues such as power failures, JVM
crashes, and -- as in your example here -- planned maintenance.

Running a single instance of your application in a production
environment where uptime matters is really not an appropriate
solution. If you had two servers, your application's restart time
would not have been an issue.

- -chris

> -Original Message- From: Mark Thomas
> [mailto:ma...@apache.org<mailto:ma...@apache.org>] Sent: Saturday, April 29, 
> 2017 5:02 AM
> To: Tomcat Users List 
> <users@tomcat.apache.org<mailto:users@tomcat.apache.org>> Subject: Re: Skip
> resource path in TLD scanner?
>
> On 28/04/17 17:00, Matt Cosentino wrote:
>> Yes, it's other folders within WEB-INF. I turned on the
>> TldScanner logging and it is definitely what is causing the
>> delay. My situation probably isn't very typical. The delay varies
>> in my various web applications, the worst being about 20 seconds.
>> It all adds up though, and every second counts when our sites are
>> down.
>
> There is a solution available but it is intended more for the
> embedded use case rather than a standard Tomcat install. Using it
> in a standard install would require (effectively) patching Tomcat.
>
> The general idea would be to use the TldPreScanned class. That does
> require all the TLDs to be listed in advance. On the plus side, no
> scanning delay. On the down side, adding TLDs requires code
> changes. Doing this with a standard Tomcat install requires changes
> to the JasperInitializer (hence the patch). I don't think there is
> a pure config way around that but I'll look into it.
>
> A better solution would probably be to make it easier to plugin in
> a custom TLDScanner - i.e. purely with config. If you'd like us to
> explore this option we should re-open 61052 and adjust accordingly.
> I don't think there is enough demand for filtering resource paths
> to make that worth implementing.
>
> One final thought. Are you running the web application from a WAR
> or an expanded directory? (The latter would be faster).
>
> Mark
>
>
>
>>
>> - Matt
>>
>>
>> -Original Message- From: Mark Thomas
>> [mailto:ma...@apache.org<mailto:ma...@apache.org>] Sent: Friday, April 28, 
>> 2017 7:28 AM
>> To: Tomcat Users List 
>> <users@tomcat.apache.org<mailto:users@tomcat.apache.org>> Subject: Re: Skip
>> resource path in TLD scanner?
>>
>> On 27/04/17 23:39, Matt Cosentino wrote:
>>> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
>>>
>>>
>>>
There is one for skipping jar files:
>>>
>>> tomcat.util.scan.StandardJarScanFilter.jarsToSkip
>>
>> 
>>
>>> It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not
>>> check any property to skip user defined paths.
>>
>> Is it other paths within WEB-INF you need to skip?
>>
>> When I read "skipping resource paths" I was thinking of skipping
>> the various places w

RE: Skip resource path in TLD scanner?

2017-11-20 Thread Matt Cosentino
While that is good advice, it's not necessarily an appropriate solution for 
this. It's not that I don't want any TLD scanning, it's that it is scanning 
folders that I know don't have TLDs and there is no reason to scan them. The 
scanner already decides to skip the classes and lib paths, so it could 
definitely skip a user defined list of paths. I guess for now I could see if I 
can move the files in these paths out of WEB-INF to keep them from being 
scanned.

- Matt

-Original Message-
From: Christopher Schultz [mailto:ch...@christopherschultz.net] 
Sent: Friday, November 17, 2017 12:26 PM
To: users@tomcat.apache.org
Subject: Re: Skip resource path in TLD scanner?

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Matt,

On 11/16/17 12:11 PM, Matt Cosentino wrote:
> This keeps getting worse, my site was down for over a minute while the 
> TLD scanner ran. There must be something I can do.
If you need taglibs, you'll need to do TLS scanning. There really is no way to 
avoid that that I know of. One of many reasons I don't like JSP as a technology.

If you are having a problem with downtime, you have other options that might 
help in other areas. For example, you could set up a second server and 
load-balance between the two of them. This protects you from a number of 
downtime-causing issues such as power failures, JVM crashes, and -- as in your 
example here -- planned maintenance.

Running a single instance of your application in a production environment where 
uptime matters is really not an appropriate solution. If you had two servers, 
your application's restart time would not have been an issue.

- -chris

> -Original Message- From: Mark Thomas [mailto:ma...@apache.org] 
> Sent: Saturday, April 29, 2017 5:02 AM
> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip 
> resource path in TLD scanner?
> 
> On 28/04/17 17:00, Matt Cosentino wrote:
>> Yes, it's other folders within WEB-INF. I turned on the TldScanner 
>> logging and it is definitely what is causing the delay. My situation 
>> probably isn't very typical. The delay varies in my various web 
>> applications, the worst being about 20 seconds.
>> It all adds up though, and every second counts when our sites are 
>> down.
> 
> There is a solution available but it is intended more for the embedded 
> use case rather than a standard Tomcat install. Using it in a standard 
> install would require (effectively) patching Tomcat.
> 
> The general idea would be to use the TldPreScanned class. That does 
> require all the TLDs to be listed in advance. On the plus side, no 
> scanning delay. On the down side, adding TLDs requires code changes. 
> Doing this with a standard Tomcat install requires changes to the 
> JasperInitializer (hence the patch). I don't think there is a pure 
> config way around that but I'll look into it.
> 
> A better solution would probably be to make it easier to plugin in a 
> custom TLDScanner - i.e. purely with config. If you'd like us to 
> explore this option we should re-open 61052 and adjust accordingly.
> I don't think there is enough demand for filtering resource paths to 
> make that worth implementing.
> 
> One final thought. Are you running the web application from a WAR or 
> an expanded directory? (The latter would be faster).
> 
> Mark
> 
> 
> 
>> 
>> - Matt
>> 
>> 
>> -----Original Message----- From: Mark Thomas 
>> [mailto:ma...@apache.org] Sent: Friday, April 28, 2017 7:28 AM
>> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip 
>> resource path in TLD scanner?
>> 
>> On 27/04/17 23:39, Matt Cosentino wrote:
>>> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
>>>
>>>
>>> 
There is one for skipping jar files:
>>> 
>>> tomcat.util.scan.StandardJarScanFilter.jarsToSkip
>> 
>> 
>> 
>>> It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not check 
>>> any property to skip user defined paths.
>> 
>> Is it other paths within WEB-INF you need to skip?
>> 
>> When I read "skipping resource paths" I was thinking of skipping the 
>> various places where Tomcat treat directories as JARs that then get 
>> scanned for TLDs (which can be configured via the JarScanner). But it 
>> sounds like skipping those won't help you.
>> 
>> How sure are you that it is checking the directories below WEB-INF 
>> that is the cause of the delay? That isn't a typical source of 
>> start-up delay although it is certainly possible.
>> 
>> Finally, what sort of delay are we talking out here? Seconds? 
>> Minutes?
>> 
>> Mark
>> 
>> 
>>> -Original Me

Re: Skip resource path in TLD scanner?

2017-11-18 Thread Alex O'Ree
I'm having similar issues after updating from tomcat7 to tomcat8.5. The
build script for my app adds some sql drivers to tomcat's lib folder,
specifically the derby driver. On bootup tomcat logs a ton of error
messages saying that it couldn't find (what looks to be) internationalized
resource files for derby, which aren't present.

On Fri, Nov 17, 2017 at 2:39 PM, Ray Holme <rayho...@yahoo.com.invalid>
wrote:

> I use JSP and there are taglibs used.
> But you can cut the scan time way down by not scanning any libraries that
> don't have TLDs
>  (nested files with name => .tld)
> You can find this by using "jar t" or "unzip -l" on each library (thanks
> Chris).
>
> If you are a Unix (Linux or MAC) user you may cheat a little by using the
> script attached.
> You may put any all .jar files in .../apache/lib or
> .../apache/webapps/*/WEB-INF/lib into the
>   .../apache/conf/catalina.properties file if they do not have taglibs.
> So 90% of what I need does not have taglibs (just jstl-impl-...jar DOES
> and must be left out of the DO NO SCAN line.
> This took my startup time from a couple minutes to under a second.
>
> Best of luck.
>
>
> On Friday, November 17, 2017 1:26 PM, Christopher Schultz <
> ch...@christopherschultz.net> wrote:
>
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Matt,
>
> On 11/16/17 12:11 PM, Matt Cosentino wrote:
> > This keeps getting worse, my site was down for over a minute while
> > the TLD scanner ran. There must be something I can do.
> If you need taglibs, you'll need to do TLS scanning. There really is
> no way to avoid that that I know of. One of many reasons I don't like
> JSP as a technology.
>
> If you are having a problem with downtime, you have other options that
> might help in other areas. For example, you could set up a second
> server and load-balance between the two of them. This protects you
> from a number of downtime-causing issues such as power failures, JVM
> crashes, and -- as in your example here -- planned maintenance.
>
> Running a single instance of your application in a production
> environment where uptime matters is really not an appropriate
> solution. If you had two servers, your application's restart time
> would not have been an issue.
>
> - -chris
>
> > -Original Message- From: Mark Thomas
> > [mailto:ma...@apache.org] Sent: Saturday, April 29, 2017 5:02 AM
> > To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip
> > resource path in TLD scanner?
> >
> > On 28/04/17 17:00, Matt Cosentino wrote:
> >> Yes, it's other folders within WEB-INF. I turned on the
> >> TldScanner logging and it is definitely what is causing the
> >> delay. My situation probably isn't very typical. The delay varies
> >> in my various web applications, the worst being about 20 seconds.
> >> It all adds up though, and every second counts when our sites are
> >> down.
> >
> > There is a solution available but it is intended more for the
> > embedded use case rather than a standard Tomcat install. Using it
> > in a standard install would require (effectively) patching Tomcat.
> >
> > The general idea would be to use the TldPreScanned class. That does
> > require all the TLDs to be listed in advance. On the plus side, no
> > scanning delay. On the down side, adding TLDs requires code
> > changes. Doing this with a standard Tomcat install requires changes
> > to the JasperInitializer (hence the patch). I don't think there is
> > a pure config way around that but I'll look into it.
> >
> > A better solution would probably be to make it easier to plugin in
> > a custom TLDScanner - i.e. purely with config. If you'd like us to
> > explore this option we should re-open 61052 and adjust accordingly.
> > I don't think there is enough demand for filtering resource paths
> > to make that worth implementing.
> >
> > One final thought. Are you running the web application from a WAR
> > or an expanded directory? (The latter would be faster).
> >
> > Mark
> >
> >
> >
> >>
> >> - Matt
> >>
> >>
> >> -Original Message- From: Mark Thomas
> >> [mailto:ma...@apache.org] Sent: Friday, April 28, 2017 7:28 AM
> >> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip
> >> resource path in TLD scanner?
> >>
> >> On 27/04/17 23:39, Matt Cosentino wrote:
> >>> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
> >>>
> >>>
> >>>
> There is one for skipping jar files:
>

Re: Skip resource path in TLD scanner?

2017-11-17 Thread Ray Holme
I use JSP and there are taglibs used.But you can cut the scan time way down by 
not scanning any libraries that don't have TLDs (nested files with name => 
.tld)You can find this by using "jar t" or "unzip -l" on each library (thanks 
Chris).
If you are a Unix (Linux or MAC) user you may cheat a little by using the 
script attached.You may put any all .jar files in .../apache/lib or 
.../apache/webapps/*/WEB-INF/lib into the 
  .../apache/conf/catalina.properties file if they do not have taglibs.So 90% 
of what I need does not have taglibs (just jstl-impl-...jar DOES and must be 
left out of the DO NO SCAN line.This took my startup time from a couple minutes 
to under a second.
Best of luck.
 

On Friday, November 17, 2017 1:26 PM, Christopher Schultz 
<ch...@christopherschultz.net> wrote:
 

 -BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Matt,

On 11/16/17 12:11 PM, Matt Cosentino wrote:
> This keeps getting worse, my site was down for over a minute while 
> the TLD scanner ran. There must be something I can do.
If you need taglibs, you'll need to do TLS scanning. There really is
no way to avoid that that I know of. One of many reasons I don't like
JSP as a technology.

If you are having a problem with downtime, you have other options that
might help in other areas. For example, you could set up a second
server and load-balance between the two of them. This protects you
from a number of downtime-causing issues such as power failures, JVM
crashes, and -- as in your example here -- planned maintenance.

Running a single instance of your application in a production
environment where uptime matters is really not an appropriate
solution. If you had two servers, your application's restart time
would not have been an issue.

- -chris

> -Original Message- From: Mark Thomas
> [mailto:ma...@apache.org] Sent: Saturday, April 29, 2017 5:02 AM 
> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip
> resource path in TLD scanner?
> 
> On 28/04/17 17:00, Matt Cosentino wrote:
>> Yes, it's other folders within WEB-INF. I turned on the
>> TldScanner logging and it is definitely what is causing the
>> delay. My situation probably isn't very typical. The delay varies
>> in my various web applications, the worst being about 20 seconds.
>> It all adds up though, and every second counts when our sites are
>> down.
> 
> There is a solution available but it is intended more for the
> embedded use case rather than a standard Tomcat install. Using it
> in a standard install would require (effectively) patching Tomcat.
> 
> The general idea would be to use the TldPreScanned class. That does
> require all the TLDs to be listed in advance. On the plus side, no
> scanning delay. On the down side, adding TLDs requires code
> changes. Doing this with a standard Tomcat install requires changes
> to the JasperInitializer (hence the patch). I don't think there is
> a pure config way around that but I'll look into it.
> 
> A better solution would probably be to make it easier to plugin in
> a custom TLDScanner - i.e. purely with config. If you'd like us to
> explore this option we should re-open 61052 and adjust accordingly.
> I don't think there is enough demand for filtering resource paths
> to make that worth implementing.
> 
> One final thought. Are you running the web application from a WAR
> or an expanded directory? (The latter would be faster).
> 
> Mark
> 
> 
> 
>> 
>> - Matt
>> 
>> 
>> -----Original Message- From: Mark Thomas
>> [mailto:ma...@apache.org] Sent: Friday, April 28, 2017 7:28 AM
>> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip
>> resource path in TLD scanner?
>> 
>> On 27/04/17 23:39, Matt Cosentino wrote:
>>> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
>>>
>>>
>>> 
There is one for skipping jar files:
>>> 
>>> tomcat.util.scan.StandardJarScanFilter.jarsToSkip
>> 
>> 
>> 
>>> It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not
>>> check any property to skip user defined paths.
>> 
>> Is it other paths within WEB-INF you need to skip?
>> 
>> When I read "skipping resource paths" I was thinking of skipping
>> the various places where Tomcat treat directories as JARs that
>> then get scanned for TLDs (which can be configured via the
>> JarScanner). But it sounds like skipping those won't help you.
>> 
>> How sure are you that it is checking the directories below
>> WEB-INF that is the cause of the delay? That isn't a typical
>> source of start-up delay although it is certainly possible.
>> 
>> Finally, what sort of delay are we t

Re: Skip resource path in TLD scanner?

2017-11-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Matt,

On 11/16/17 12:11 PM, Matt Cosentino wrote:
> This keeps getting worse, my site was down for over a minute while 
> the TLD scanner ran. There must be something I can do.
If you need taglibs, you'll need to do TLS scanning. There really is
no way to avoid that that I know of. One of many reasons I don't like
JSP as a technology.

If you are having a problem with downtime, you have other options that
might help in other areas. For example, you could set up a second
server and load-balance between the two of them. This protects you
from a number of downtime-causing issues such as power failures, JVM
crashes, and -- as in your example here -- planned maintenance.

Running a single instance of your application in a production
environment where uptime matters is really not an appropriate
solution. If you had two servers, your application's restart time
would not have been an issue.

- -chris

> -Original Message- From: Mark Thomas
> [mailto:ma...@apache.org] Sent: Saturday, April 29, 2017 5:02 AM 
> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip
> resource path in TLD scanner?
> 
> On 28/04/17 17:00, Matt Cosentino wrote:
>> Yes, it's other folders within WEB-INF. I turned on the
>> TldScanner logging and it is definitely what is causing the
>> delay. My situation probably isn't very typical. The delay varies
>> in my various web applications, the worst being about 20 seconds.
>> It all adds up though, and every second counts when our sites are
>> down.
> 
> There is a solution available but it is intended more for the
> embedded use case rather than a standard Tomcat install. Using it
> in a standard install would require (effectively) patching Tomcat.
> 
> The general idea would be to use the TldPreScanned class. That does
> require all the TLDs to be listed in advance. On the plus side, no
> scanning delay. On the down side, adding TLDs requires code
> changes. Doing this with a standard Tomcat install requires changes
> to the JasperInitializer (hence the patch). I don't think there is
> a pure config way around that but I'll look into it.
> 
> A better solution would probably be to make it easier to plugin in
> a custom TLDScanner - i.e. purely with config. If you'd like us to
> explore this option we should re-open 61052 and adjust accordingly.
> I don't think there is enough demand for filtering resource paths
> to make that worth implementing.
> 
> One final thought. Are you running the web application from a WAR
> or an expanded directory? (The latter would be faster).
> 
> Mark
> 
> 
> 
>> 
>> - Matt
>> 
>> 
>> -----Original Message- From: Mark Thomas
>> [mailto:ma...@apache.org] Sent: Friday, April 28, 2017 7:28 AM
>> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip
>> resource path in TLD scanner?
>> 
>> On 27/04/17 23:39, Matt Cosentino wrote:
>>> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
>>>
>>>
>>> 
There is one for skipping jar files:
>>> 
>>> tomcat.util.scan.StandardJarScanFilter.jarsToSkip
>> 
>> 
>> 
>>> It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not
>>> check any property to skip user defined paths.
>> 
>> Is it other paths within WEB-INF you need to skip?
>> 
>> When I read "skipping resource paths" I was thinking of skipping
>> the various places where Tomcat treat directories as JARs that
>> then get scanned for TLDs (which can be configured via the
>> JarScanner). But it sounds like skipping those won't help you.
>> 
>> How sure are you that it is checking the directories below
>> WEB-INF that is the cause of the delay? That isn't a typical
>> source of start-up delay although it is certainly possible.
>> 
>> Finally, what sort of delay are we talking out here? Seconds? 
>> Minutes?
>> 
>> Mark
>> 
>> 
>>> -Original Message- From: Mark Thomas 
>>> [mailto:ma...@apache.org] Sent: Thursday, April 27, 2017 5:05
>>> PM To: Tomcat Users List <users@tomcat.apache.org> Subject: Re:
>>> Skip resource path in TLD scanner?
>>> 
>>> On 27/04/17 21:17, Matt Cosentino wrote:
>>>> I need to skip some of the resource paths within WEB-INF. I
>>>> know there's a property for skipping jar files, but I
>>>> couldn't find one for resource paths. I reported this as a
>>>> bug and was told that the property exists. Where is it?
>>> 
>>> Where have you looked?
>>> 
>>> Mark
>> 
>> -

RE: Skip resource path in TLD scanner?

2017-11-16 Thread Matt Cosentino
This keeps getting worse, my site was down for over a minute while the TLD 
scanner ran. There must be something I can do.

- Matt

-Original Message-
From: Mark Thomas [mailto:ma...@apache.org] 
Sent: Saturday, April 29, 2017 5:02 AM
To: Tomcat Users List <users@tomcat.apache.org>
Subject: Re: Skip resource path in TLD scanner?

On 28/04/17 17:00, Matt Cosentino wrote:
> Yes, it's other folders within WEB-INF. I turned on the TldScanner 
> logging and it is definitely what is causing the delay. My situation 
> probably isn't very typical. The delay varies in my various web 
> applications, the worst being about 20 seconds. It all adds up though, 
> and every second counts when our sites are down.

There is a solution available but it is intended more for the embedded use case 
rather than a standard Tomcat install. Using it in a standard install would 
require (effectively) patching Tomcat.

The general idea would be to use the TldPreScanned class. That does require all 
the TLDs to be listed in advance. On the plus side, no scanning delay. On the 
down side, adding TLDs requires code changes.
Doing this with a standard Tomcat install requires changes to the 
JasperInitializer (hence the patch). I don't think there is a pure config way 
around that but I'll look into it.

A better solution would probably be to make it easier to plugin in a custom 
TLDScanner - i.e. purely with config. If you'd like us to explore this option 
we should re-open 61052 and adjust accordingly. I don't think there is enough 
demand for filtering resource paths to make that worth implementing.

One final thought. Are you running the web application from a WAR or an 
expanded directory? (The latter would be faster).

Mark



> 
> - Matt
> 
> 
> -Original Message- From: Mark Thomas [mailto:ma...@apache.org] 
> Sent: Friday, April 28, 2017 7:28 AM To:
> Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip resource 
> path in TLD scanner?
> 
> On 27/04/17 23:39, Matt Cosentino wrote:
>> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
>> 
>> There is one for skipping jar files:
>> 
>> tomcat.util.scan.StandardJarScanFilter.jarsToSkip
> 
> 
> 
>> It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not check 
>> any property to skip user defined paths.
> 
> Is it other paths within WEB-INF you need to skip?
> 
> When I read "skipping resource paths" I was thinking of skipping the 
> various places where Tomcat treat directories as JARs that then get 
> scanned for TLDs (which can be configured via the JarScanner). But it 
> sounds like skipping those won't help you.
> 
> How sure are you that it is checking the directories below WEB-INF 
> that is the cause of the delay? That isn't a typical source of 
> start-up delay although it is certainly possible.
> 
> Finally, what sort of delay are we talking out here? Seconds?
> Minutes?
> 
> Mark
> 
> 
>> -Original Message- From: Mark Thomas 
>> [mailto:ma...@apache.org] Sent: Thursday, April 27, 2017 5:05 PM
>> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip 
>> resource path in TLD scanner?
>> 
>> On 27/04/17 21:17, Matt Cosentino wrote:
>>> I need to skip some of the resource paths within WEB-INF. I know  
>>> there's a property for skipping jar files, but I couldn't find one 
>>> for resource paths. I reported this as a bug and was told that the 
>>> property exists. Where is it?
>> 
>> Where have you looked?
>> 
>> Mark
> 
> -
>
> 
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
> 
> 
> -
>
> 
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Skip resource path in TLD scanner?

2017-04-29 Thread Mark Thomas
On 28/04/17 17:00, Matt Cosentino wrote:
> Yes, it's other folders within WEB-INF. I turned on the TldScanner
> logging and it is definitely what is causing the delay. My situation
> probably isn't very typical. The delay varies in my various web
> applications, the worst being about 20 seconds. It all adds up
> though, and every second counts when our sites are down.

There is a solution available but it is intended more for the embedded
use case rather than a standard Tomcat install. Using it in a standard
install would require (effectively) patching Tomcat.

The general idea would be to use the TldPreScanned class. That does
require all the TLDs to be listed in advance. On the plus side, no
scanning delay. On the down side, adding TLDs requires code changes.
Doing this with a standard Tomcat install requires changes to the
JasperInitializer (hence the patch). I don't think there is a pure
config way around that but I'll look into it.

A better solution would probably be to make it easier to plugin in a
custom TLDScanner - i.e. purely with config. If you'd like us to explore
this option we should re-open 61052 and adjust accordingly. I don't
think there is enough demand for filtering resource paths to make that
worth implementing.

One final thought. Are you running the web application from a WAR or an
expanded directory? (The latter would be faster).

Mark



> 
> - Matt
> 
> 
> -Original Message- From: Mark Thomas
> [mailto:ma...@apache.org] Sent: Friday, April 28, 2017 7:28 AM To:
> Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip
> resource path in TLD scanner?
> 
> On 27/04/17 23:39, Matt Cosentino wrote:
>> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
>> 
>> There is one for skipping jar files:
>> 
>> tomcat.util.scan.StandardJarScanFilter.jarsToSkip
> 
> 
> 
>> It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not check
>> any property to skip user defined paths.
> 
> Is it other paths within WEB-INF you need to skip?
> 
> When I read "skipping resource paths" I was thinking of skipping the
> various places where Tomcat treat directories as JARs that then get
> scanned for TLDs (which can be configured via the JarScanner). But it
> sounds like skipping those won't help you.
> 
> How sure are you that it is checking the directories below WEB-INF
> that is the cause of the delay? That isn't a typical source of
> start-up delay although it is certainly possible.
> 
> Finally, what sort of delay are we talking out here? Seconds?
> Minutes?
> 
> Mark
> 
> 
>> -----Original Message----- From: Mark Thomas
>> [mailto:ma...@apache.org] Sent: Thursday, April 27, 2017 5:05 PM 
>> To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: Skip
>> resource path in TLD scanner?
>> 
>> On 27/04/17 21:17, Matt Cosentino wrote:
>>> I need to skip some of the resource paths within WEB-INF. I know
>>>  there's a property for skipping jar files, but I couldn't find
>>> one for resource paths. I reported this as a bug and was told
>>> that the property exists. Where is it?
>> 
>> Where have you looked?
>> 
>> Mark
> 
> -
>
> 
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
> 
> 
> -
>
> 
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



RE: Skip resource path in TLD scanner?

2017-04-28 Thread Matt Cosentino
Yes, it's other folders within WEB-INF. I turned on the TldScanner logging and 
it is definitely what is causing the delay. My situation probably isn't very 
typical. The delay varies in my various web applications, the worst being about 
20 seconds. It all adds up though, and every second counts when our sites are 
down.

- Matt


-Original Message-
From: Mark Thomas [mailto:ma...@apache.org] 
Sent: Friday, April 28, 2017 7:28 AM
To: Tomcat Users List <users@tomcat.apache.org>
Subject: Re: Skip resource path in TLD scanner?

On 27/04/17 23:39, Matt Cosentino wrote:
> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
> 
> There is one for skipping jar files:
> 
> tomcat.util.scan.StandardJarScanFilter.jarsToSkip



> It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not check any 
> property to skip user defined paths.

Is it other paths within WEB-INF you need to skip?

When I read "skipping resource paths" I was thinking of skipping the various 
places where Tomcat treat directories as JARs that then get scanned for TLDs 
(which can be configured via the JarScanner). But it sounds like skipping those 
won't help you.

How sure are you that it is checking the directories below WEB-INF that is the 
cause of the delay? That isn't a typical source of start-up delay although it 
is certainly possible.

Finally, what sort of delay are we talking out here? Seconds? Minutes?

Mark


> -Original Message-
> From: Mark Thomas [mailto:ma...@apache.org]
> Sent: Thursday, April 27, 2017 5:05 PM
> To: Tomcat Users List <users@tomcat.apache.org>
> Subject: Re: Skip resource path in TLD scanner?
> 
> On 27/04/17 21:17, Matt Cosentino wrote:
>> I need to skip some of the resource paths within WEB-INF. I know 
>> there's a property for skipping jar files, but I couldn't find one 
>> for resource paths. I reported this as a bug and was told that the 
>> property exists. Where is it?
> 
> Where have you looked?
> 
> Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



RE: Skip resource path in TLD scanner?

2017-04-28 Thread Matt Cosentino
I already did, that only mentions skipping jar files.

- Matt


-Original Message-
From: Violeta Georgieva [mailto:violet...@apache.org] 
Sent: Friday, April 28, 2017 1:30 AM
To: Tomcat Users List <users@tomcat.apache.org>
Subject: Re: Skip resource path in TLD scanner?

Hi,

2017-04-27 23:17 GMT+03:00 Matt Cosentino <mcosent...@cacorp.com>:
>
> I need to skip some of the resource paths within WEB-INF. I know 
> there's
a property for skipping jar files, but I couldn't find one for resource paths. 
I reported this as a bug and was told that the property exists.
Where is it?

Check this wiki https://wiki.apache.org/tomcat/HowTo/FasterStartUp

Regards,
Violeta

> - Matt
>


Re: Skip resource path in TLD scanner?

2017-04-28 Thread Mark Thomas
On 27/04/17 23:39, Matt Cosentino wrote:
> https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html
> 
> There is one for skipping jar files:
> 
> tomcat.util.scan.StandardJarScanFilter.jarsToSkip



> It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not check any 
> property to skip user defined paths.

Is it other paths within WEB-INF you need to skip?

When I read "skipping resource paths" I was thinking of skipping the
various places where Tomcat treat directories as JARs that then get
scanned for TLDs (which can be configured via the JarScanner). But it
sounds like skipping those won't help you.

How sure are you that it is checking the directories below WEB-INF that
is the cause of the delay? That isn't a typical source of start-up delay
although it is certainly possible.

Finally, what sort of delay are we talking out here? Seconds? Minutes?

Mark


> -Original Message-
> From: Mark Thomas [mailto:ma...@apache.org] 
> Sent: Thursday, April 27, 2017 5:05 PM
> To: Tomcat Users List <users@tomcat.apache.org>
> Subject: Re: Skip resource path in TLD scanner?
> 
> On 27/04/17 21:17, Matt Cosentino wrote:
>> I need to skip some of the resource paths within WEB-INF. I know 
>> there's a property for skipping jar files, but I couldn't find one for 
>> resource paths. I reported this as a bug and was told that the 
>> property exists. Where is it?
> 
> Where have you looked?
> 
> Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Skip resource path in TLD scanner?

2017-04-28 Thread Violeta Georgieva
Hi,

2017-04-27 23:17 GMT+03:00 Matt Cosentino :
>
> I need to skip some of the resource paths within WEB-INF. I know there's
a property for skipping jar files, but I couldn't find one for resource
paths. I reported this as a bug and was told that the property exists.
Where is it?

Check this wiki https://wiki.apache.org/tomcat/HowTo/FasterStartUp

Regards,
Violeta

> - Matt
>


RE: Skip resource path in TLD scanner?

2017-04-27 Thread Matt Cosentino
https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html

There is one for skipping jar files:

tomcat.util.scan.StandardJarScanFilter.jarsToSkip

I then looked at the source for TldScanner, here is the scanResourcePaths 
function:

/**
 * Scan web application resources for TLDs, recursively.
 *
 * @param startPath the directory resource to scan
 * @throws IOException  if there was a problem scanning for or loading a TLD
 * @throws SAXException if there was a problem parsing a TLD
 */
protected void scanResourcePaths(String startPath)
throws IOException, SAXException {

Set dirList = context.getResourcePaths(startPath);
if (dirList != null) {
for (String path : dirList) {
if (path.startsWith("/WEB-INF/classes/")) {
// Skip: JSP.7.3.1
} else if (path.startsWith("/WEB-INF/lib/")) {
// Skip: JSP.7.3.1
} else if (path.endsWith("/")) {
scanResourcePaths(path);
} else if (path.startsWith("/WEB-INF/tags/")) {
// JSP 7.3.1: in /WEB-INF/tags only consider implicit.tld
if (path.endsWith("/implicit.tld")) {
parseTld(path);
}
} else if (path.endsWith(TLD_EXT)) {
parseTld(path);
}
}
}
}

It skips /WEB-INF/classes/ and /WEB-INF/lib/, but it does not check any 
property to skip user defined paths.

- Matt


-Original Message-
From: Mark Thomas [mailto:ma...@apache.org] 
Sent: Thursday, April 27, 2017 5:05 PM
To: Tomcat Users List <users@tomcat.apache.org>
Subject: Re: Skip resource path in TLD scanner?

On 27/04/17 21:17, Matt Cosentino wrote:
> I need to skip some of the resource paths within WEB-INF. I know 
> there's a property for skipping jar files, but I couldn't find one for 
> resource paths. I reported this as a bug and was told that the 
> property exists. Where is it?

Where have you looked?

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Skip resource path in TLD scanner?

2017-04-27 Thread Mark Thomas
On 27/04/17 21:17, Matt Cosentino wrote:
> I need to skip some of the resource paths within WEB-INF. I know
> there's a property for skipping jar files, but I couldn't find one
> for resource paths. I reported this as a bug and was told that the
> property exists. Where is it?

Where have you looked?

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org