Re: RemoteIP valve and multiple X-Forwarded-For headers

2011-01-11 Thread Brett Delle Grazie
Hi, On 10 December 2010 14:42, Jim Riggs apache-li...@riggs.me wrote: On Dec 10, 2010, at 7:59 AM, Mark Thomas wrote: Looks like a bug, Please add it to bugzilla, as Mark suggested. BTW, I think that the following change can fix it: (for current tc6.0.x, not tested!) I don't think so. I

RemoteIP valve and multiple X-Forwarded-For headers

2010-12-10 Thread Brett Delle Grazie
Hi, We're using: RHEL5 (fully up to date) Tomcat 6.0.29 (from apache.org) JVM 1.6.0_22 We use HAproxy (1.4.8) as a front end to Tomcat, HAproxy uses the 'option forwardfor' which adds an additional X-Forwarded-For header to the request. Everything works fine except if the client has an

Re: RemoteIP valve and multiple X-Forwarded-For headers

2010-12-10 Thread Mark Thomas
On 10/12/2010 13:03, Brett Delle Grazie wrote: Hi, We're using: RHEL5 (fully up to date) Tomcat 6.0.29 (from apache.org) JVM 1.6.0_22 We use HAproxy (1.4.8) as a front end to Tomcat, HAproxy uses the 'option forwardfor' which adds an additional X-Forwarded-For header to the request.

Re: RemoteIP valve and multiple X-Forwarded-For headers

2010-12-10 Thread Konstantin Kolinko
2010/12/10 Brett Delle Grazie brett.dellegra...@gmail.com: (...) Everything works fine except if the client has an X-Forwarded-For header _already_ in the request (perhaps due to Squid in forward proxy on client side). Thus offending request looks like: Headers (fake IP addresses used):

Re: RemoteIP valve and multiple X-Forwarded-For headers

2010-12-10 Thread Mark Thomas
On 10/12/2010 13:54, Konstantin Kolinko wrote: 2010/12/10 Brett Delle Grazie brett.dellegra...@gmail.com: (...) Everything works fine except if the client has an X-Forwarded-For header _already_ in the request (perhaps due to Squid in forward proxy on client side). Thus offending request

Re: RemoteIP valve and multiple X-Forwarded-For headers

2010-12-10 Thread Brett Delle Grazie
On 10 December 2010 13:59, Mark Thomas ma...@apache.org wrote: On 10/12/2010 13:54, Konstantin Kolinko wrote: 2010/12/10 Brett Delle Grazie brett.dellegra...@gmail.com: (...) Everything works fine except if the client has an X-Forwarded-For header _already_ in the request (perhaps due

Re: RemoteIP valve and multiple X-Forwarded-For headers

2010-12-10 Thread Jim Riggs
On Dec 10, 2010, at 7:59 AM, Mark Thomas wrote: Looks like a bug, Please add it to bugzilla, as Mark suggested. BTW, I think that the following change can fix it: (for current tc6.0.x, not tested!) I don't think so. I think the problem is further up on line 558: String[]