Re: Request for comments: Apache-like allow/deny remote host filtering

2011-10-04 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Francis, On 10/2/2011 3:57 PM, Francis GALIEGUE wrote: On Sun, Oct 2, 2011 at 19:46, Konstantin Kolinko knst.koli...@gmail.com wrote: 2011/10/2 Francis GALIEGUE f...@one2team.com: 1. If you want to submit it as a patch for Tomcat, you should

Re: Request for comments: Apache-like allow/deny remote host filtering

2011-10-04 Thread Francis GALIEGUE
On Tue, Oct 4, 2011 at 20:43, Christopher Schultz ch...@christopherschultz.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Francis, On 10/2/2011 3:57 PM, Francis GALIEGUE wrote: On Sun, Oct 2, 2011 at 19:46, Konstantin Kolinko knst.koli...@gmail.com wrote: 2011/10/2 Francis

Re: Request for comments: Apache-like allow/deny remote host filtering

2011-10-04 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Francis, On 10/4/2011 2:50 PM, Francis GALIEGUE wrote: Patch attached. I didn't know Bugzilla would treat patches this way... Can you give us a link to the bug? I implemented those two interfaces again, since the existing abstract class

Re: Request for comments: Apache-like allow/deny remote host filtering

2011-10-04 Thread Francis GALIEGUE
On Tue, Oct 4, 2011 at 21:02, Christopher Schultz ch...@christopherschultz.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Francis, On 10/4/2011 2:50 PM, Francis GALIEGUE wrote: Patch attached. I didn't know Bugzilla would treat patches this way... Can you give us a link to the

Request for comments: Apache-like allow/deny remote host filtering

2011-10-02 Thread Francis GALIEGUE
Hello list, Given the problems I've had with the RemoteAddrValve, I have decided to try my hands at implementing a more sophisticated valve which acts more like Apache's allow/deny and which takes netmasks as arguments. Note, it has been compile tested only (in my IDE, mind), and I have tested

Re: Request for comments: Apache-like allow/deny remote host filtering

2011-10-02 Thread Konstantin Kolinko
2011/10/2 Francis GALIEGUE f...@one2team.com: Hello list, Given the problems I've had with the RemoteAddrValve, I have decided to try my hands at implementing a more sophisticated valve which acts more like Apache's allow/deny and which takes netmasks as arguments. Note, it has been compile

Re: Request for comments: Apache-like allow/deny remote host filtering

2011-10-02 Thread Francis GALIEGUE
On Sun, Oct 2, 2011 at 19:46, Konstantin Kolinko knst.koli...@gmail.com wrote: 2011/10/2 Francis GALIEGUE f...@one2team.com: 1. If you want to submit it as a patch for Tomcat, you should attach it to a Bugzilla issue. OK, will do. 2. Coding conventions: