Re: RequestDumperFilter improvement

2010-11-13 Thread Mark Thomas
On 12/11/2010 20:51, Christopher Schultz wrote: All, I would like to propose a new feature for the RequestDumperFilter that is similar to the AccessLogValve's condition setting, except that it is logically opposite: it would be nice to allow a Filter ahead of the RequestDumperFilter in the

RequestDumperFilter improvement

2010-11-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All, I would like to propose a new feature for the RequestDumperFilter that is similar to the AccessLogValve's condition setting, except that it is logically opposite: it would be nice to allow a Filter ahead of the RequestDumperFilter in the chain

Re: RequestDumperFilter improvement

2010-11-12 Thread Ognjen Blagojevic
On 12.11.2010 21:51, Christopher Schultz wrote: 1. condition. This may cause confusion as it acts the opposite way to AccessLogValve's condition. 2. ifSet or even if 3. Give the user a choice: ifSet /and/ ifUnset (or both!) I like no. 3, to have it both. It's clear and flexible. BTW, it