Re: Should Tomcat continue to support SSI?

2017-06-08 Thread Mark Thomas
On 07/06/17 16:34, Emmanuel Bourg wrote:
> Le 7/06/2017 à 16:51, Christopher Schultz a écrit :
> 
>> What about separating SSI out into a separate (sub?) project and
>> removing it from Tomcat core?
> 
> +1, I was about to suggest this as well.

I was more motivated by reducing the volume code we have to maintain
rather than the volume of code we ship by default.

I've no objection if someone wants to tweak the build to split this out
into a separate module but I'm still interested to hear if anyone is
using this code.

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Should Tomcat continue to support SSI?

2017-06-07 Thread Emmanuel Bourg
Le 7/06/2017 à 16:51, Christopher Schultz a écrit :

> What about separating SSI out into a separate (sub?) project and
> removing it from Tomcat core?

+1, I was about to suggest this as well.

Emmanuel Bourg

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Should Tomcat continue to support SSI?

2017-06-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 6/7/17 4:58 AM, Mark Thomas wrote:
> Hi all,
> 
> One of the topics of discussion at TomcatCon was the features that
> have been removed in Tomcat 9 / could be removed in future Tomcat
> versions. One of those features was support for Server Side
> Includes.
> 
> The last meaningful change to the SSI code was ~4 years ago to fix
> this bug against Tomcat 7: 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=55176
> 
> There are several possible reasons for the lack of changes to this
> code. It could be that the SSI code is stable and folks are using
> it without issue. It could also be that no-one is using the code at
> all. If it is the latter, then in makes sense to remove it in
> Tomcat 9.
> 
> So, is anyone using SSI?

What about separating SSI out into a separate (sub?) project and
removing it from Tomcat core?

That way, a standard installation would no longer ship with it, but
users could add it if they wanted to.

It appears that everything is already well-encapsulated and the
filter/servlet could be moved to a separate (distribution) package.

- -chris
-BEGIN PGP SIGNATURE-
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJZOBLlAAoJEBzwKT+lPKRYccMP/3WdnmKvbuEBq7KHLVxAfbkU
GhEYgFQmEp6qR4376MNGGCPWRoBnItQlvqSddMVCuV8D6ROVhFPAjcjByoFeg7d5
hwBjAI8qVKulF2EJZSupPcl6LyKlvvQYlko25UiYRSxmhCP4RA7YAucf6plVoG65
m0RZjrdXjD9Ky8JN6WpLpm8wjcdCPTeZRodOmxHdqSGe5Nz2DBZSyWBeyw7tbbuZ
Y/zf4rb11nkCT0X1FLjAkop8llZcGEMGl8gtA5tZrPM9cQFQBAXPamDO0czJxEwL
ZuMePgTOKXZFdEwTon7sA01sldr3BZeus07SIbBMF2vO+VselfxTXRHVvHEdEwTq
tfTYKraZLDJHOqwutSuS/fNtUI1W6rl5MUWPggNeuRW/51U+oGncQEEptKjw5FLo
iN/MxXe60mw6+KCp3enWAlnQVw+i7MDCy6Ak1eJDuyUQfwalMBoGkqkWuJPzjUQh
hKQd00M71zeZM24AHz5NXcZ91eDz717PFCjBzHtlo1HwBUPYb1rSJSh83T1YXMzc
tNAy5RmOvWD9EcPyy8OWLJnULWp/leQg5ilVZZgFtzK7lfUPeVfGpcFtJntF7VwS
NbMR2zb+ZS8VZppdlGWXNx8F0TlpQSPyLxZpIZTyUZ5u8e7u9/mJJ3ryQcM0GuLu
tIlotwxLw8WZVIhRqkUu
=cVR/
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Should Tomcat continue to support SSI?

2017-06-07 Thread Mark Thomas
Hi all,

One of the topics of discussion at TomcatCon was the features that have
been removed in Tomcat 9 / could be removed in future Tomcat versions.
One of those features was support for Server Side Includes.

The last meaningful change to the SSI code was ~4 years ago to fix this
bug against Tomcat 7:
https://bz.apache.org/bugzilla/show_bug.cgi?id=55176

There are several possible reasons for the lack of changes to this code.
It could be that the SSI code is stable and folks are using it without
issue. It could also be that no-one is using the code at all. If it is
the latter, then in makes sense to remove it in Tomcat 9.

So, is anyone using SSI?

Thanks,

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org