Re: Support for JDK only by Windows Installer?
On 16/11/2019 09:29, Alexander Norz wrote: > Am 15.11.2019 22:23, schrieb Mark Thomas: > > That is the point: > >> Because Oracle changed the directory layout and names of the standard >> registry entries and the installer probably hasn't been updated to take >> account of that yet. > > The environment variable JAVA_HOME isn't supported actually. > > I added this as the last check after JRE64/32, JRE in JDK, now new JDK > only and then environment variable. > > We can discus to use environment variable first of all? I think this > could be more common? Thanks for the PR. Mark - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
Re: Support for JDK only by Windows Installer?
сб, 16 нояб. 2019 г. в 12:08, Alexander Norz : > > Am 15.11.2019 22:23, schrieb Mark Thomas: > > > > > > Patches welcome. > > > > Mark > > > > A patch is nearly ready. I will sent a pull request asap. I think that you should start with a real reproducible description of the issue (in Bugzilla). What JDK are you using, from what vendor, and what are the steps to reproduce the issue. > But because of getting no error code and finding no log-file after a failed > silent installation. Generally, 1) Without a JDK the installer cannot really choose whether to install 32-bit or 64-bit binaries. I think that we can default to 64-bit nowadays. 2) The JDK can be reconfigured later, via configuration manager (tomcat9w.exe) or by editing the registry. >From 1) it is odd that the installer does not fail, but from 2) you can always fix it afterwards (as long as CPU architecture is chosen correctly and the correct binaries are installed). > The environment variable JAVA_HOME isn't supported actually. >From my experience with installing the service with service.bat, the environment variables are lost when a program runs with elevated privileges. That is why service.bat was changed to pass all settings as command line arguments when installing a service (calling tomcat9[w].exe). You may find a reference to Bugzilla issue in the commit history of the service.bat file. Best regards, Konstantin Kolinko > Alexander > > - > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
Re: Support for JDK only by Windows Installer?
Am 15.11.2019 22:23, schrieb Mark Thomas: That is the point: Because Oracle changed the directory layout and names of the standard registry entries and the installer probably hasn't been updated to take account of that yet. The environment variable JAVA_HOME isn't supported actually. I added this as the last check after JRE64/32, JRE in JDK, now new JDK only and then environment variable. We can discus to use environment variable first of all? I think this could be more common? Alexander - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
Re: Support for JDK only by Windows Installer?
Am 15.11.2019 22:23, schrieb Mark Thomas: Patches welcome. Mark A patch is nearly ready. I will sent a pull request asap. Alexander - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
Re: Support for JDK only by Windows Installer?
On 15/11/2019 15:50, Alexander Norz wrote: > Hello, > > is there a good point why the Windows Service Installer > (apache-tomcat-9.0.27.exe) did not support Oracles Java JDK (11 without > JRE) out-of-the-box especially for silent installation? Because Oracle changed the directory layout and names of the standard registry entries and the installer probably hasn't been updated to take account of that yet. > Meanwhile I know that I have to add a config-file with parameter /C for > silent installation. But because of getting no error code and finding no > log-file after a failed silent installation, it needs some time to solve > this issue ;-) > > IMHO unfortunately the installer does not look for Java by using the > JAVA_HOME environment variable and also does not check the registry key > HKLM\SOFTWARE\JavaSoft\JDK for some reasons. > > I suggest to add the JDK registry key and JAVA_HOME envvar to the > install script (source/res/tomcat.nsi), if there is no reason against to > use JDK only? Patches welcome. Mark - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
Support for JDK only by Windows Installer?
Hello, is there a good point why the Windows Service Installer (apache-tomcat-9.0.27.exe) did not support Oracles Java JDK (11 without JRE) out-of-the-box especially for silent installation? Meanwhile I know that I have to add a config-file with parameter /C for silent installation. But because of getting no error code and finding no log-file after a failed silent installation, it needs some time to solve this issue ;-) IMHO unfortunately the installer does not look for Java by using the JAVA_HOME environment variable and also does not check the registry key HKLM\SOFTWARE\JavaSoft\JDK for some reasons. I suggest to add the JDK registry key and JAVA_HOME envvar to the install script (source/res/tomcat.nsi), if there is no reason against to use JDK only? Best regards Alexander - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
