Re: Why org.apache.tomcat.util.threads.TaskQueue#offer doesn't have synchronized modifier?

2022-04-26 Thread Christopher Schultz
To whom it may concern, On 4/25/22 22:01, z...@sina.com wrote: a large number of http requests: 400+ Please post your complete configuration (without any secrets) and explain your testing methodology. Are you using any reverse-proxy between the client and the Tomcat node? -chris

Re: Why org.apache.tomcat.util.threads.TaskQueue#offer doesn't have synchronized modifier?

2022-04-25 Thread zrlw
a large number of http requests: 400+

Re: Why org.apache.tomcat.util.threads.TaskQueue#offer doesn't have synchronized modifier?

2022-04-25 Thread Christopher Schultz
To whom it may concern. On 4/21/22 01:50, z...@sina.com wrote: TaskQueue extendsLinkedBlockingQueue and most calls to TaskQueue.offer end up callingsuper.offer which provides the necessary thread-safety. 2. the issue is that TaskQueue.offer return false directly instead of calling

Re: Why org.apache.tomcat.util.threads.TaskQueue#offer doesn't have synchronized modifier?

2022-04-20 Thread zrlw
> TaskQueue extendsLinkedBlockingQueue and most calls to TaskQueue.offer end up > callingsuper.offer which provides the necessary thread-safety. 2. the issue is that TaskQueue.offer return false directly instead of calling supper.offer when huge requests (more than maximum pool size, but

Re: Why org.apache.tomcat.util.threads.TaskQueue#offer doesn't have synchronized modifier?

2022-04-20 Thread zrlw
- Original Message - From: Christopher Schultz To: users@tomcat.apache.org Subject: Re: Why org.apache.tomcat.util.threads.TaskQueue#offer doesn't have synchronized modifier? Date: 2022-04-20 01:32 1. "server.tomcat.max-threads" is a setting which is defined in spring-con

Re: Why org.apache.tomcat.util.threads.TaskQueue#offer doesn't have synchronized modifier?

2022-04-19 Thread Christopher Schultz
To whom it may concern, On 4/18/22 23:55, z...@sina.com wrote: Tomcat version: 9.0.62https://github.com/apache/tomcat/blob/9.0.62/java/org/apache/tomcat/util/threads/TaskQueue.java#L116 //if we have less threads than maximum force creation of a new thread if

Why org.apache.tomcat.util.threads.TaskQueue#offer doesn't have synchronized modifier?

2022-04-18 Thread zrlw
Tomcat version: 9.0.62https://github.com/apache/tomcat/blob/9.0.62/java/org/apache/tomcat/util/threads/TaskQueue.java#L116 //if we have less threads than maximum force creation of a new thread if (parent.getPoolSize()