Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-11 Thread Alex O'Ree
OK some updates. I compiled this afternoon off of the tomcat 8.5.x branch
and made changes to SmapUtil.java around line 206 give or take.
The changes were basically
if (!tmpFile.renameTo(...)) {
Files.move(tmpFile.toPath(), classFile.toPath(),
StandardCopyOption.REPLACE_EXISTING);
}

Variables:
- Environmental, there was a reboot in between test scenarios
- Moving from 8.5.40 to head

Result:
At first it was promising that i thought it may have been fixed, however I
did run into another exception with the Files.move call, exception was
file exists already. Previously, it was maybe 1/100 jsps, now it's closer
to 1 of 400. Definitely better, but is it because of the update to the
newer
code base or is it due to the code change i made. I'll do some more
experiments tomorrow to try and narrow it down



On Mon, Jun 10, 2019 at 3:32 PM Alex O'Ree  wrote:

> > Anything unusual about that file system?
>
> Nope, just a standard NTFS windows 7 setup. I've seen in a development
> environment (no special file permissions) and in more of a production
> environment on win10 and server 2016 whereby the file system is locked down
> in a similar fashion to how it's done on linux.
>
> > How much load (users, req/s) is the system under?
>
> In terms of the jsp error, this particular app is typically just a single
> user hitting it. There's lots of other non-jsp traffic to the server
> though. I've also seen this error a lot in my dev setup.
>
> > Any changes from default JSP Servlet (Jasper) settings?
>
> none
>
> > Does the access log indicate concurrent access for the problematic
> resources?
>
> Well. It's happening pretty frequently during a controlled set of selenium
> unit tests. It's a single browser session doing http get's to all the jsp
> pages one at a time, primarily just to ensure that they compile correctly.
> Shouldn't be an concurrent sessions on this context.
>
> > Alex, are you able to edit the code and replace the File.renameTo call
> with an equivalent Files.move and see if it's either (a) more reliable
> or (b) gives you better error information?
>
> Yes I can give it a try.
>
> > One more idea. Virus scanner locking files?
>
> I've seen it on systems with and without a/v. On the system with it, I was
> able to temporarily disable it but still got on the tmp.rename error.
>
>
> On Mon, Jun 10, 2019 at 2:48 PM Mark Thomas  wrote:
>
>> On 10/06/2019 12:08, Alex O'Ree wrote:
>> > I am on windows 7. Same partition as the os.
>>
>> Hmm. That is odd. A few random (ish) questions:
>>
>> Anything unusual about that file system?
>>
>> How much load (users, req/s) is the system under?
>>
>> Any changes from default JSP Servlet (Jasper) settings?
>>
>> Does the access log indicate concurrent access for the problematic
>> resources?
>>
>> Mark
>>
>>
>> >
>> > On Mon, Jun 10, 2019, 3:20 AM Mark Thomas  wrote:
>> >
>> >> On 07/06/2019 15:35, Alex O'Ree wrote:
>> >>> HTTP Status 500 – Internal Server Error
>> >>> Type Exception Report
>> >>>
>> >>> Message Unable to compile class for JSP
>> >>>
>> >>> Description The server encountered an unexpected condition that
>> >>> prevented it from fulfilling the request.
>> >>
>> >> Not as helpful as I had hoped.
>> >>
>> >> Given that the issue is random and that immediately retrying usually
>> >> works that tends to rule out permission issues.
>> >>
>> >> Where is the work directory located? If it is anywhere other than local
>> >> disk that might be the source of the problem.
>> >>
>> >> I'll look into improving those error messages a little (at least
>> provide
>> >> source and destination file names).
>> >>
>> >> Mark
>> >>
>> >>
>> >>>
>> >>> Exception
>> >>>
>> >>> org.apache.jasper.JasperException: Unable to compile class for JSP
>> >>>
>> >>
>> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:610)
>> >>>
>> >>
>> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
>> >>>
>> >>
>> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
>> >>>
>>  org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
>> >>>   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
>> >>>
>> >>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>> >>>
>> >>
>> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
>> >>> Root Cause
>> >>>
>> >>> java.io.IOException: tmpFile.renameTo(classFile) failed
>> >>>
>> >>
>> org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:204)
>> >>>
>>  org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)
>> >>>
>> >>
>> org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:564)
>> >>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
>> >>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:350)
>> >>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:334)
>> >>>
>> >>
>> org.apache.jasper.JspCompilationContext.compile(

Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-10 Thread Alex O'Ree
> Anything unusual about that file system?

Nope, just a standard NTFS windows 7 setup. I've seen in a development
environment (no special file permissions) and in more of a production
environment on win10 and server 2016 whereby the file system is locked down
in a similar fashion to how it's done on linux.

> How much load (users, req/s) is the system under?

In terms of the jsp error, this particular app is typically just a single
user hitting it. There's lots of other non-jsp traffic to the server
though. I've also seen this error a lot in my dev setup.

> Any changes from default JSP Servlet (Jasper) settings?

none

> Does the access log indicate concurrent access for the problematic
resources?

Well. It's happening pretty frequently during a controlled set of selenium
unit tests. It's a single browser session doing http get's to all the jsp
pages one at a time, primarily just to ensure that they compile correctly.
Shouldn't be an concurrent sessions on this context.

> Alex, are you able to edit the code and replace the File.renameTo call
with an equivalent Files.move and see if it's either (a) more reliable
or (b) gives you better error information?

Yes I can give it a try.

> One more idea. Virus scanner locking files?

I've seen it on systems with and without a/v. On the system with it, I was
able to temporarily disable it but still got on the tmp.rename error.


On Mon, Jun 10, 2019 at 2:48 PM Mark Thomas  wrote:

> On 10/06/2019 12:08, Alex O'Ree wrote:
> > I am on windows 7. Same partition as the os.
>
> Hmm. That is odd. A few random (ish) questions:
>
> Anything unusual about that file system?
>
> How much load (users, req/s) is the system under?
>
> Any changes from default JSP Servlet (Jasper) settings?
>
> Does the access log indicate concurrent access for the problematic
> resources?
>
> Mark
>
>
> >
> > On Mon, Jun 10, 2019, 3:20 AM Mark Thomas  wrote:
> >
> >> On 07/06/2019 15:35, Alex O'Ree wrote:
> >>> HTTP Status 500 – Internal Server Error
> >>> Type Exception Report
> >>>
> >>> Message Unable to compile class for JSP
> >>>
> >>> Description The server encountered an unexpected condition that
> >>> prevented it from fulfilling the request.
> >>
> >> Not as helpful as I had hoped.
> >>
> >> Given that the issue is random and that immediately retrying usually
> >> works that tends to rule out permission issues.
> >>
> >> Where is the work directory located? If it is anywhere other than local
> >> disk that might be the source of the problem.
> >>
> >> I'll look into improving those error messages a little (at least provide
> >> source and destination file names).
> >>
> >> Mark
> >>
> >>
> >>>
> >>> Exception
> >>>
> >>> org.apache.jasper.JasperException: Unable to compile class for JSP
> >>>
> >>
> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:610)
> >>>
> >>
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
> >>>
> >>
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
> >>>   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
> >>>   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
> >>>
> >>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> >>>
> >>
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
> >>> Root Cause
> >>>
> >>> java.io.IOException: tmpFile.renameTo(classFile) failed
> >>>
> >>
> org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:204)
> >>>
>  org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)
> >>>
> >>
> org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:564)
> >>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
> >>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:350)
> >>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:334)
> >>>
> >>
> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:595)
> >>>
> >>
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
> >>>
> >>
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
> >>>   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
> >>>   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
> >>>
> >>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> >>>
> >>
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
> >>> Note The full stack trace of the root cause is available in the server
> >> logs.
> >>>
> >>>
> >>>
> >>>
> >>> On Fri, Jun 7, 2019 at 4:58 AM Mark Thomas  wrote:
> >>>
>  On 06/06/2019 20:38, Alex O'Ree wrote:
> > I've upgraded from .34 to .40 somewhat recently (on windows) and have
>  been
> > getting random errors rendering jsp pages recently. The trace is
> always
> > related to jasper failing to rename a file. I'm not really sure what

Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-10 Thread Mark Thomas
On 10/06/2019 19:45, Mark Thomas wrote:
> On 10/06/2019 12:08, Alex O'Ree wrote:
>> I am on windows 7. Same partition as the os.
> 
> Hmm. That is odd. A few random (ish) questions:
> 
> Anything unusual about that file system?
> 
> How much load (users, req/s) is the system under?
> 
> Any changes from default JSP Servlet (Jasper) settings?
> 
> Does the access log indicate concurrent access for the problematic
> resources?

One more idea. Virus scanner locking files?

Mark

> 
> Mark
> 
> 
>>
>> On Mon, Jun 10, 2019, 3:20 AM Mark Thomas  wrote:
>>
>>> On 07/06/2019 15:35, Alex O'Ree wrote:
 HTTP Status 500 – Internal Server Error
 Type Exception Report

 Message Unable to compile class for JSP

 Description The server encountered an unexpected condition that
 prevented it from fulfilling the request.
>>>
>>> Not as helpful as I had hoped.
>>>
>>> Given that the issue is random and that immediately retrying usually
>>> works that tends to rule out permission issues.
>>>
>>> Where is the work directory located? If it is anywhere other than local
>>> disk that might be the source of the problem.
>>>
>>> I'll look into improving those error messages a little (at least provide
>>> source and destination file names).
>>>
>>> Mark
>>>
>>>

 Exception

 org.apache.jasper.JasperException: Unable to compile class for JSP

>>>  
>>> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:610)

>>>  
>>> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)

>>>  org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)

>>>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)

>>>  
>>> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
 Root Cause

 java.io.IOException: tmpFile.renameTo(classFile) failed

>>>  org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:204)
   org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)

>>>  org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:564)
   org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
   org.apache.jasper.compiler.Compiler.compile(Compiler.java:350)
   org.apache.jasper.compiler.Compiler.compile(Compiler.java:334)

>>>  
>>> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:595)

>>>  
>>> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)

>>>  org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)

>>>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)

>>>  
>>> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
 Note The full stack trace of the root cause is available in the server
>>> logs.




 On Fri, Jun 7, 2019 at 4:58 AM Mark Thomas  wrote:

> On 06/06/2019 20:38, Alex O'Ree wrote:
>> I've upgraded from .34 to .40 somewhat recently (on windows) and have
> been
>> getting random errors rendering jsp pages recently. The trace is always
>> related to jasper failing to rename a file. I'm not really sure what
>>> the
>> issue is. Has anyone seen this or something similar?
>>
>> Usually retrying the request resolves the issue immediately but
>>> something
>> seems fishy. This worked fine on previous versions.
>
> Can you provide a stack trace please.
>
> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>
>

>>>
>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: users-h...@tomcat.apache.org
>>>
>>>
>>
> 
> 
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-10 Thread Mark Thomas
On 10/06/2019 12:08, Alex O'Ree wrote:
> I am on windows 7. Same partition as the os.

Hmm. That is odd. A few random (ish) questions:

Anything unusual about that file system?

How much load (users, req/s) is the system under?

Any changes from default JSP Servlet (Jasper) settings?

Does the access log indicate concurrent access for the problematic
resources?

Mark


> 
> On Mon, Jun 10, 2019, 3:20 AM Mark Thomas  wrote:
> 
>> On 07/06/2019 15:35, Alex O'Ree wrote:
>>> HTTP Status 500 – Internal Server Error
>>> Type Exception Report
>>>
>>> Message Unable to compile class for JSP
>>>
>>> Description The server encountered an unexpected condition that
>>> prevented it from fulfilling the request.
>>
>> Not as helpful as I had hoped.
>>
>> Given that the issue is random and that immediately retrying usually
>> works that tends to rule out permission issues.
>>
>> Where is the work directory located? If it is anywhere other than local
>> disk that might be the source of the problem.
>>
>> I'll look into improving those error messages a little (at least provide
>> source and destination file names).
>>
>> Mark
>>
>>
>>>
>>> Exception
>>>
>>> org.apache.jasper.JasperException: Unable to compile class for JSP
>>>
>>  
>> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:610)
>>>
>>  
>> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
>>>
>>  org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
>>>   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
>>>   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
>>>
>>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>>
>>  
>> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
>>> Root Cause
>>>
>>> java.io.IOException: tmpFile.renameTo(classFile) failed
>>>
>>  org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:204)
>>>   org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)
>>>
>>  org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:564)
>>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
>>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:350)
>>>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:334)
>>>
>>  
>> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:595)
>>>
>>  
>> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
>>>
>>  org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
>>>   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
>>>   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
>>>
>>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>>
>>  
>> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
>>> Note The full stack trace of the root cause is available in the server
>> logs.
>>>
>>>
>>>
>>>
>>> On Fri, Jun 7, 2019 at 4:58 AM Mark Thomas  wrote:
>>>
 On 06/06/2019 20:38, Alex O'Ree wrote:
> I've upgraded from .34 to .40 somewhat recently (on windows) and have
 been
> getting random errors rendering jsp pages recently. The trace is always
> related to jasper failing to rename a file. I'm not really sure what
>> the
> issue is. Has anyone seen this or something similar?
>
> Usually retrying the request resolves the issue immediately but
>> something
> seems fishy. This worked fine on previous versions.

 Can you provide a stack trace please.

 Thanks,

 Mark

 -
 To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: users-h...@tomcat.apache.org


>>>
>>
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: users-h...@tomcat.apache.org
>>
>>
> 


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-10 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 6/10/19 14:21, Alex O'Ree wrote:

> in tomcat/work/Catalina/localhost/(mywebapp)/org/apache/jsp/dir/ I
> have something like help_jsp.java help_jsp.classtmp
> 
> all other jsp pages have the pattern page_jsp.java page_jsp.class

Hmm. There are a lot of reports of File.rename() not being entirely
reliable on Windows, with very little explanation for exactly what is
going on deep down.

Just Google for "java windows file.renameto fails local drive" and
you'll get a lot of reports of complaints and some suggestions.

Alex, are you able to edit the code and replace the File.renameTo call
with an equivalent Files.move and see if it's either (a) more reliable
or (b) gives you better error information?

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlz+pRsACgkQHPApP6U8
pFiFTRAAnXct+uoehAKppdh58u9YTYV4UOCauM5nijGRGB4d77mO4bJ/xYOb00lO
9RcPyIkvOX+Njb8etoZBYlMGf3CC+aZTu8jeSFM5yonfcvU3v3WyWO2tPb0cr3S2
x2G7IXHrew0XPNInpBZJkhEYJR97/TPA0lUYyjAgpNIURicGjYYNxDoZ7SIocj/z
hbKrnTssBd7he9DDpWGVK9i1j+ACgsOY0Yi5FJeihnHhrkIynxDghx9VcdFj+8wo
LRFQWrPtOl2boO24McXLK3Ei1GzTQCYraA/hc1zB5QXeIZHeZip+8xSxGk766ndA
9VGluNbpRrk6eqCCsFnXD+DZ5EElE1rQG+wCzyIunI5VVBR6ynxa84SEkBu9jIaq
CNq+8vF+44+RBHrGi3cLijUXv0vL273Ld6pore2QG2ObRtL9+UTkmAV7q/zzcNsB
4iHWslgjGYc8AJczOoIlUue1tVvzuP9ZYEv38Z8tDuhkuG60F6u//dGTcIA53eWT
ChONsIWjxUmNT6WilLVZQXgtOW6TvB5r4UzZOjDsA1UXqZwZc1zT0VmRWzn5pScV
XdK9d+OM9RbmUCLpOY0oyNB1gqP5cnS9SgZrfQi7j7El+gXw8bzp6EPC88gwB8cK
9EQOiZzcKqLqUJfuGfMWXeiJRRSo9nEpX7GMc/OSOK8dARv9gbI=
=uzPP
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-10 Thread Alex O'Ree
in tomcat/work/Catalina/localhost/(mywebapp)/org/apache/jsp/dir/
I have something like
help_jsp.java
help_jsp.classtmp

all other jsp pages have the pattern
page_jsp.java
page_jsp.class


On Mon, Jun 10, 2019 at 11:53 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Alex,
>
> On 6/10/19 03:20, Mark Thomas wrote:
> > On 07/06/2019 15:35, Alex O'Ree wrote:
> >> HTTP Status 500 – Internal Server Error Type Exception Report
> >>
> >> Message Unable to compile class for JSP
> >>
> >> Description The server encountered an unexpected condition that
> >> prevented it from fulfilling the request.
> >
> > Not as helpful as I had hoped.
> >
> > Given that the issue is random and that immediately retrying
> > usually works that tends to rule out permission issues.
> >
> > Where is the work directory located? If it is anywhere other than
> > local disk that might be the source of the problem.
> >
> > I'll look into improving those error messages a little (at least
> > provide source and destination file names).
>
> After the error, what file(s) are on the disk in the work directory?
>
> - -chris
>
> >> org.apache.jasper.JasperException: Unable to compile class for
> >> JSP
> >> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext
> .java:610)
> >>
> >>
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.ja
> va:399)
> >> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:3
> 86)
> >>
> >>
> org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
> >> javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
> >> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52
> )
> >>
> >>
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFil
> ter.java:71)
> >> Root Cause
> >>
> >> java.io.IOException: tmpFile.renameTo(classFile) failed
> >> org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.jav
> a:204)
> >>
> >>
> org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)
> >> org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java
> :564)
> >>
> >>
> org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
> >> org.apache.jasper.compiler.Compiler.compile(Compiler.java:350)
> >> org.apache.jasper.compiler.Compiler.compile(Compiler.java:334)
> >> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext
> .java:595)
> >>
> >>
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.ja
> va:399)
> >> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:3
> 86)
> >>
> >>
> org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
> >> javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
> >> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52
> )
> >>
> >>
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFil
> ter.java:71)
> >> Note The full stack trace of the root cause is available in the
> >> server logs.
> >>
> >>
> >>
> >>
> >> On Fri, Jun 7, 2019 at 4:58 AM Mark Thomas 
> >> wrote:
> >>
> >>> On 06/06/2019 20:38, Alex O'Ree wrote:
>  I've upgraded from .34 to .40 somewhat recently (on windows)
>  and have
> >>> been
>  getting random errors rendering jsp pages recently. The trace
>  is always related to jasper failing to rename a file. I'm not
>  really sure what the issue is. Has anyone seen this or
>  something similar?
> 
>  Usually retrying the request resolves the issue immediately
>  but something seems fishy. This worked fine on previous
>  versions.
> >>>
> >>> Can you provide a stack trace please.
> >>>
> >>> Thanks,
> >>>
> >>> Mark
> >>>
> >>> 
> - -
> >>>
> >>>
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> >>> For additional commands, e-mail: users-h...@tomcat.apache.org
> >>>
> >>>
> >>
> >
> >
> > -
> >
> >
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: users-h...@tomcat.apache.org
> >
> -BEGIN PGP SIGNATURE-
> Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>
> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlz+fO0ACgkQHPApP6U8
> pFgypg/+JuAE3Zk6nQSnvu5k6ivkjMatT4uTKZccQ0Lpf20Dyfmum5ah7jWHFhcV
> 7WHSWYrvOQ0B/nkv97Aml8tg4VOH2fG3EgYzKqmJt6aoEye9E7zXQRBtlZs/IBGd
> baCWaJ4zbDRQkhizuCUsBixfcqCxZRqGL3MQ8BaIgkdx7+OJJIy6gNq1tNMRtlN3
> td+Ui3X7oMX84Ov3Q/YUvSEODjnSP56nkcGXpElPMHn7gQy1slHLIwAEd3NjtS5T
> 7FbsPiIX3ZfkpKolikRqzhBtzcdx5y0Jwd6pSMmKAKrtET0fQq24HIYBX8dRw0yG
> rsQ5iwYN1P3c5AIDpoqA+C22Fh+/ZNdTbpkMVrUp9hLJlGMO5i5NmhQq0/awVGdT
> oWbA1oga3z2F5ZREdASMyr1rdRNwKqeocUAvfbuzINvib63qJakar8NVL98sVRhi
> AR5DCKmi6yMm3v1+3oyJRkx27epsqc6EVXHR/k3qKy5NfqlbJBai2JLwjDPW41ou
> Rbp82wmxUGHGGmCdibW55k1DcMB7R84Ddgbl6Dm9tbQbF5saF8pFkpbhuySxENZa
> 3AObVfnKC7u/CP9

Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-10 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Alex,

On 6/10/19 03:20, Mark Thomas wrote:
> On 07/06/2019 15:35, Alex O'Ree wrote:
>> HTTP Status 500 – Internal Server Error Type Exception Report
>> 
>> Message Unable to compile class for JSP
>> 
>> Description The server encountered an unexpected condition that 
>> prevented it from fulfilling the request.
> 
> Not as helpful as I had hoped.
> 
> Given that the issue is random and that immediately retrying
> usually works that tends to rule out permission issues.
> 
> Where is the work directory located? If it is anywhere other than
> local disk that might be the source of the problem.
> 
> I'll look into improving those error messages a little (at least
> provide source and destination file names).

After the error, what file(s) are on the disk in the work directory?

- -chris

>> org.apache.jasper.JasperException: Unable to compile class for
>> JSP 
>> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext
.java:610)
>>
>> 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.ja
va:399)
>> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:3
86)
>>
>> 
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
>> javax.servlet.http.HttpServlet.service(HttpServlet.java:742) 
>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52
)
>>
>> 
org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFil
ter.java:71)
>> Root Cause
>> 
>> java.io.IOException: tmpFile.renameTo(classFile) failed 
>> org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.jav
a:204)
>>
>> 
org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)
>> org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java
:564)
>>
>> 
org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
>> org.apache.jasper.compiler.Compiler.compile(Compiler.java:350) 
>> org.apache.jasper.compiler.Compiler.compile(Compiler.java:334) 
>> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext
.java:595)
>>
>> 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.ja
va:399)
>> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:3
86)
>>
>> 
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
>> javax.servlet.http.HttpServlet.service(HttpServlet.java:742) 
>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52
)
>>
>> 
org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFil
ter.java:71)
>> Note The full stack trace of the root cause is available in the
>> server logs.
>> 
>> 
>> 
>> 
>> On Fri, Jun 7, 2019 at 4:58 AM Mark Thomas 
>> wrote:
>> 
>>> On 06/06/2019 20:38, Alex O'Ree wrote:
 I've upgraded from .34 to .40 somewhat recently (on windows)
 and have
>>> been
 getting random errors rendering jsp pages recently. The trace
 is always related to jasper failing to rename a file. I'm not
 really sure what the issue is. Has anyone seen this or
 something similar?
 
 Usually retrying the request resolves the issue immediately
 but something seems fishy. This worked fine on previous
 versions.
>>> 
>>> Can you provide a stack trace please.
>>> 
>>> Thanks,
>>> 
>>> Mark
>>> 
>>> 
- -
>>>
>>> 
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: users-h...@tomcat.apache.org
>>> 
>>> 
>> 
> 
> 
> -
>
> 
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
> 
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlz+fO0ACgkQHPApP6U8
pFgypg/+JuAE3Zk6nQSnvu5k6ivkjMatT4uTKZccQ0Lpf20Dyfmum5ah7jWHFhcV
7WHSWYrvOQ0B/nkv97Aml8tg4VOH2fG3EgYzKqmJt6aoEye9E7zXQRBtlZs/IBGd
baCWaJ4zbDRQkhizuCUsBixfcqCxZRqGL3MQ8BaIgkdx7+OJJIy6gNq1tNMRtlN3
td+Ui3X7oMX84Ov3Q/YUvSEODjnSP56nkcGXpElPMHn7gQy1slHLIwAEd3NjtS5T
7FbsPiIX3ZfkpKolikRqzhBtzcdx5y0Jwd6pSMmKAKrtET0fQq24HIYBX8dRw0yG
rsQ5iwYN1P3c5AIDpoqA+C22Fh+/ZNdTbpkMVrUp9hLJlGMO5i5NmhQq0/awVGdT
oWbA1oga3z2F5ZREdASMyr1rdRNwKqeocUAvfbuzINvib63qJakar8NVL98sVRhi
AR5DCKmi6yMm3v1+3oyJRkx27epsqc6EVXHR/k3qKy5NfqlbJBai2JLwjDPW41ou
Rbp82wmxUGHGGmCdibW55k1DcMB7R84Ddgbl6Dm9tbQbF5saF8pFkpbhuySxENZa
3AObVfnKC7u/CP9W/JfBeAegxHJTsazrQrvdAisI+DRVKgv1tpKzGSjTyWcLak2l
7sJe2sqvG2Yw6Vk2Q0Zb7HHpACOV4CaayztVpYqCpOoRz+WFM4E=
=jCGo
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-10 Thread Alex O'Ree
I am on windows 7. Same partition as the os.

On Mon, Jun 10, 2019, 3:20 AM Mark Thomas  wrote:

> On 07/06/2019 15:35, Alex O'Ree wrote:
> > HTTP Status 500 – Internal Server Error
> > Type Exception Report
> >
> > Message Unable to compile class for JSP
> >
> > Description The server encountered an unexpected condition that
> > prevented it from fulfilling the request.
>
> Not as helpful as I had hoped.
>
> Given that the issue is random and that immediately retrying usually
> works that tends to rule out permission issues.
>
> Where is the work directory located? If it is anywhere other than local
> disk that might be the source of the problem.
>
> I'll look into improving those error messages a little (at least provide
> source and destination file names).
>
> Mark
>
>
> >
> > Exception
> >
> > org.apache.jasper.JasperException: Unable to compile class for JSP
> >
>  
> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:610)
> >
>  
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
> >
>  org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
> >   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
> >   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
> >
>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> >
>  
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
> > Root Cause
> >
> > java.io.IOException: tmpFile.renameTo(classFile) failed
> >
>  org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:204)
> >   org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)
> >
>  org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:564)
> >   org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
> >   org.apache.jasper.compiler.Compiler.compile(Compiler.java:350)
> >   org.apache.jasper.compiler.Compiler.compile(Compiler.java:334)
> >
>  
> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:595)
> >
>  
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
> >
>  org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
> >   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
> >   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
> >
>  org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> >
>  
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
> > Note The full stack trace of the root cause is available in the server
> logs.
> >
> >
> >
> >
> > On Fri, Jun 7, 2019 at 4:58 AM Mark Thomas  wrote:
> >
> >> On 06/06/2019 20:38, Alex O'Ree wrote:
> >>> I've upgraded from .34 to .40 somewhat recently (on windows) and have
> >> been
> >>> getting random errors rendering jsp pages recently. The trace is always
> >>> related to jasper failing to rename a file. I'm not really sure what
> the
> >>> issue is. Has anyone seen this or something similar?
> >>>
> >>> Usually retrying the request resolves the issue immediately but
> something
> >>> seems fishy. This worked fine on previous versions.
> >>
> >> Can you provide a stack trace please.
> >>
> >> Thanks,
> >>
> >> Mark
> >>
> >> -
> >> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: users-h...@tomcat.apache.org
> >>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>
>


Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-10 Thread Mark Thomas
On 07/06/2019 15:35, Alex O'Ree wrote:
> HTTP Status 500 – Internal Server Error
> Type Exception Report
> 
> Message Unable to compile class for JSP
> 
> Description The server encountered an unexpected condition that
> prevented it from fulfilling the request.

Not as helpful as I had hoped.

Given that the issue is random and that immediately retrying usually
works that tends to rule out permission issues.

Where is the work directory located? If it is anywhere other than local
disk that might be the source of the problem.

I'll look into improving those error messages a little (at least provide
source and destination file names).

Mark


> 
> Exception
> 
> org.apache.jasper.JasperException: Unable to compile class for JSP
>   
> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:610)
>   
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
>   org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
>   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
>   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
>   org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
> Root Cause
> 
> java.io.IOException: tmpFile.renameTo(classFile) failed
>   
> org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:204)
>   org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)
>   
> org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:564)
>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:350)
>   org.apache.jasper.compiler.Compiler.compile(Compiler.java:334)
>   
> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:595)
>   
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
>   org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
>   org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
>   javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
>   org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
> Note The full stack trace of the root cause is available in the server logs.
> 
> 
> 
> 
> On Fri, Jun 7, 2019 at 4:58 AM Mark Thomas  wrote:
> 
>> On 06/06/2019 20:38, Alex O'Ree wrote:
>>> I've upgraded from .34 to .40 somewhat recently (on windows) and have
>> been
>>> getting random errors rendering jsp pages recently. The trace is always
>>> related to jasper failing to rename a file. I'm not really sure what the
>>> issue is. Has anyone seen this or something similar?
>>>
>>> Usually retrying the request resolves the issue immediately but something
>>> seems fishy. This worked fine on previous versions.
>>
>> Can you provide a stack trace please.
>>
>> Thanks,
>>
>> Mark
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: users-h...@tomcat.apache.org
>>
>>
> 


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-07 Thread Alex O'Ree
HTTP Status 500 – Internal Server Error
Type Exception Report

Message Unable to compile class for JSP

Description The server encountered an unexpected condition that
prevented it from fulfilling the request.

Exception

org.apache.jasper.JasperException: Unable to compile class for JSP

org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:610)

org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)

org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
Root Cause

java.io.IOException: tmpFile.renameTo(classFile) failed

org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:204)
org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163)

org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:564)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:378)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:350)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:334)

org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:595)

org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:399)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:330)
javax.servlet.http.HttpServlet.service(HttpServlet.java:742)
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)

org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
Note The full stack trace of the root cause is available in the server logs.




On Fri, Jun 7, 2019 at 4:58 AM Mark Thomas  wrote:

> On 06/06/2019 20:38, Alex O'Ree wrote:
> > I've upgraded from .34 to .40 somewhat recently (on windows) and have
> been
> > getting random errors rendering jsp pages recently. The trace is always
> > related to jasper failing to rename a file. I'm not really sure what the
> > issue is. Has anyone seen this or something similar?
> >
> > Usually retrying the request resolves the issue immediately but something
> > seems fishy. This worked fine on previous versions.
>
> Can you provide a stack trace please.
>
> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>
>


Re: on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-07 Thread Mark Thomas
On 06/06/2019 20:38, Alex O'Ree wrote:
> I've upgraded from .34 to .40 somewhat recently (on windows) and have been
> getting random errors rendering jsp pages recently. The trace is always
> related to jasper failing to rename a file. I'm not really sure what the
> issue is. Has anyone seen this or something similar?
> 
> Usually retrying the request resolves the issue immediately but something
> seems fishy. This worked fine on previous versions.

Can you provide a stack trace please.

Thanks,

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



on 8.5.40, random tmpFile.renameTo with jsp files

2019-06-06 Thread Alex O'Ree
I've upgraded from .34 to .40 somewhat recently (on windows) and have been
getting random errors rendering jsp pages recently. The trace is always
related to jasper failing to rename a file. I'm not really sure what the
issue is. Has anyone seen this or something similar?

Usually retrying the request resolves the issue immediately but something
seems fishy. This worked fine on previous versions.