Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-26 Thread Chris Cheshire
On Thu, Oct 26, 2017 at 3:00 PM, Christopher Schultz wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Chris, > > On 10/16/17 9:43 AM, Chris Cheshire wrote: >> On Fri, Oct 13, 2017 at 5:00 PM, Christopher Schultz >> wrote:

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chris and Keiichi, On 10/17/17 5:31 PM, Chris Cheshire wrote: > On Tue, Oct 17, 2017 at 3:44 AM, Keiichi Fujino > wrote: >> Hi >> >> You have set >> factory="org.apache.tomcat.jdbc.pool.DataSourceFactory". In other >> words,

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chris, On 10/16/17 9:43 AM, Chris Cheshire wrote: > On Fri, Oct 13, 2017 at 5:00 PM, Christopher Schultz > wrote: >> -BEGIN PGP SIGNED MESSAGE- > >> When you say you have "autocommit disabled in mysql

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-17 Thread Chris Cheshire
On Tue, Oct 17, 2017 at 3:44 AM, Keiichi Fujino wrote: > Hi > > You have set factory="org.apache.tomcat.jdbc.pool.DataSourceFactory". > In other words, you do not use (tomcat)DBCP, you are using Tomcat jdbc-pool. That's what I meant sorry. Was comparing to commons-dbcp and

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-17 Thread Keiichi Fujino
Hi You have set factory="org.apache.tomcat.jdbc.pool.DataSourceFactory". In other words, you do not use (tomcat)DBCP, you are using Tomcat jdbc-pool. In DBCP, the default of rollbackOnReturn attribute is true. However, in Tomcat jdbc-pool, the default of rollbackOnReturn( and commitOnReturn )

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-16 Thread Chris Cheshire
On Fri, Oct 13, 2017 at 5:00 PM, Christopher Schultz wrote: > -BEGIN PGP SIGNED MESSAGE- > When you say you have "autocommit disabled in mysql config" what do > you mean? > /etc/my.cnf : [mysqld] autocommit=0 This turns off autocommit off as a default for

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chris, Sorry, I had the autocommit true/false values mixed up in my mind. When you say you have "autocommit disabled in mysql config" what do you mean? On 10/13/17 10:17 AM, Chris Cheshire wrote: > > > As a further test I just took out my

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-13 Thread Chris Cheshire
As a further test I just took out my explicit rollback in my DAOFactory close() method, and swapped back to commons dbcp. Added an update that wasn't explicitly committed, and it correctly did not get committed when the connection was closed. Swapped back to tomcat dbcp and repeated, it got

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-13 Thread Chris Cheshire
On Thu, Oct 12, 2017 at 11:16 PM, Christopher Schultz wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Chris, > > On 10/11/17 5:21 PM, Chris Cheshire wrote: >> Working on a migration from 7 to 8.5, and in it I am now using the >> tomcat dbcp, instead

Re: tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chris, On 10/11/17 5:21 PM, Chris Cheshire wrote: > Working on a migration from 7 to 8.5, and in it I am now using the > tomcat dbcp, instead of apache commons dbcp.> I have found that > with no other changes to the db code (except the factory

tomcat 8.5.23 dbcp not honoring autocommit = false?

2017-10-11 Thread Chris Cheshire
Working on a migration from 7 to 8.5, and in it I am now using the tomcat dbcp, instead of apache commons dbcp. I have found that with no other changes to the db code (except the factory param for the resource), it is working fine other than there is an implicit commit happening when I close a