Re: NumberFormatException from Requests with invalid URIs

2013-07-25 Thread Sven Meier
ServletWebRequest#getContextRelativeUrl() passes foo://:/ to Url#parse() and that one fails. Please create a Jira issue. Sven On 07/24/2013 05:06 PM, Martin Funk wrote: Hi Sven, we still can reproduce this on any version. Maybe this git diff gives a clearer picture: diff --git

Re: NumberFormatException from Requests with invalid URIs

2013-07-25 Thread Martin Funk
done https://issues.apache.org/jira/browse/WICKET-5287 2013/7/25 Sven Meier s...@meiers.net ServletWebRequest#**getContextRelativeUrl() passes foo://:/ to Url#parse() and that one fails. Please create a Jira issue. Sven On 07/24/2013 05:06 PM, Martin Funk wrote: Hi Sven, we still

NumberFormatException from Requests with invalid URIs

2013-07-24 Thread Mathias Binder
Hi, we became aware of a problem caused by requests with invalid URIs on our wicket-application. The URI contains strings like *://*:*, so wicket tries to determine and parse a port number, that is not present. This leads to NumberFormatExceptions with URIs like, e.g. http://host/h@@p://h@@p://

Re: NumberFormatException from Requests with invalid URIs

2013-07-24 Thread Sven Meier
Hi, which Wicket version? Url parsing has been improved on lately: @Test public void weirdUrl() { Url url = Url.parse(http://wicket.apache.org/h@@p://h@@p://;); assertEquals(wicket.apache.org, url.getHost()); assertEquals(/h@@p://h@@p://, url.getPath());

Re: NumberFormatException from Requests with invalid URIs

2013-07-24 Thread Mathias Binder
We work with Version 6.7.0 Mathias 2013/7/24 Sven Meier s...@meiers.net: Hi, which Wicket version? Url parsing has been improved on lately: @Test public void weirdUrl() { Url url = Url.parse(http://wicket.apache.org/h@@p://h@@p://;);

Re: NumberFormatException from Requests with invalid URIs

2013-07-24 Thread Martin Funk
Hi Sven, we still can reproduce this on any version. Maybe this git diff gives a clearer picture: diff --git a/wicket-core/src/test/java/org/apache/wicket/protocol/http/servlet/ServletWebRequestTest.java