Re: Potential Bug in DefaultNestedTree. Reproducible in Wicket examples

2017-12-21 Thread Martin Grigorov
Hi Conny, Actually the javadoc is already there - see IComponentInheritedModels's javadoc. We cannot copy/paste it at each and every component implementation. It is something specific to this IModel impl, not the components.

Re: Potential Bug in DefaultNestedTree. Reproducible in Wicket examples

2017-12-19 Thread Ernesto Reinaldo Barreiro
Hi Conny, If you create a PR with Java doc improvements I'm sure committers will be happy to merge it :-) On Wed, Dec 20, 2017 at 8:24 AM, Conny Kühne wrote: > Hi Sven, > > thanks. Maybe the javadoc of the tree classes should state this. It is not > obvious, e.g., why

Re: Potential Bug in DefaultNestedTree. Reproducible in Wicket examples

2017-12-19 Thread Sven Meier
Hi, the tree implementation does what many other Wicket component do too: If you don't provide a model, it tries to find one in one of its parental components. (Note that the tree uses the model to store the expanded nodes.) Since you have a CompoundPropertyModel in the page, it will create

Potential Bug in DefaultNestedTree. Reproducible in Wicket examples

2017-12-19 Thread Conny Kühne
Hi, don't know whether this is a bug so I'll ask here first. In the wicket tree examples, when I get a WicketRuntimeException in the org.apache.wicket.examples.tree.BeginnersTreePage when I set a model to the page as follows: public BeginnersTreePage() { setDefaultModel(new