Re: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread Martin Grigorov
Indeed the code looks strange. I'll improve it now. On Tue, Oct 19, 2010 at 5:46 PM, richard emberson < richard.ember...@gmail.com> wrote: > > > I am simply in the process of looking into Wicket; reading one > of the Wicket books, lurking on the mailing list and reviewing > the code and comments.

Re: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread richard emberson
I am simply in the process of looking into Wicket; reading one of the Wicket books, lurking on the mailing list and reviewing the code and comments. I have not yet determined at what level I might become involved with Java Wicket. The code in this particular message thread I did not grok, so I a

Re: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread Martin Grigorov
On Tue, Oct 19, 2010 at 4:40 PM, richard emberson < richard.ember...@gmail.com> wrote: > I've submitted such items to the dev list and got no reply. > Hm, I don't remember seeing this in d...@. But I don't remember many other things too :-) > At least here some knowledgeable "user" may look at th

Re: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread richard emberson
I've submitted such items to the dev list and got no reply. At least here some knowledgeable "user" may look at the code and provide feedback. On 10/19/2010 07:30 AM, John Owen wrote: Shouldn't this be on the dev mailing list instead? -Original Message- From: richard emberson [mailto:ri

RE: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread John Owen
Shouldn't this be on the dev mailing list instead? -Original Message- From: richard emberson [mailto:richard.ember...@gmail.com] Sent: Monday, October 18, 2010 8:50 PM To: users@wicket.apache.org Subject: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData org.apac