Re: StringResouceModel Can't find key with BootstrapCheckbox

2017-06-01 Thread Ernesto Reinaldo Barreiro
https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/677/files On Fri, Jun 2, 2017 at 6:12 AM, Ernesto Reinaldo Barreiro < reier...@gmail.com> wrote: > Ok. I will do it now :-) > > On Thu, Jun 1, 2017 at 9:36 PM, Martin Grigorov > wrote: > >> Hi Ernesto, >> >> Yes, I agree this class could be sim

Re: StringResouceModel Can't find key with BootstrapCheckbox

2017-06-01 Thread Ernesto Reinaldo Barreiro
Ok. I will do it now :-) On Thu, Jun 1, 2017 at 9:36 PM, Martin Grigorov wrote: > Hi Ernesto, > > Yes, I agree this class could be simplified! > PR is welcome! Otherwise I'll do it soon! > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Thu, Jun 1, 2017

Re: StringResouceModel Can't find key with BootstrapCheckbox

2017-06-01 Thread Martin Grigorov
Hi Ernesto, Yes, I agree this class could be simplified! PR is welcome! Otherwise I'll do it soon! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Jun 1, 2017 at 9:56 AM, Ernesto Reinaldo Barreiro < reier...@gmail.com> wrote: > Nice... I just debugged it...

Re: StringResouceModel Can't find key with BootstrapCheckbox

2017-06-01 Thread Ernesto Reinaldo Barreiro
Nice... I just debugged it... and was about to create a patch... @Martin,. I think component might not need to keep a copy of labelModel because it is passed to label... and Label will detach it and onConfigure of Lable could be wrriten in term of getDfaultModel()? On Wed, May 31, 2017 at 10:12

Re: StringResouceModel Can't find key with BootstrapCheckbox

2017-05-31 Thread Martin Grigorov
Fixed with https://github.com/l0rdn1kk0n/wicket-bootstrap/commit/25c75f84cf932dff7730c030d02b5469a26aab28 Thanks, Ernesto! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sun, May 28, 2017 at 6:04 PM, David Beer wrote: > Hi Ernesto > > Unfortunately I can't see

Re: StringResouceModel Can't find key with BootstrapCheckbox

2017-05-25 Thread Ernesto Reinaldo Barreiro
I think StringResourceModel is a IComponentAssignedModel and [image: Inline image 1] and [image: Inline image 2] So maybe the line this.label = labelModel should be replaced by this.label = wrap(labelModel) for this to work? Thought Label tag should already be doing that. Can you create a q

StringResouceModel Can't find key with BootstrapCheckbox

2017-05-25 Thread David Beer
Hi I am using the BootstrapCheckbox and when I try to add the Label using StringReosrceModel if fails to find the key in the properties file for the page it is on. However when I use Model.of() it works. BootstrapCheckbox addMoreUsersCheckbox = new BootstrapCheckbox("checkbox-add-more-users", ad