Re: Wicket adds jsessionid to redirect onto external page

2010-08-06 Thread MZemeck
respond to users@wicket.apache.org To users@wicket.apache.org cc Subject Re: Wicket adds jsessionid to redirect onto external page Cool ;) 2010/8/4 Don Ferguson don.fergu...@gmail.com: Right, it's really a jetty bug, and looks like it was fixed recently: http://dev.eclipse.org/mhonarc/lists

Re: Wicket adds jsessionid to redirect onto external page

2010-08-06 Thread Martin Makundi
Makundi martin.maku...@koodaripalvelut.com 08/04/2010 02:21 PM Please respond to users@wicket.apache.org To users@wicket.apache.org cc Subject Re: Wicket adds jsessionid to redirect onto external page Cool ;) 2010/8/4 Don Ferguson don.fergu...@gmail.com: Right, it's really a jetty bug

Re: Wicket adds jsessionid to redirect onto external page

2010-08-06 Thread MZemeck
; Martin Makundi martin.maku...@koodaripalvelut.com 08/06/2010 11:32 AM Please respond to users@wicket.apache.org To users@wicket.apache.org cc Subject Re: Wicket adds jsessionid to redirect onto external page Hi! And the Wicket SEO wiki provides a way to remove the JSessionId

Re: Wicket adds jsessionid to redirect onto external page

2010-08-06 Thread Martin Makundi
as described before. ** Martin Martin Makundi martin.maku...@koodaripalvelut.com 08/04/2010 02:21 PM Please respond to users@wicket.apache.org To users@wicket.apache.org cc Subject Re: Wicket adds jsessionid to redirect onto external page Cool ;) 2010/8/4 Don Ferguson

Re: Wicket adds jsessionid to redirect onto external page

2010-08-06 Thread MZemeck
@wicket.apache.org cc Subject Re: Wicket adds jsessionid to redirect onto external page Hi! And the Wicket SEO wiki provides a way to remove the JSessionId... https://cwiki.apache.org/WICKET/seo-search-engine-optimization.html This particular code does not work for first browser hit. I

Re: Wicket adds jsessionid to redirect onto external page

2010-08-06 Thread James Carman
On Fri, Aug 6, 2010 at 1:06 PM, mzem...@osc.state.ny.us wrote: Right, I guess that's my question, what are you losing by not calling super.encodeURL(url), but it may not matter because its only omitted for bots in the SEO example You're losing session support for folks who have said they

Re: Wicket adds jsessionid to redirect onto external page

2010-08-06 Thread Martin Makundi
You don't lose for all fols if you check whether it is a bot or not... but the question remains.. what else do you strip by skipping super.encodeUrl except just jsessionid.. some other encoding happening there? ** Martin 2010/8/6 James Carman ja...@carmanconsulting.com: On Fri, Aug 6, 2010 at

Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Martin Makundi
Hi! I am doing something wrong? I am using: getResponse().redirect(getParameterFromRequest(RETURN_PAGE)); But the URL contains jsessionid. I think this is wrong because the target server does not understand the jsessiond and it returns 404 page not found. ** Martin

Re: Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Don Ferguson
Hi Martin,Yes, I've encountered this. I think it's a bug in WebResponse. The culprit is the line: url = httpServletResponse.encodeRedirectURL(url);The url should only be encoded when redirecting to the originating site, but the code doesn't check.One workaround (short of fixing the bug) is to

Re: Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Martin Makundi
Hi! I worked around like this: ((org.mortbay.jetty.Request) ((WebRequest) RequestCycle.get().getRequest()).getHttpServletRequest()).setSessionManager(null); ** Martin 2010/8/4 Don Ferguson don.fergu...@gmail.com: Hi Martin, Yes, I've encountered this.  I think it's a bug in WebResponse.

Re: Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Don Ferguson
Ah, much better than my approach. On Aug 4, 2010, at 8:25 AM, Martin Makundi wrote: Hi! I worked around like this: ((org.mortbay.jetty.Request) ((WebRequest) RequestCycle.get().getRequest()).getHttpServletRequest()).setSessionManager(null); ** Martin 2010/8/4 Don Ferguson

Re: Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Martin Makundi
Like a sledgehammer ;) But yes, so it's a bug in wicket framework design. ** Martin 2010/8/4 Don Ferguson don.fergu...@gmail.com: Ah, much better than my approach. On Aug 4, 2010, at 8:25 AM, Martin Makundi wrote: Hi! I worked around like this:    ((org.mortbay.jetty.Request)

Re: Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Igor Vaynberg
afair the servlet spec says all urls have to be passed through that method and thats what we do. if its not working the problem is with the servlet container. -igor On Wed, Aug 4, 2010 at 10:39 AM, Martin Makundi martin.maku...@koodaripalvelut.com wrote: Like a sledgehammer ;) But yes, so

Re: Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Martin Makundi
Maybe we ned yet another overrideable encodeURLAccordingToServletSpec method. ** Martin 2010/8/4 Igor Vaynberg igor.vaynb...@gmail.com: afair the servlet spec says all urls have to be passed through that method and thats what we do. if its not working the problem is with the servlet

Re: Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Don Ferguson
Right, it's really a jetty bug, and looks like it was fixed recently: http://dev.eclipse.org/mhonarc/lists/jetty-commit/msg01598.html On Aug 4, 2010, at 10:46 AM, Igor Vaynberg wrote: afair the servlet spec says all urls have to be passed through that method and thats what we do. if its not

Re: Wicket adds jsessionid to redirect onto external page

2010-08-04 Thread Martin Makundi
Cool ;) 2010/8/4 Don Ferguson don.fergu...@gmail.com: Right, it's really a jetty bug, and looks like it was fixed recently: http://dev.eclipse.org/mhonarc/lists/jetty-commit/msg01598.html On Aug 4, 2010, at 10:46 AM, Igor Vaynberg wrote: afair the servlet spec says all urls have to be