RE: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread John Owen
Shouldn't this be on the dev mailing list instead? -Original Message- From: richard emberson [mailto:richard.ember...@gmail.com] Sent: Monday, October 18, 2010 8:50 PM To: users@wicket.apache.org Subject: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

Re: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread richard emberson
[mailto:richard.ember...@gmail.com] Sent: Monday, October 18, 2010 8:50 PM To: users@wicket.apache.org Subject: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData org.apache.wicket.pageStore.AsynchronousDataStore.removeData A little code review please

Re: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread Martin Grigorov
[mailto:richard.ember...@gmail.com] Sent: Monday, October 18, 2010 8:50 PM To: users@wicket.apache.org Subject: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData org.apache.wicket.pageStore.AsynchronousDataStore.removeData A little code review please

Re: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread richard emberson
mailing list instead? -Original Message- From: richard emberson [mailto:richard.ember...@gmail.com] Sent: Monday, October 18, 2010 8:50 PM To: users@wicket.apache.org Subject: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

Re: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-19 Thread Martin Grigorov
:50 PM To: users@wicket.apache.org Subject: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData org.apache.wicket.pageStore.AsynchronousDataStore.removeData A little code review please: In org.apache.wicket.pageStore.AsynchronousDataStore public void removeData

code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData

2010-10-18 Thread richard emberson
org.apache.wicket.pageStore.AsynchronousDataStore.removeData A little code review please: In org.apache.wicket.pageStore.AsynchronousDataStore public void removeData(final String sessionId, final int id) { synchronized (WRITE_LOCK) { String key =