Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-27 Thread Ian MacLarty
BTW I've logged bug 2438. On Thu, Aug 27, 2009 at 5:01 PM, Ian MacLarty wrote: > I tried the fix to populateItem proposed by the original bug reporter > (http://issues.apache.org/jira/browse/WICKET-2384) and that seems to > work. > > On Thu, Aug 27, 2009 at 4:32 PM, Igor Vaynberg wrote: >> well, i

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-27 Thread Ian MacLarty
I tried the fix to populateItem proposed by the original bug reporter (http://issues.apache.org/jira/browse/WICKET-2384) and that seems to work. On Thu, Aug 27, 2009 at 4:32 PM, Igor Vaynberg wrote: > well, its either removing components or an outofmemoryexception. which > one do you prefer? :) >

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Igor Vaynberg
well, its either removing components or an outofmemoryexception. which one do you prefer? :) we need to find another way to fix the OOME. can you see one? -igor On Wed, Aug 26, 2009 at 10:48 PM, Ian MacLarty wrote: > Here is an example of some less trivial behaviour that is done when > you click

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Ian MacLarty
Here is an example of some less trivial behaviour that is done when you click an error. This changes to a specific tab that contains the erroneous field. The error message that has this behaviour is added with some custom validation. @Override protected vo

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Igor Vaynberg
it doesnt really look like you need a callback, you can simply represent the link as a webmarkupcontainer that adds an onclick javascript. more efficient and does the same thing. -igor On Wed, Aug 26, 2009 at 10:11 PM, Ian MacLarty wrote: > It depends on the error.  Most of the time the onclick b

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Ian MacLarty
It depends on the error. Most of the time the onclick behaviour simply returns some javascript that highlights the invalid field. Sometimes it changes the current tab, because the invalid field is on a different tab. The code looks like this: add(new AjaxEventBehavior("onclick") {

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Igor Vaynberg
what do these links do? -igor On Wed, Aug 26, 2009 at 9:51 PM, Ian MacLarty wrote: > Hi Igor, > > The commit log is simply: > > Issue: WICKET-2384. > > > From http://issues.apache.org/jira/browse/WICKET-2384: > > Problem is that we keep reference to FeedbackMessage in component > inside MessageLi

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Ian MacLarty
Hi Igor, The commit log is simply: Issue: WICKET-2384. >From http://issues.apache.org/jira/browse/WICKET-2384: Problem is that we keep reference to FeedbackMessage in component inside MessageListView item. The feedback message references previous page - that causes the problem, because the pre

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Igor Vaynberg
before you file a bug report, what was the commit log for that svn change you found? -igor On Wed, Aug 26, 2009 at 9:42 PM, Ian MacLarty wrote: > On Thu, Aug 27, 2009 at 2:09 PM, Ian MacLarty wrote: >> On Thu, Aug 27, 2009 at 1:41 PM, Ian MacLarty wrote: >>> Hi, >>> >>> I recently upgraded to Wic

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Ian MacLarty
On Thu, Aug 27, 2009 at 2:09 PM, Ian MacLarty wrote: > On Thu, Aug 27, 2009 at 1:41 PM, Ian MacLarty wrote: >> Hi, >> >> I recently upgraded to Wicket 1.4 and am now having a problem with a >> feedback panel. >> >> I have a custom feedback panel that uses custom message components (by >> overriding

Re: onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Ian MacLarty
On Thu, Aug 27, 2009 at 1:41 PM, Ian MacLarty wrote: > Hi, > > I recently upgraded to Wicket 1.4 and am now having a problem with a > feedback panel. > > I have a custom feedback panel that uses custom message components (by > overriding FeedbackPanel#newMessageDisplayComponent).  The custom > mess

onclick AjaxEventBehaviour on feedback messages broken in 1.4?

2009-08-26 Thread Ian MacLarty
Hi, I recently upgraded to Wicket 1.4 and am now having a problem with a feedback panel. I have a custom feedback panel that uses custom message components (by overriding FeedbackPanel#newMessageDisplayComponent). The custom messages have an AjaxEventBehavior on the "onclick" event. This highli