Re: DataTable's FilterToolbar generics broken

2014-04-28 Thread Paul Bors
I think you're confused.

If you want to filter a collection based on type T, then your filter your
extend T.
The idea here is that your model object type for the filter is the same as
that retrieved by the data provider.
As such you can have a POJO of the same type T on which you apply the
filtering.

Otherwise what would you filter the collection based on?
There will be no standard, will there?

~ Thank you,
   Paul Bors


On Sat, Apr 26, 2014 at 9:39 AM, Leszek Gawron  wrote:

> I started migrating my code from wicket 1.4.19 to 6. Finally ! :)
>
> I found a FilterToolbar bug:
>
> Once you were able to create DataTable wrapped inside of
> FilterForm
>
> currently FilterToolbar requires you for those two types to be identical:
>
> public  FilterToolbar(final DataTable table, final
> FilterForm form,
> final IFilterStateLocator stateLocator)
>
> It looks like commit 9b3f9ca1df064fe9c6fde64ccc37fecc504b09a6
> introduced a bug long time ago and it carried on:
>
> -   public  FilterToolbar(final DataTable table, final
> FilterForm form,
> +   public  FilterToolbar(final DataTable table, final
> FilterForm form,
>
>
> FilterToolbar constructor should state:
>
> public  FilterToolbar(final DataTable table, final
> FilterForm form,
> final IFilterStateLocator stateLocator)
>
>
> cheers.
>
> --
> Leszek Gawron
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>


Re: [ANNOUNCE] Apache Wicket 6.15.0 is released

2014-04-28 Thread chorleyboy
That's true although, it does that through the Component api. I don't suppose
you could cast the IWizard to a Component :) No, I didn't think so.

Thanks for the prompt input. I'll try and get rid of this legacy code.

cheers.
-m.

--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/ANNOUNCE-Apache-Wicket-6-15-0-is-released-tp4665591p4665610.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: [ANNOUNCE] Apache Wicket 6.15.0 is released

2014-04-28 Thread Sven Meier

Hi,

AjaxWizardButtonBar holds a Wizard to update it on Ajax requests, an 
IWizard would not suffice.


Regards
Sven

On 04/28/2014 08:10 AM, mesketh wrote:

The latest release 6.15.0 includes an improvement
(https://issues.apache.org/jira/browse/WICKET-2542) delivering a new
ajaxified AjaxWizardButtonBar.

I noticed that the only/default constructor uses the concrete
org.apache.wicket.extensions.wizard.Wizard type and not
org.apache.wicket.extensions.wizard.IWizard as is found in the parent class
(WizardButtonBar).

I realise there’s only one implementation of Wizard in the core of Wicket
but, I’m dealing with legacy code that decided to copy the original Wizard
into its own implementation which retains the IWizard contract but,
of course now isn’t this strict Wizard type. All the button implementations
focus around IWizard as well.

I know, I know, fix your legacy code to not do that but, I think it’s worth
mentioning anyway this just for the sake of consistency with the parent
class in the use of IWizard.

cheers
-m.


--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/ANNOUNCE-Apache-Wicket-6-15-0-is-released-tp4665591p4665606.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org




-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Feedback panel title area

2014-04-28 Thread Jesse Long

On 25/04/2014 18:30, Entropy wrote:

I just tried putting some text inside the feedback panel's html like so:

This is a
test

That didn't work.  "This is a test" was overwritten when the feedback panel
rendered.  Which is exactly what I expected it to do.



Hi,

The text between the tags is called the body. When a Panel is rendered, 
the body of the tags to which the panel was bound ("This is a test" in 
your example) is ignored, and the associated markup is rendered instead. 
Associated markup is the markup provided by the Panel, that is shipped 
in an HTML file with the same name as the Panel's class, or super class.


There is nothing preventing you from subclassing FeedbackPanel, and 
providing very similar associated markup, just including a wicket:id="myheading">.


To override the associated markup provided by a Panel's parent (replace 
markup instead of extend it), you do this:



here you must provide all the markup required by the Panel.


ie. Use  instead of .

So, to get what you want, create a subclass of FeedbackPanel, called 
MyFeedbackPanel. Then, in MyFeedbackPanel.html, copy all the HTML from 
FeedbackPanel.html, and insert the label that you want to add. Then, in 
MyFeedbackPanel#onInitialize(), add the label as you normally would.


Cheers,
Jesse

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org