Re: What else do we want to do before 8.0.0 final ?

2016-11-19 Thread Martin Grigorov
Replace CGLIB with ByteBuddy because it has better support for Java 8 and 9
?
CGLIB could stay as fallback (via system property) until 9.0.0.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Fri, Nov 18, 2016 at 12:49 PM, Andrea Del Bene 
wrote:

> yah, I think it's better
>
>
>
> On 14/11/2016 19:54, Martin Grigorov wrote:
>
>> +1
>>
>> Maybe rename #forResource() to #of() ?
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Fri, Nov 11, 2016 at 5:00 PM, Andrea Del Bene 
>> wrote:
>>
>> I'm wondering if there is room for an improvement for ResourceReference,
>>> introducing lambda support also for this component. Actually it's
>>> something
>>> that can be done after the release of 8.0.0, but I'd like to collect your
>>> feedback anyway. The idea is to provide factory methods to build a
>>> ResourceReference using lambdas and avoiding anonymous classes to
>>> implement
>>> getResource().
>>> The following snippet should better explain what I mean:
>>>
>>> https://gist.github.com/bitstorm/03cfe9905a3f86a7160ab49f0ce23f13
>>>
>>> Andrea.
>>>
>>> On 31/10/2016 14:41, Martin Grigorov wrote:
>>>
>>> Hi,

 What other improvements do we need in 8.x/master before promoting it to
 8.0.0 final ?

 At https://cwiki.apache.org/confluence/display/WICKET/Ideas+
 for+Wicket+8.0
 we still have:

 - new DateTime APIs for wicket-datetime *WICKET-6105
 * - I'll give this
 one
 more try but the problem is that I don't believe this is the proper way
 and
 this demotivates me.
 If someone else wants to give it a try - please assign it to yourself!

 - Better SEO for stateful pages - the only way I see this is by using
 ServiceWorker to add the pageId as a request header to all requests
 (normal
 & Ajax)


 Recently I wondered whether Redux.js could be in use for Wicket.
 I don't have much experience with it, but both React and AngularJs
 communities use it to manage the state for their components.
 There are some Java impls, even a standard is coming:
 https://github.com/jvm-redux/jvm-redux-api

 What else ?

 Martin Grigorov
 Wicket Training and Consulting
 https://twitter.com/mtgrigorov



>


Re: WebSocket ConnectedMessage not Serializable

2016-11-19 Thread Peter Henderson
Ha! You've already fixed it.
Ignore my pull request. (I spent too much time getting my scala -> java
code compiling)

Thanks

Peter.


Re: WebSocket ConnectedMessage not Serializable

2016-11-19 Thread Martin Grigorov
https://issues.apache.org/jira/browse/WICKET-6282

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sat, Nov 19, 2016 at 4:41 PM, Martin Grigorov 
wrote:

> Hi Peter,
>
> I don't see a problem to make all msgs serializable.
> Please create a ticket!
> With a Pull Request/Patch would be awesome!
> Thank you!
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Sat, Nov 19, 2016 at 3:46 PM, Peter Henderson <
> peter.hender...@starjar.com> wrote:
>
>> Hi all.
>>
>> Wicket 7.3.0
>> Native web sockets.
>> Tomcat 8.5.5
>>
>> I am trying to do background processing with results being pushed to a
>> client as they become available.
>>
>> I store the connected message when a web socket connection is made [1].
>> This is used to fire push data to a single client/page [2]
>>
>> A little bit of googling I find [3].
>> Am I incorrectly using the api?
>> The ConnectedMessage is not serializable [4]
>>
>>
>>
>> Thanks
>>
>> Peter.
>>
>>
>>
>>
>> [1]
>> private var connected: ConnectedMessage = _
>>
>> add(new WebSocketBehavior {
>>   override def onConnect(message: ConnectedMessage): Unit = {
>> super.onConnect(message)
>> println("web socket connected.")
>> connected = message
>>   }
>> })
>>
>>
>>
>> [2]
>> private def broadcast(msg: IWebSocketPushMessage): Unit = {
>>   val application = WicketStarjarApplication.get()
>>   val webSocketSettings = WebSocketSettings.Holder.get(application)
>>   val broadcaster = new
>> WebSocketPushBroadcaster(webSocketSettings.getConnectionRegistry())
>>   broadcaster.broadcast(connected, msg)
>> }
>>
>>
>> [3]
>> http://apache-wicket.1842946.n4.nabble.com/WebSockets-IKey-n
>> ot-Serializable-td4666996.html
>> https://issues.apache.org/jira/browse/WICKET-5670
>>
>>
>> [4]
>> org.apache.wicket.core.util.objects.checker.CheckingObjectOu
>> tputStream$ObjectCheckException:
>> The object type is not Serializable!
>> A problem occurred while checking object with type:
>> org.apache.wicket.protocol.ws.api.message.ConnectedMessage
>>
>>
>>
>>
>>
>>
>> --
>> Peter Henderson
>>
>
>


Re: WebSocket ConnectedMessage not Serializable

2016-11-19 Thread Martin Grigorov
Hi Peter,

I don't see a problem to make all msgs serializable.
Please create a ticket!
With a Pull Request/Patch would be awesome!
Thank you!

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sat, Nov 19, 2016 at 3:46 PM, Peter Henderson <
peter.hender...@starjar.com> wrote:

> Hi all.
>
> Wicket 7.3.0
> Native web sockets.
> Tomcat 8.5.5
>
> I am trying to do background processing with results being pushed to a
> client as they become available.
>
> I store the connected message when a web socket connection is made [1].
> This is used to fire push data to a single client/page [2]
>
> A little bit of googling I find [3].
> Am I incorrectly using the api?
> The ConnectedMessage is not serializable [4]
>
>
>
> Thanks
>
> Peter.
>
>
>
>
> [1]
> private var connected: ConnectedMessage = _
>
> add(new WebSocketBehavior {
>   override def onConnect(message: ConnectedMessage): Unit = {
> super.onConnect(message)
> println("web socket connected.")
> connected = message
>   }
> })
>
>
>
> [2]
> private def broadcast(msg: IWebSocketPushMessage): Unit = {
>   val application = WicketStarjarApplication.get()
>   val webSocketSettings = WebSocketSettings.Holder.get(application)
>   val broadcaster = new
> WebSocketPushBroadcaster(webSocketSettings.getConnectionRegistry())
>   broadcaster.broadcast(connected, msg)
> }
>
>
> [3]
> http://apache-wicket.1842946.n4.nabble.com/WebSockets-IKey-
> not-Serializable-td4666996.html
> https://issues.apache.org/jira/browse/WICKET-5670
>
>
> [4]
> org.apache.wicket.core.util.objects.checker.CheckingObjectOutputStream$
> ObjectCheckException:
> The object type is not Serializable!
> A problem occurred while checking object with type:
> org.apache.wicket.protocol.ws.api.message.ConnectedMessage
>
>
>
>
>
>
> --
> Peter Henderson
>


WebSocket ConnectedMessage not Serializable

2016-11-19 Thread Peter Henderson
Hi all.

Wicket 7.3.0
Native web sockets.
Tomcat 8.5.5

I am trying to do background processing with results being pushed to a
client as they become available.

I store the connected message when a web socket connection is made [1].
This is used to fire push data to a single client/page [2]

A little bit of googling I find [3].
Am I incorrectly using the api?
The ConnectedMessage is not serializable [4]



Thanks

Peter.




[1]
private var connected: ConnectedMessage = _

add(new WebSocketBehavior {
  override def onConnect(message: ConnectedMessage): Unit = {
super.onConnect(message)
println("web socket connected.")
connected = message
  }
})



[2]
private def broadcast(msg: IWebSocketPushMessage): Unit = {
  val application = WicketStarjarApplication.get()
  val webSocketSettings = WebSocketSettings.Holder.get(application)
  val broadcaster = new
WebSocketPushBroadcaster(webSocketSettings.getConnectionRegistry())
  broadcaster.broadcast(connected, msg)
}


[3]
http://apache-wicket.1842946.n4.nabble.com/WebSockets-IKey-not-Serializable-td4666996.html
https://issues.apache.org/jira/browse/WICKET-5670


[4]
org.apache.wicket.core.util.objects.checker.CheckingObjectOutputStream$ObjectCheckException:
The object type is not Serializable!
A problem occurred while checking object with type:
org.apache.wicket.protocol.ws.api.message.ConnectedMessage






-- 
Peter Henderson