Can you patch ModalWindow in next 1.4 release?

2011-05-11 Thread Russell Morrisey
I created a patch in order to replace ModalWindow's window-closing behavior with a custom IBehavior implementation. The .patch file and a quickstart project are included in the JIRA issue: https://issues.apache.org/jira/browse/WICKET-3630 Could someone who is a committer to wicket-extensions

Re: Can you patch ModalWindow in next 1.4 release?

2011-05-11 Thread James Carman
Would it break other people's existing code? On May 11, 2011 5:13 PM, Russell Morrisey russell.morri...@missionse.com wrote: I created a patch in order to replace ModalWindow's window-closing behavior with a custom IBehavior implementation. The .patch file and a quickstart project are included in

Re: Can you patch ModalWindow in next 1.4 release?

2011-05-11 Thread Martin Grigorov
No, it doesn't. He already said: The change is small and backwards-compatible. And the patch looks OK. On Wed, May 11, 2011 at 11:24 PM, James Carman jcar...@carmanconsulting.com wrote: Would it break other people's existing code? On May 11, 2011 5:13 PM, Russell Morrisey

Re: Can you patch ModalWindow in next 1.4 release?

2011-05-11 Thread James Carman
Sorry, was reading that on my phone. On Wed, May 11, 2011 at 5:26 PM, Martin Grigorov mgrigo...@apache.org wrote: No, it doesn't. He already said: The change is small and backwards-compatible. And the patch looks OK. On Wed, May 11, 2011 at 11:24 PM, James Carman