Re: IBehaviors added to ComponentTag not detached
yes you are right. i was under the impression we were adding those behaviors to the component, but looks like we are not. fixed in 1.3.x.and trunk. thanks for finding it. -igor On Thu, Jan 15, 2009 at 11:43 PM, Jonas barney...@gmail.com wrote: Maybe I'm missing something, but looking at the code again (Wicket 1.3.5), Component#renderComponentTag(...) seems to be the only place where Behaviors added to ComponentTags are dealt with. I can't find any code where they would be added to the Component. I also verfied again, IBehavior#detach(...) seems never to be called if the behavior is added to the ComponentTag. I verified that using a MarkupFilter that adds a behavior to every tag that would log a debug text if detach (or isEnabled) was ever called. Thanks for your time. Jonas On Thu, Jan 15, 2009 at 5:19 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: behaviors added to componenttag are in turn added to components, so they are detached and managed by components no the componenttag they are added to. -igor On Thu, Jan 15, 2009 at 8:16 AM, Jonas barney...@gmail.com wrote: While experimenting with MarkupFilters, I noticed that IBehaviors added to ComponentTag using ComponentTag#addBehavior(IBehavior behavior) are never detached. Is that a bug, or just not possible to do? As far as I can see you don't have ComponentTags available anymore when Components are detached... Furthermore, it seems that their enablement is also ignored, they're always treated as enabled in Component#renderComponentTag(...). cheers - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
IBehaviors added to ComponentTag not detached
While experimenting with MarkupFilters, I noticed that IBehaviors added to ComponentTag using ComponentTag#addBehavior(IBehavior behavior) are never detached. Is that a bug, or just not possible to do? As far as I can see you don't have ComponentTags available anymore when Components are detached... Furthermore, it seems that their enablement is also ignored, they're always treated as enabled in Component#renderComponentTag(...). cheers - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: IBehaviors added to ComponentTag not detached
behaviors added to componenttag are in turn added to components, so they are detached and managed by components no the componenttag they are added to. -igor On Thu, Jan 15, 2009 at 8:16 AM, Jonas barney...@gmail.com wrote: While experimenting with MarkupFilters, I noticed that IBehaviors added to ComponentTag using ComponentTag#addBehavior(IBehavior behavior) are never detached. Is that a bug, or just not possible to do? As far as I can see you don't have ComponentTags available anymore when Components are detached... Furthermore, it seems that their enablement is also ignored, they're always treated as enabled in Component#renderComponentTag(...). cheers - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: IBehaviors added to ComponentTag not detached
Maybe I'm missing something, but looking at the code again (Wicket 1.3.5), Component#renderComponentTag(...) seems to be the only place where Behaviors added to ComponentTags are dealt with. I can't find any code where they would be added to the Component. I also verfied again, IBehavior#detach(...) seems never to be called if the behavior is added to the ComponentTag. I verified that using a MarkupFilter that adds a behavior to every tag that would log a debug text if detach (or isEnabled) was ever called. Thanks for your time. Jonas On Thu, Jan 15, 2009 at 5:19 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: behaviors added to componenttag are in turn added to components, so they are detached and managed by components no the componenttag they are added to. -igor On Thu, Jan 15, 2009 at 8:16 AM, Jonas barney...@gmail.com wrote: While experimenting with MarkupFilters, I noticed that IBehaviors added to ComponentTag using ComponentTag#addBehavior(IBehavior behavior) are never detached. Is that a bug, or just not possible to do? As far as I can see you don't have ComponentTags available anymore when Components are detached... Furthermore, it seems that their enablement is also ignored, they're always treated as enabled in Component#renderComponentTag(...). cheers - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
