Re: IModel parameters of StringResourceModel not getting detached

2009-07-20 Thread Jonas
done:
https://issues.apache.org/jira/browse/WICKET-2381

On Fri, Jul 17, 2009 at 4:52 PM, Johan Compagnerjcompag...@gmail.com wrote:
 please make a jira issue for this
 The detach of StringResourcemodel should walk over its param to check if it
 is a model and call detach on those.

 On Fri, Jul 17, 2009 at 10:44, Jonas barney...@gmail.com wrote:

 A question about StringResourceModel: it supports IModels in the
 'parameters' Object[] that
 are properly handled in StringResourceModel#getString, meaning they
 could get attached because
 of StringResourceModel. Shouldn't it also be the StringResourceModel's
 responsibility to properly
 detach them (from #onDetach)?

 Who's in general responsible to detach an IModel, specially those who
 aren't a Component's
 'default' IModel? Is that correct that any code that calls
 IModel#getObject() should also
 call IModel#detach() later in the same request?

 cheers,
 Jonas

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



IModel parameters of StringResourceModel not getting detached

2009-07-17 Thread Jonas
A question about StringResourceModel: it supports IModels in the
'parameters' Object[] that
are properly handled in StringResourceModel#getString, meaning they
could get attached because
of StringResourceModel. Shouldn't it also be the StringResourceModel's
responsibility to properly
detach them (from #onDetach)?

Who's in general responsible to detach an IModel, specially those who
aren't a Component's
'default' IModel? Is that correct that any code that calls
IModel#getObject() should also
call IModel#detach() later in the same request?

cheers,
Jonas

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: IModel parameters of StringResourceModel not getting detached

2009-07-17 Thread Johan Compagner
please make a jira issue for this
The detach of StringResourcemodel should walk over its param to check if it
is a model and call detach on those.

On Fri, Jul 17, 2009 at 10:44, Jonas barney...@gmail.com wrote:

 A question about StringResourceModel: it supports IModels in the
 'parameters' Object[] that
 are properly handled in StringResourceModel#getString, meaning they
 could get attached because
 of StringResourceModel. Shouldn't it also be the StringResourceModel's
 responsibility to properly
 detach them (from #onDetach)?

 Who's in general responsible to detach an IModel, specially those who
 aren't a Component's
 'default' IModel? Is that correct that any code that calls
 IModel#getObject() should also
 call IModel#detach() later in the same request?

 cheers,
 Jonas

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org