Re: Issue with FileUpload.writeToTempFile()

2008-11-12 Thread Steve Swinsburg
Its just the line endings that are causing the issues with the formatting. There is an app called FLIP (http://ccrma-www.stanford.edu/~craig/utility/flip/ ) which I just used on both files and it reformatted with proper Unix file endings (it converts between all variants). I've attached the

Re: Issue with FileUpload.writeToTempFile()

2008-11-11 Thread Igor Vaynberg
please open a jira issue. -igor On Tue, Nov 11, 2008 at 1:59 AM, Lauri Piispanen - Conmio Ltd [EMAIL PROTECTED] wrote: Hi all, I seem to be having a small portability glitch with FileUpload.writeToTempFile(). Looking at the source code it seems to be using item.getFieldName(), which on my

Re: Re: Issue with FileUpload.writeToTempFile()

2008-11-11 Thread bruno . borges
JIRA issue created - *with patch included* https://issues.apache.org/jira/browse/WICKET-1930 cheers, Bruno On Nov 11, 2008 4:11pm, Igor Vaynberg [EMAIL PROTECTED] wrote: please open a jira issue. -igor On Tue, Nov 11, 2008 at 1:59 AM, Lauri Piispanen - Conmio Ltd wrote: Hi all, I

Issue with FileUpload.writeToTempFile()

2008-11-11 Thread Lauri Piispanen - Conmio Ltd
Hi all, I seem to be having a small portability glitch with FileUpload.writeToTempFile(). Looking at the source code it seems to be using item.getFieldName(), which on my page translates to filefields:1:upload. Windows doesn't really like colons, which gives me the following stacktrace:

Re: Re: Issue with FileUpload.writeToTempFile()

2008-11-11 Thread Igor Vaynberg
hi bruno. first off let me say that we really appreciate the patches... but :) i would like to make a couple of small comments: it would be nice if you used the same formatting settings as us. your patches contain 90% noise which makes them hard to read. try to use simpler names.

Re: Re: Issue with FileUpload.writeToTempFile()

2008-11-11 Thread Bruno Borges
sure igor... :-) your opinion is more than welcome. about the binary search specially. I will keep that in mind for future codes :-) (and not just for wicket) but, about the formatting, I really don't know what's going on. I'm using Ganymede and I've been applying the EclipseCodeFormat.xml

Re: Issue with FileUpload.writeToTempFile()

2008-11-11 Thread Johan Compagner
If you use eclipse you should use the project specific format we have defined for it. You should have a .settings dir or something like that. Look at the wicket project preferences and look what formatter you use there On 11/12/08, Bruno Borges [EMAIL PROTECTED] wrote: sure igor... :-) your