Hi Martin,
Looks sane to me. I created a JIRA issue:
https://issues.apache.org/jira/browse/WICKET-5740 .
Thanks again for your help!
On Tue, Oct 28, 2014 at 9:45 AM, Martin Grigorov wrote:
> Here is my version: http://pastie.org/9680245
> Please create a ticket in JIRA if you like it.
>
> Marti
Here is my version: http://pastie.org/9680245
Please create a ticket in JIRA if you like it.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Tue, Oct 28, 2014 at 9:52 AM, Martin Grigorov
wrote:
> Hi,
>
> I share Sebastien's concern.
> I'll see how to workaround
Hi,
I share Sebastien's concern.
I'll see how to workaround this.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Sat, Oct 25, 2014 at 2:57 PM, Sebastien wrote:
> Hi Guillaume,
>
> Generally speaking, you cannot call a non final method from a
> constructor...
>
Hi Guillaume,
Generally speaking, you cannot call a non final method from a constructor...
Best regards,
Sebastien
On Oct 25, 2014 1:32 PM, "Guillaume Smet" wrote:
> Hi Martin,
>
> I got something working with the following changes in Wicket:
>
> https://github.com/openwide-java/wicket/commit/6
Hi Martin,
I got something working with the following changes in Wicket:
https://github.com/openwide-java/wicket/commit/6374a4a7c6fb66841143a88933523f97305cf1a4
Do you consider this commitable? If so, I can create a JIRA issue and push a PR.
Having the pageId in the getTimeout call is quite nice
If you have a base page then BasePage#onInitialize() should be a good place.
Or you could add the pageIds of the special/slow pages only in the map.
Otherwise you may use PageRequestHandlerTracker#getLastHandler in a custom
IRequestCycleListener#onDetach().
Martin Grigorov
Wicket Training and Con
Hi Martin,
Yeah, I thought about that too but I'm not sure of the best place to
build the pageId -> pageClassName map. Any advice about this?
Once I'll get this working, I'll build a PR for the few changes I made
in Wicket (based on what you proposed earlier). Would be nice to have
them in 6.18.
Hi Guillaume,
Sorry for not thinking more carefully about this the first time!
I'm afraid it is not possible to do it the way I suggested.
PageAccessSynchronizer is the entry point to start using a page and it
works only with pageId!
Here is a new hackish approach:
Store pageId -> pageClassName m
Hi Martin,
On Wed, Oct 22, 2014 at 9:51 AM, Martin Grigorov wrote:
> I'd like to avoid moving the logic that gets the timeout from
> Session.PageAccessSynchronizerProvider to PageAccessSynchronizer because
> this way it will use Application.get() everytime and most apps don't need
> to pay for th
Hi,
You are right!
On Tue, Oct 21, 2014 at 11:11 PM, Guillaume Smet
wrote:
> Hi Martin,
>
> On Tue, Oct 21, 2014 at 1:19 PM, Martin Grigorov
> wrote:
> > You can
> > use
> org.apache.wicket.request.cycle.PageRequestHandlerTracker#getFirstHandler()
> > to check what is the requested page in you
Hi Martin,
On Tue, Oct 21, 2014 at 1:19 PM, Martin Grigorov wrote:
> You can
> use
> org.apache.wicket.request.cycle.PageRequestHandlerTracker#getFirstHandler()
> to check what is the requested page in your
> own org.apache.wicket.settings.def.RequestCycleSettings#getTimeout
Cute trick but it d
Thanks Martin!
We will give it a try and post what we got.
--
Guillaume
On Tue, Oct 21, 2014 at 1:19 PM, Martin Grigorov wrote:
> Hi Guillaume,
>
> You can
> use
> org.apache.wicket.request.cycle.PageRequestHandlerTracker#getFirstHandler()
> to check what is the requested page in your
> own o
Hi Guillaume,
You can
use org.apache.wicket.request.cycle.PageRequestHandlerTracker#getFirstHandler()
to check what is the requested page in your
own org.apache.wicket.settings.def.RequestCycleSettings#getTimeout
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Tu
13 matches
Mail list logo
