Re: [1.4.15] FLAG_INHERITABLE_MODEL and default model change

2011-02-02 Thread Alexander Morozov
Done https://issues.apache.org/jira/browse/WICKET-3413 -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/1-4-15-FLAG-INHERITABLE-MODEL-and-default-model-change-tp3252093p3254349.html Sent from the Users forum mailing list archive at Nabble.com.

Re: [1.4.15] FLAG_INHERITABLE_MODEL and default model change

2011-02-02 Thread Alexander Morozov
Igor, I have one more question about IWrapModel : why the Component#defaultModelComparator doesn't check and unwrap IWrapModel before calling the IModel#getObject() ? private static final IModelComparator defaultModelComparator = new IModelComparator() { private

[1.4.15] FLAG_INHERITABLE_MODEL and default model change

2011-02-01 Thread Alexander Morozov
Hi, I have the question about correctness of Component#setDefaultModel (Component#setModelImpl) method behavior. I expect that the flag FLAG_INHERITABLE_MODEL should be checked there and turned off if the provided model is not a IComponentInheritedModel. Let check the next code: public

Re: [1.4.15] FLAG_INHERITABLE_MODEL and default model change

2011-02-01 Thread Igor Vaynberg
please file a jira -igor On Tue, Feb 1, 2011 at 8:16 AM, Alexander Morozov alexander.v.moro...@gmail.com wrote: Hi, I have the question about correctness of Component#setDefaultModel (Component#setModelImpl) method behavior. I expect that the flag FLAG_INHERITABLE_MODEL should be checked