Re: A bug in CryptedUrlWebRequestCodingStrategy
Bjorn, Please open a Jira issue so that the Wicket core team can track this issue. Regards, Erik. Op 15-09-10 11:24, Bjorn S schreef: Wicket version: 1.4.9 (rolled back due to AJAX problems in later release) I've detected some odd behaviour with CryptedUrlWebRequestCodingStrategy, specifically CryptedUrlWebRequestCodingStrategy.DecodedUrlRequest; When using a QueryStringStrategy for mounting a page and passing certain specific strings I was getting them back with characters missing. It appears that CryptedUrlWebRequestCodingStrategy performs double-decoding. We have a search system which uses + as a means of denoting requirements, this is what happened; When entering a search string like car +red it was correctly encoded to car+%2Bred and passed along. When decoding I saw that this became car +red and then was decoded again to car red [note double space]. I fixed this by extending CryptedUrlWebRequestCodingStrategy, overloading the decode method and implementing my own copy of DecodedUrlRequest where I removed the following line from the constructor; decodedParamReplacement = WicketURLDecoder.QUERY_INSTANCE.decode(decodedParamReplacement); This seems to have fixed our problem though I won't guarantee that it hasn't introduced new ones. Hope this can get a better resolution. Regards, Bjørn Soldal -- Sent from my SMTP compliant software Erik van Oosten http://day-to-day-stuff.blogspot.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
A bug in CryptedUrlWebRequestCodingStrategy
Wicket version: 1.4.9 (rolled back due to AJAX problems in later release) I've detected some odd behaviour with CryptedUrlWebRequestCodingStrategy, specifically CryptedUrlWebRequestCodingStrategy.DecodedUrlRequest; When using a QueryStringStrategy for mounting a page and passing certain specific strings I was getting them back with characters missing. It appears that CryptedUrlWebRequestCodingStrategy performs double-decoding. We have a search system which uses + as a means of denoting requirements, this is what happened; When entering a search string like car +red it was correctly encoded to car+%2Bred and passed along. When decoding I saw that this became car +red and then was decoded again to car red [note double space]. I fixed this by extending CryptedUrlWebRequestCodingStrategy, overloading the decode method and implementing my own copy of DecodedUrlRequest where I removed the following line from the constructor; decodedParamReplacement = WicketURLDecoder.QUERY_INSTANCE.decode(decodedParamReplacement); This seems to have fixed our problem though I won't guarantee that it hasn't introduced new ones. Hope this can get a better resolution. Regards, Bjørn Soldal -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/A-bug-in-CryptedUrlWebRequestCodingStrategy-tp2540215p2540215.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
