CheckGroup updateModel() bug?

2008-08-21 Thread Ritesh Trivedi
Hi, Is there a reason why CheckGroup.updateModel() does not call setModelObject()? If I create Checkgroup with the following CheckGroup myCheckGroup = new CheckGroup(id, new Model() { public Object getObject() { return whatever;}}); Later on - call to myCheckGroup.getModelObject() returns

Re: CheckGroup updateModel() bug?

2008-08-21 Thread jWeekend
Ritesh, There is no need for the else block in the code you have included to call setModelObject as it will only be exercised if there is a collection set already. Double check that somewhere in your code you are not explicitly or implicitly setting the modelObject to null or setting the model

Re: CheckGroup updateModel() bug?

2008-08-21 Thread Ritesh Trivedi
Cemel, Yes, it does make sense in that respect - as the original collection is modified. But the fact that setObject() method of the underlying model is not called, when the object is set, is the problem I am referring to. I had overridden getObject() and setObject() of the adapter Model class

Re: CheckGroup updateModel() bug?

2008-08-21 Thread jWeekend
Ritesh, I wouldn't call it a bug because the model is updated, albeit indirectly, but perhaps in a slightly inconsistent way as you've pointed out (no setModel call), in the name of optimisation (ie reusing the existing collection) and functional consistency (the implementation of the collection

Re: CheckGroup updateModel() bug?

2008-08-21 Thread John Krasnay
Cemal, I think you may be a closet Lisp programmer :-) jk On Thu, Aug 21, 2008 at 12:32:00PM -0700, jWeekend wrote: Ritesh, I wouldn't call it a bug because the model is updated, albeit indirectly, but perhaps in a slightly inconsistent way as you've pointed out (no setModel call), in

Re: CheckGroup updateModel() bug?

2008-08-21 Thread jWeekend
John, It'd be news to me too! BTW, you probably spotted the typo: (no setModel call) should say (no setModelObject call). Regards - Cemal http://www.jWeekend.co.uk http://jWeekend.co.uk John Krasnay wrote: Cemal, I think you may be a closet Lisp programmer :-) jk On Thu, Aug 21,