Re: Could not clear select2Choice component model value.

2015-05-04 Thread Tom Götz
Done: https://github.com/wicketstuff/core/pull/402 Cheers, -Tom On 30.04.2015, at 09:31, Martin Grigorov mgrigo...@apache.org wrote: Hi Tom, Please send a PR with your suggested changes/improvements and we will discuss them. Thanks! Martin Grigorov Wicket Training and

Re: Could not clear select2Choice component model value.

2015-04-30 Thread Martin Grigorov
Hi Tom, Please send a PR with your suggested changes/improvements and we will discuss them. Thanks! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Apr 30, 2015 at 10:27 AM, Tom Götz t...@decoded.de wrote: I found the source of the mentioned changes:

Re: Could not clear select2Choice component model value.

2015-04-30 Thread Tom Götz
See my inline comments On 30.04.2015, at 04:29, Maxim Solodovnik solomax...@gmail.com wrote: The changes I have made were (most probably) merged from original Igor's code (https://github.com/ivaynberg/wicket-select2) I can’t find the ListT choices“ property of AbstractSelect2Choice

Re: Could not clear select2Choice component model value.

2015-04-30 Thread Tom Götz
I found the source of the mentioned changes: https://github.com/wicketstuff/core/commit/79781d83cf11ac63d2e661328fa7176b93184c64 -Tom On 30.04.2015, at 08:58, Tom Götz t...@decoded.de wrote: See my inline comments On 30.04.2015, at 04:29, Maxim Solodovnik solomax...@gmail.com wrote:

Re: Could not clear select2Choice component model value.

2015-04-29 Thread Tom Götz
Sorry, Github link was broken in last email (additional „:“ at the end), use this: https://github.com/wicketstuff/core/commit/92851a253253849582a117d66dee5fcdb15c7353 -Tom On 29.04.2015, at 14:01, Tom Götz t...@decoded.de wrote: Hi Maxim, I do not understand the changes you

Re: Could not clear select2Choice component model value.

2015-04-29 Thread Tom Götz
Hi Maxim, I do not understand the changes you introduced to AbstractSelect2Choice.java in https://github.com/wicketstuff/core/commit/92851a253253849582a117d66dee5fcdb15c7353: 1. you added a private ListT choices“ property, what is the purpose of this? Isn’t the ChoiceProvider supposed to

Re: Could not clear select2Choice component model value.

2015-04-29 Thread Maxim Solodovnik
Hello Tom, sorry for the brief response (I need to go in 30 minutes, hopefully Martin can also comment on this) The changes I have made were (most probably) merged from original Igor's code (https://github.com/ivaynberg/wicket-select2) 1) I believe this is since AbstractSelect2Choice is parent

Re: Could not clear select2Choice component model value.

2014-11-30 Thread Maxim Solodovnik
Merged! Seems to work as expected in our application Thanks for the fix Martin! On Wed, Nov 26, 2014 at 10:20 AM, Maxim Solodovnik solomax...@gmail.com wrote: Thanks a lot! I'll backport! On Wed, Nov 26, 2014 at 1:34 AM, Martin Grigorov mgrigo...@apache.org wrote: Fixed with

Re: Could not clear select2Choice component model value.

2014-11-30 Thread Martin Grigorov
Great ! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sun, Nov 30, 2014 at 4:32 PM, Maxim Solodovnik solomax...@gmail.com wrote: Merged! Seems to work as expected in our application Thanks for the fix Martin! On Wed, Nov 26, 2014 at 10:20 AM, Maxim

Re: Could not clear select2Choice component model value.

2014-11-25 Thread Martin Grigorov
Hi Maxim, The change has been introduced in Wicket-Select2 with https://github.com/ivaynberg/wicket-select2/issues/29 I'll see how to fix it now. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Nov 12, 2014 at 12:11 PM, Martin Grigorov mgrigo...@apache.org

Re: Could not clear select2Choice component model value.

2014-11-25 Thread Martin Grigorov
Fixed with https://github.com/wicketstuff/core/commit/b7e5b68b858336d85958663204166bd0852b43dd Hopefully all other use cases are still covered. I just noticed that there is https://github.com/wicketstuff/core/tree/wicket-6.x/jdk-1.6-parent/select2-parent (i.e. Wicket 6.x version). It would be

Re: Could not clear select2Choice component model value.

2014-11-25 Thread Maxim Solodovnik
Thanks a lot! I'll backport! On Wed, Nov 26, 2014 at 1:34 AM, Martin Grigorov mgrigo...@apache.org wrote: Fixed with https://github.com/wicketstuff/core/commit/b7e5b68b858336d85958663204166bd0852b43dd Hopefully all other use cases are still covered. I just noticed that there is

Re: Could not clear select2Choice component model value.

2014-11-12 Thread Martin Grigorov
It is in my TODO list... Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Nov 11, 2014 at 6:29 PM, Maxim Solodovnik solomax...@gmail.com wrote: Hello Martin, I know you are busy man ..., but, were you able to take a look at this issue? :) On 22 October

Re: Could not clear select2Choice component model value.

2014-11-11 Thread Maxim Solodovnik
Hello Martin, I know you are busy man ..., but, were you able to take a look at this issue? :) On 22 October 2014 11:23, Maxim Solodovnik solomax...@gmail.com wrote: It seems like script generated in renderInitializationScript should be added to AjaxRequestTarget on every Ajax update ... On

Re: Could not clear select2Choice component model value.

2014-10-21 Thread Martin Grigorov
Hi Maxim, Please prepare a quickstart at GitHub and I'll take a look. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Oct 17, 2014 at 5:42 PM, Maxim Solodovnik solomax...@gmail.com wrote: Martin, I have forked select2, unfortunately I'm still not sure

Re: Could not clear select2Choice component model value.

2014-10-21 Thread Maxim Solodovnik
Here it is: https://github.com/solomax/WicketSelect2Clear somehow in this example nothing works as expected :( I tried 2 different approaches, correct new value arrives to the page (according to wicket debug) but select2 is not being updated :( On 21 October 2014 13:23, Martin Grigorov

Re: Could not clear select2Choice component model value.

2014-10-21 Thread Maxim Solodovnik
It seems like script generated in renderInitializationScript should be added to AjaxRequestTarget on every Ajax update ... On 21 October 2014 17:09, Maxim Solodovnik solomax...@gmail.com wrote: Here it is: https://github.com/solomax/WicketSelect2Clear somehow in this example nothing works as

Re: Could not clear select2Choice component model value.

2014-10-17 Thread Maxim Solodovnik
Martin, I have forked select2, unfortunately I'm still not sure how to fix the issue :( Clean link is added to the form and select data is being restored from requestParameters :( On 13 October 2014 19:06, Martin Grigorov mgrigo...@apache.org wrote: Maxim, Feel free to fork it! I.e. move it

Re: Could not clear select2Choice component model value.

2014-10-13 Thread Martin Grigorov
Maxim, Feel free to fork it! I.e. move it to WicketStuff. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Oct 9, 2014 at 8:53 PM, Maxim Solodovnik solomax...@gmail.com wrote: Additionally select2 seems to need to be forked to wicketstuff to be fixed,

Re: Could not clear select2Choice component model value.

2014-10-09 Thread MadasamySankarapandian
Thanks Maxim Solodovnik. On Thu, Oct 9, 2014 at 12:33 PM, Maxim Solodovnik solomax...@gmail.com wrote: I also noticed this issue in our project, Will try to take a look at it On 9 October 2014 07:33, MadasamySankarapandian madas...@mcruncher.com wrote: Thankyou very much for yours reply.

Re: Could not clear select2Choice component model value.

2014-10-09 Thread Maxim Solodovnik
@Paul, @Martin Select2Choice sets back its value to getWebRequest().getRequestParameters().getParameterNames() in renderInitializationScript method [1] It seems like JS code like: $(#country1).select2(data, null); can be executed on clear input, but this seems to be workaround I'm not sure why

Re: Could not clear select2Choice component model value.

2014-10-09 Thread Maxim Solodovnik
Additionally select2 seems to need to be forked to wicketstuff to be fixed, should I do this? On 10 October 2014 00:49, Maxim Solodovnik solomax...@gmail.com wrote: @Paul, @Martin Select2Choice sets back its value to getWebRequest().getRequestParameters().getParameterNames() in

Re: Could not clear select2Choice component model value.

2014-10-08 Thread MadasamySankarapandian
Thankyou very much for yours reply. I call formComponent.clearInput() in my ClearFormVisitor class. But It does not work. I have created issue-96 https://github.com/ivaynberg/wicket-select2/issues/96 in wicket-select2 project. On Wed, Oct 8, 2014 at 12:13 AM, Maxim Solodovnik

Re: Could not clear select2Choice component model value.

2014-10-08 Thread Maxim Solodovnik
I also noticed this issue in our project, Will try to take a look at it On 9 October 2014 07:33, MadasamySankarapandian madas...@mcruncher.com wrote: Thankyou very much for yours reply. I call formComponent.clearInput() in my ClearFormVisitor class. But It does not work. I have created

Re: Could not clear select2Choice component model value.

2014-10-07 Thread Martin Grigorov
Hi, You should call formComponent.clearInput() too. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Oct 7, 2014 at 9:13 AM, MadasamySankarapandian madas...@mcruncher.com wrote: This is regarding wicket-select2 project. I could not find any mailing list

Re: Could not clear select2Choice component model value.

2014-10-07 Thread Paul Bors
You can also ask the developer via: https://github.com/ivaynberg/wicket-select2/issues You should probably take a look over the open issues so that you are familiar with that other developers faced. Maybe one of those issues might be a road block for you? Although you will get a faster reply

Re: Could not clear select2Choice component model value.

2014-10-07 Thread Maxim Solodovnik
we recently moved this component to wicketstuff: https://github.com/wicketstuff/core/tree/master/jdk-1.7-parent/select2-parent to get Wicket7 compatible version On 7 October 2014 22:56, Paul Bors p...@bors.ws wrote: You can also ask the developer via:

Re: Could not clear select2Choice component model value.

2014-10-07 Thread Paul Bors
Can you update this issue then? https://github.com/ivaynberg/wicket-select2/issues/93 On Tue, Oct 7, 2014 at 12:00 PM, Maxim Solodovnik solomax...@gmail.com wrote: we recently moved this component to wicketstuff: https://github.com/wicketstuff/core/tree/master/jdk-1.7-parent/select2-parent

Re: Could not clear select2Choice component model value.

2014-10-07 Thread Maxim Solodovnik
Done, thanks for pointing this out On 7 October 2014 23:08, Paul Bors p...@bors.ws wrote: Can you update this issue then? https://github.com/ivaynberg/wicket-select2/issues/93 On Tue, Oct 7, 2014 at 12:00 PM, Maxim Solodovnik solomax...@gmail.com wrote: we recently moved this component