Re: Fix for WICKET-3947 and WICKET-4700

2012-09-02 Thread Martin Makundi
I propose that because this is a bugfix
(https://issues.apache.org/jira/browse/WICKET-3947) with thorough
junit tests, it should be added to 1.4.x

**
Martin

2012/8/21 Veikko Törmänen veikko.torma...@hotmail.com:
 Thank you for the information.

 I had missed the correct patch protocol and wasn't aware that the 1.4.x was
 frozen.

 Apologies.



 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-09-02 Thread Martin Grigorov
Wicket 1.4.x is frozen. Only security bug fixes can be committed.
1.4.21 is being voted and the vote ends tomorrow.

About the patch - I still don't like the leak that it adds -
o.a.w.Component will know about InlineEnclosure (a specialization of
Component).

Why you don't like the workaround with the simple WebMarkupContainer
as a parent of InlineEnclosure ?

On Sun, Sep 2, 2012 at 12:53 PM, Martin Makundi
martin.maku...@koodaripalvelut.com wrote:
 I propose that because this is a bugfix
 (https://issues.apache.org/jira/browse/WICKET-3947) with thorough
 junit tests, it should be added to 1.4.x

 **
 Martin

 2012/8/21 Veikko Törmänen veikko.torma...@hotmail.com:
 Thank you for the information.

 I had missed the correct patch protocol and wasn't aware that the 1.4.x was
 frozen.

 Apologies.



 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-09-02 Thread Martin Makundi
Hi!

 Wicket 1.4.x is frozen. Only security bug fixes can be committed.
 1.4.21 is being voted and the vote ends tomorrow.

This would be a good opportunity to get widespread experience of this
bugfix, it will benefit also later versions.

 About the patch - I still don't like the leak that it adds -
 o.a.w.Component will know about InlineEnclosure (a specialization of
 Component).

We didn't find a way to do this in the current wicket architecture,
it's simply does not support autocomponents well enough.

 Why you don't like the workaround with the simple WebMarkupContainer
 as a parent of InlineEnclosure ?

Well that was the original boilerplate code we wanted to get rid of in
first place. Ofcourse everything can be done the hard way but built in
support for such basic functionality is beneficial.

**
Martin



 On Sun, Sep 2, 2012 at 12:53 PM, Martin Makundi
 martin.maku...@koodaripalvelut.com wrote:
 I propose that because this is a bugfix
 (https://issues.apache.org/jira/browse/WICKET-3947) with thorough
 junit tests, it should be added to 1.4.x

 **
 Martin

 2012/8/21 Veikko Törmänen veikko.torma...@hotmail.com:
 Thank you for the information.

 I had missed the correct patch protocol and wasn't aware that the 1.4.x was
 frozen.

 Apologies.



 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-09-02 Thread Martin Grigorov
On Sun, Sep 2, 2012 at 1:03 PM, Martin Makundi
martin.maku...@koodaripalvelut.com wrote:
 Hi!

 Wicket 1.4.x is frozen. Only security bug fixes can be committed.
 1.4.21 is being voted and the vote ends tomorrow.

 This would be a good opportunity to get widespread experience of this
 bugfix, it will benefit also later versions.

There is a chance to break something else ... The risk is big.


 About the patch - I still don't like the leak that it adds -
 o.a.w.Component will know about InlineEnclosure (a specialization of
 Component).

 We didn't find a way to do this in the current wicket architecture,
 it's simply does not support autocomponents well enough.

We know that. We will think how this can be improved for Wicket 7.
In Wicket 1.5 there is EnclosureContainer which can be used as a
replacement of (Inline)Enclosure. The difference is that it is not an
auto component.


 Why you don't like the workaround with the simple WebMarkupContainer
 as a parent of InlineEnclosure ?

 Well that was the original boilerplate code we wanted to get rid of in
 first place. Ofcourse everything can be done the hard way but built in
 support for such basic functionality is beneficial.

I suggest you to spend some time to upgrade to 1.5.8 or 6.0.0.
These are the versions we also use in production and it will be easy
to catch any problems when applying patches by users.


 **
 Martin



 On Sun, Sep 2, 2012 at 12:53 PM, Martin Makundi
 martin.maku...@koodaripalvelut.com wrote:
 I propose that because this is a bugfix
 (https://issues.apache.org/jira/browse/WICKET-3947) with thorough
 junit tests, it should be added to 1.4.x

 **
 Martin

 2012/8/21 Veikko Törmänen veikko.torma...@hotmail.com:
 Thank you for the information.

 I had missed the correct patch protocol and wasn't aware that the 1.4.x was
 frozen.

 Apologies.



 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-09-02 Thread Martin Makundi
Hi!

 Wicket 1.4.x is frozen. Only security bug fixes can be committed.
 1.4.21 is being voted and the vote ends tomorrow.

 This would be a good opportunity to get widespread experience of this
 bugfix, it will benefit also later versions.

 There is a chance to break something else ... The risk is big.

Well.. just run all the tests ;)

 We didn't find a way to do this in the current wicket architecture,
 it's simply does not support autocomponents well enough.

 We know that. We will think how this can be improved for Wicket 7.
 In Wicket 1.5 there is EnclosureContainer which can be used as a
 replacement of (Inline)Enclosure. The difference is that it is not an
 auto component.

 I suggest you to spend some time to upgrade to 1.5.8 or 6.0.0.
 These are the versions we also use in production and it will be easy
 to catch any problems when applying patches by users.

The pace of upgrading from one incompatible wicket to another seem so
fast that we will wait for 7 or 8 or 9 =) We are currently in pretty
far a sweetspot in wicket development, it has almost all the features
we need and we have hacked into it everything it does not have yet
that we need, so upgrading would make no sense, upgrading would take
us way backwards.

**
Martin



 On Sun, Sep 2, 2012 at 12:53 PM, Martin Makundi
 martin.maku...@koodaripalvelut.com wrote:
 I propose that because this is a bugfix
 (https://issues.apache.org/jira/browse/WICKET-3947) with thorough
 junit tests, it should be added to 1.4.x

 **
 Martin

 2012/8/21 Veikko Törmänen veikko.torma...@hotmail.com:
 Thank you for the information.

 I had missed the correct patch protocol and wasn't aware that the 1.4.x 
 was
 frozen.

 Apologies.



 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-09-02 Thread Martin Grigorov
On Sun, Sep 2, 2012 at 1:20 PM, Martin Makundi
martin.maku...@koodaripalvelut.com wrote:
 Hi!

 Wicket 1.4.x is frozen. Only security bug fixes can be committed.
 1.4.21 is being voted and the vote ends tomorrow.

 This would be a good opportunity to get widespread experience of this
 bugfix, it will benefit also later versions.

 There is a chance to break something else ... The risk is big.

 Well.. just run all the tests ;)

I'm looking at the tests in the patch and I see things like:

+
+   //assertEquals(InlineEnclosure has traversed page x times , 
new
Integer(1), new
Integer(InlineEnclosure.inlineEnclosureTraversalCounter));
+   //  
InlineEnclosure.CALCULATE_INLINE_ENCLOSURE_PERFORMANCE = false;
+

Not happy!


 We didn't find a way to do this in the current wicket architecture,
 it's simply does not support autocomponents well enough.

 We know that. We will think how this can be improved for Wicket 7.
 In Wicket 1.5 there is EnclosureContainer which can be used as a
 replacement of (Inline)Enclosure. The difference is that it is not an
 auto component.

 I suggest you to spend some time to upgrade to 1.5.8 or 6.0.0.
 These are the versions we also use in production and it will be easy
 to catch any problems when applying patches by users.

 The pace of upgrading from one incompatible wicket to another seem so
 fast that we will wait for 7 or 8 or 9 =) We are currently in pretty
 far a sweetspot in wicket development, it has almost all the features
 we need and we have hacked into it everything it does not have yet
 that we need, so upgrading would make no sense, upgrading would take
 us way backwards.

Right. Sometimes it doesn't worth it.
Then use Wicket 6+ in your next project (if you still like it ;-) ).


 **
 Martin



 On Sun, Sep 2, 2012 at 12:53 PM, Martin Makundi
 martin.maku...@koodaripalvelut.com wrote:
 I propose that because this is a bugfix
 (https://issues.apache.org/jira/browse/WICKET-3947) with thorough
 junit tests, it should be added to 1.4.x

 **
 Martin

 2012/8/21 Veikko Törmänen veikko.torma...@hotmail.com:
 Thank you for the information.

 I had missed the correct patch protocol and wasn't aware that the 1.4.x 
 was
 frozen.

 Apologies.



 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-09-02 Thread Martin Makundi
 I'm looking at the tests in the patch and I see things like:

 +
 +   //assertEquals(InlineEnclosure has traversed page x times , 
 new
 Integer(1), new
 Integer(InlineEnclosure.inlineEnclosureTraversalCounter));
 +   //  
 InlineEnclosure.CALCULATE_INLINE_ENCLOSURE_PERFORMANCE = false;
 +

 Not happy!

Ok, we'll fix that.

 Right. Sometimes it doesn't worth it.
 Then use Wicket 6+ in your next project (if you still like it ;-) ).

Heh, we try to have a platform for rapidly extending our app so a
completely new project from scratch is something I can't immagine yet.
Maybe it will be wicket 60.0 ;)

**
Martin



 On Sun, Sep 2, 2012 at 12:53 PM, Martin Makundi
 martin.maku...@koodaripalvelut.com wrote:
 I propose that because this is a bugfix
 (https://issues.apache.org/jira/browse/WICKET-3947) with thorough
 junit tests, it should be added to 1.4.x

 **
 Martin

 2012/8/21 Veikko Törmänen veikko.torma...@hotmail.com:
 Thank you for the information.

 I had missed the correct patch protocol and wasn't aware that the 1.4.x 
 was
 frozen.

 Apologies.



 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-09-02 Thread Veikko Törmänen
 I'm looking at the tests in the patch and I see things like:

 +
 +   //assertEquals(InlineEnclosure has traversed page x
 times , new
 Integer(1), new
 Integer(InlineEnclosure.inlineEnclosureTraversalCounter));
 +   // 
 InlineEnclosure.CALCULATE_INLINE_ENCLOSURE_PERFORMANCE = false;
 +

 Not happy!

 Ok, we'll fix that.

Fixed. 
I replaced previous patch with new one.

-Veikko



--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651701.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Fix for WICKET-3947 and WICKET-4700

2012-08-21 Thread Veikko Törmänen
Hi!

I have a fix/patch for two wicket bugs:

https://issues.apache.org/jira/browse/WICKET-3947
https://issues.apache.org/jira/browse/WICKET-3947 

and

https://issues.apache.org/jira/browse/WICKET-4700
https://issues.apache.org/jira/browse/WICKET-4700 


This fix causes three of the junit tests to fail and I could use some help
on figuring them out.

First two are in org.apache.wicket.markup.html.border.ComponentBorderTest
where both of tests cause error.
I don't understand what these tests do so I've had problems on locating the
problem.

Third is in org.apache.wicket.markup.html.internal.InlineEnclosureTest
where testInlineEnclosurePage_1 causes error.
This test I understand but what I don't understand is why my patch causes
this error?

If someone could take a look of this patch and could help me locate my
problem I would appreciate it.

http://apache-wicket.1842946.n4.nabble.com/file/n4651386/Patch_for_WICKET-3947.zip
Patch_for_WICKET-3947.zip 

-Veikko



--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-08-21 Thread Martin Grigorov
One more thing: Wicket 1.4.x is frozen. Only security related fixes
may go in. If we find a fix for these problems we will apply them only
in 1.5.x and 6.x

On Tue, Aug 21, 2012 at 10:31 AM, Martin Grigorov mgrigo...@apache.org wrote:
 Hi,

 Thanks for your contribution!

 The .zip that you attached is not really a patch :-/ It contains
 modified (I guess) complete files which I have to diff with the
 original ones to see what changes you have made...

 One thing that bothers me a lot is that (Inline)Enclosure
 functionality requires changes in o.a.w. Component and
 MarkupContainer. I really don't like Component.java to have
 logic/knowledge about (Inline)Enclosure.

 I agree that the bug is annoying but for now I find my workaround as
 the best solution - just add a dummy WebMarkupContainer in the
 hierarchy and the bug disappears.

 On Tue, Aug 21, 2012 at 9:13 AM, Veikko Törmänen
 veikko.torma...@hotmail.com wrote:
 Hi!

 I have a fix/patch for two wicket bugs:

 https://issues.apache.org/jira/browse/WICKET-3947
 https://issues.apache.org/jira/browse/WICKET-3947

 and

 https://issues.apache.org/jira/browse/WICKET-4700
 https://issues.apache.org/jira/browse/WICKET-4700


 This fix causes three of the junit tests to fail and I could use some help
 on figuring them out.

 First two are in org.apache.wicket.markup.html.border.ComponentBorderTest
 where both of tests cause error.
 I don't understand what these tests do so I've had problems on locating the
 problem.

 Third is in org.apache.wicket.markup.html.internal.InlineEnclosureTest
 where testInlineEnclosurePage_1 causes error.
 This test I understand but what I don't understand is why my patch causes
 this error?

 If someone could take a look of this patch and could help me locate my
 problem I would appreciate it.

 http://apache-wicket.1842946.n4.nabble.com/file/n4651386/Patch_for_WICKET-3947.zip
 Patch_for_WICKET-3947.zip

 -Veikko



 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org




 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Fix for WICKET-3947 and WICKET-4700

2012-08-21 Thread Veikko Törmänen
Thank you for the information.

I had missed the correct patch protocol and wasn't aware that the 1.4.x was
frozen.

Apologies.



--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org