Re: FormComponentFeedbackBorder / missing message display / Bug or Feature?
Ok, done, WICKET-5788. Thanx a lot... Patrick Am 08.12.2014 22:55, schrieb Martin Grigorov: Now the question is more clear! Thanks! I don't see anything in FormComponentFeedbackBorder code that consumes the feedback message, i.e. marks it as rendered. Please create a quickstart and attach it to a ticket in JIRA and we will take a look. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Dec 8, 2014 at 3:23 PM, Patrick Davids >wrote: >Yes, FormComponentFeedbackBorder itself just shows an asterisk. > >So, ok, my question was still unclear.;-) >Is it a feature or a bug, that a FormComponentFeedbackBorder surpresses >the messages of its child formcomponent, which possibly could be shown by a >FeedbackPanel somewhere else in the upper component hierarchy? >:-) > >Patrick - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: FormComponentFeedbackBorder / missing message display / Bug or Feature?
Now the question is more clear! Thanks! I don't see anything in FormComponentFeedbackBorder code that consumes the feedback message, i.e. marks it as rendered. Please create a quickstart and attach it to a ticket in JIRA and we will take a look. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Dec 8, 2014 at 3:23 PM, Patrick Davids wrote: > Yes, FormComponentFeedbackBorder itself just shows an asterisk. > > So, ok, my question was still unclear. ;-) > Is it a feature or a bug, that a FormComponentFeedbackBorder surpresses > the messages of its child formcomponent, which possibly could be shown by a > FeedbackPanel somewhere else in the upper component hierarchy? > :-) > > Patrick > > Am 08.12.2014 14:37, schrieb Martin Grigorov: > > Well, according to >> https://github.com/apache/wicket/blob/master/wicket- >> core/src/main/java/org/apache/wicket/markup/html/form/validation/ >> FormComponentFeedbackBorder.html >> this border is supposed to show only a red asterisk in case the form >> component is invalid. Nothing more. So it is by design. >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> On Mon, Dec 8, 2014 at 2:33 PM, Patrick Davids < >> patrick.dav...@nubologic.com >> >>> wrote: >>> >> >> I wrapped a formcomponent into a FormComponentFeedbackBorder to get an >>> asterisk in case of errors. >>> >>> I am asking if this is a bug or a feature, because currently I am >>> implementing a custom behavior, which adds an error message in a >>> special-case to the component CustomBehavior.onConfigure(Component >>> component). >>> >>> My error message is not displayed, the asterisk is working. >>> I would expect it is displayed as the asterisk is displayed as well. >>> >>> >>> Patrick >>> >>> >>> Am 08.12.2014 14:14, schrieb Martin Grigorov: >>> >>> Hi, >>> Please give more information. The question is not very clear. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Dec 8, 2014 at 12:06 PM, Patrick Davids < patrick.dav...@nubologic.com> wrote: Hi all, > is it a correct behavior, a FormComponentFeedbackBorder (asterisks for > form inputs) does not display a / the message in a feedbackpanel (if > available somewhere)? > > kind regards > Patrick > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > > > - >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>> For additional commands, e-mail: users-h...@wicket.apache.org >>> >>> >>> >> > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Re: FormComponentFeedbackBorder / missing message display / Bug or Feature?
Yes, FormComponentFeedbackBorder itself just shows an asterisk. So, ok, my question was still unclear. ;-) Is it a feature or a bug, that a FormComponentFeedbackBorder surpresses the messages of its child formcomponent, which possibly could be shown by a FeedbackPanel somewhere else in the upper component hierarchy? :-) Patrick Am 08.12.2014 14:37, schrieb Martin Grigorov: Well, according to https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/form/validation/FormComponentFeedbackBorder.html this border is supposed to show only a red asterisk in case the form component is invalid. Nothing more. So it is by design. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Dec 8, 2014 at 2:33 PM, Patrick Davids wrote: I wrapped a formcomponent into a FormComponentFeedbackBorder to get an asterisk in case of errors. I am asking if this is a bug or a feature, because currently I am implementing a custom behavior, which adds an error message in a special-case to the component CustomBehavior.onConfigure(Component component). My error message is not displayed, the asterisk is working. I would expect it is displayed as the asterisk is displayed as well. Patrick Am 08.12.2014 14:14, schrieb Martin Grigorov: Hi, Please give more information. The question is not very clear. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Dec 8, 2014 at 12:06 PM, Patrick Davids < patrick.dav...@nubologic.com> wrote: Hi all, is it a correct behavior, a FormComponentFeedbackBorder (asterisks for form inputs) does not display a / the message in a feedbackpanel (if available somewhere)? kind regards Patrick - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: FormComponentFeedbackBorder / missing message display / Bug or Feature?
Well, according to https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/form/validation/FormComponentFeedbackBorder.html this border is supposed to show only a red asterisk in case the form component is invalid. Nothing more. So it is by design. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Dec 8, 2014 at 2:33 PM, Patrick Davids wrote: > I wrapped a formcomponent into a FormComponentFeedbackBorder to get an > asterisk in case of errors. > > I am asking if this is a bug or a feature, because currently I am > implementing a custom behavior, which adds an error message in a > special-case to the component CustomBehavior.onConfigure(Component > component). > > My error message is not displayed, the asterisk is working. > I would expect it is displayed as the asterisk is displayed as well. > > > Patrick > > > Am 08.12.2014 14:14, schrieb Martin Grigorov: > > Hi, >> >> Please give more information. >> The question is not very clear. >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> On Mon, Dec 8, 2014 at 12:06 PM, Patrick Davids < >> patrick.dav...@nubologic.com> wrote: >> >> Hi all, >>> is it a correct behavior, a FormComponentFeedbackBorder (asterisks for >>> form inputs) does not display a / the message in a feedbackpanel (if >>> available somewhere)? >>> >>> kind regards >>> Patrick >>> >>> - >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>> For additional commands, e-mail: users-h...@wicket.apache.org >>> >>> >>> >> > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Re: FormComponentFeedbackBorder / missing message display / Bug or Feature?
I wrapped a formcomponent into a FormComponentFeedbackBorder to get an asterisk in case of errors. I am asking if this is a bug or a feature, because currently I am implementing a custom behavior, which adds an error message in a special-case to the component CustomBehavior.onConfigure(Component component). My error message is not displayed, the asterisk is working. I would expect it is displayed as the asterisk is displayed as well. Patrick Am 08.12.2014 14:14, schrieb Martin Grigorov: Hi, Please give more information. The question is not very clear. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Dec 8, 2014 at 12:06 PM, Patrick Davids < patrick.dav...@nubologic.com> wrote: Hi all, is it a correct behavior, a FormComponentFeedbackBorder (asterisks for form inputs) does not display a / the message in a feedbackpanel (if available somewhere)? kind regards Patrick - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: FormComponentFeedbackBorder / missing message display / Bug or Feature?
Hi, Please give more information. The question is not very clear. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Dec 8, 2014 at 12:06 PM, Patrick Davids < patrick.dav...@nubologic.com> wrote: > Hi all, > is it a correct behavior, a FormComponentFeedbackBorder (asterisks for > form inputs) does not display a / the message in a feedbackpanel (if > available somewhere)? > > kind regards > Patrick > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
FormComponentFeedbackBorder / missing message display / Bug or Feature?
Hi all, is it a correct behavior, a FormComponentFeedbackBorder (asterisks for form inputs) does not display a / the message in a feedbackpanel (if available somewhere)? kind regards Patrick - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org