Re: LoadableDetachableModel getObject not final

2011-11-21 Thread Tito
Hi Igor, Exactly, that is the reason because I'm proposing to make getObject final. I think it's not ok to override getObject. What do you think? 2011/11/18 Igor Vaynberg igor.vaynb...@gmail.com getObject() is what defines the contract of load(). if we make it overridable the user can then

Re: LoadableDetachableModel getObject not final

2011-11-21 Thread Igor Vaynberg
ah, lol. I thought it was final now and you wanted to make non final... :) open a jira... -igor On Nov 21, 2011 11:36 AM, Tito njyt...@gmail.com wrote: Hi Igor, Exactly, that is the reason because I'm proposing to make getObject final. I think it's not ok to override getObject. What do you

Re: LoadableDetachableModel getObject not final

2011-11-21 Thread Tito
Created: https://issues.apache.org/jira/browse/WICKET-4253 Thanks you 2011/11/21 Igor Vaynberg igor.vaynb...@gmail.com ah, lol. I thought it was final now and you wanted to make non final... :) open a jira... -igor On Nov 21, 2011 11:36 AM, Tito njyt...@gmail.com wrote: Hi Igor,

LoadableDetachableModel getObject not final

2011-11-18 Thread Tito
Hi, I'm wondering if it is ok not to do 'final' this method. Correct me if I'm wrong but I think it is not normal to Override this method because we always have to Override load(). It's just a question to know what do you think. Thanks! Norberto

Re: LoadableDetachableModel getObject not final

2011-11-18 Thread Igor Vaynberg
getObject() is what defines the contract of load(). if we make it overridable the user can then break the load() function - for example by not calling it from the override. why would you want to override getobject()? -igor On Fri, Nov 18, 2011 at 10:39 AM, Tito njyt...@gmail.com wrote: Hi,