Re: Mounting problem with GlassFishv3
Peter, keep us posted on what the GF team comes back with. Best, Riyad 2010/1/31 Major Péter majorpe...@sch.bme.hu Hi, I made some investigation today, and found out the followings: With GlassFishv2 when the bookmarkablepagelink calculates the url, finally it goes to ServletWebRequest#getRelativePathPrefixToWicketHandler() . The difference is on line #270: String forwardUrl = (String)httpRequest.getAttribute(javax.servlet.forward.servlet_path); With v2, the forwardUrl is /asdf (the wrong url again) With v3 the forwardUrl is null! It looks like there were some changes in the servlet API, namely: The HttpServletRequest's dispatcherType is now an enum instead of Integer (I don't know if this is relevant to the issue), and also, the HSR contains a HashMap called specialAttributes, which with GFv2 contains the forward attributes, but not with GFv3. After further tests, I checked the whole thing without wicket with just simple servlets, and this behaviour is appearing there too. Now I'm gonna go and ask the GlassFish team what they think about this issue and return here with the answer. Thanks, Peter 2010-01-30 20:28 keltezéssel, Major Péter írta: Hi, I've an application, which in its web.xml has a 404 page declared: error-page error-code404/error-code location/error/NotFound/location /error-page The filter-mapping for wicket that's why has the ERROR dispatcher. I created a NotFound page and mounted it via: mount(/error, PackageName.forClass(NotFound.class)); and the homepage is mounted via: mountBookmarkablePage(/homepage, HomePage.class); So, if the error page has a bookmarkablepagelink, which is pointing to the Homepage, and I request a wrong URL (e.g. 'asdf'), then the link is 'error/NotFound/homepage' instead of 'homepage'. But when I get the page with error/NotFound the link works just fine. I have a Quickstart app which demonstrates the problem, and it looks like with Jetty and GFv2 it works, but not with GFv3. Should I create a JIRA issue for this? I'm not sure that the web.xml-like errorpage is causing the error or the mount is the problem.. I also checked version-compatibilities, and both with 1.4.1 and 1.3.6 I got the same behaviour. Thanks, Peter - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Mounting problem with GlassFishv3
Hi, the result is this ticket: https://issues.apache.org/jira/browse/WICKET-2712 See more details there. Regards, Peter 2010-02-01 16:42 keltezéssel, Riyad Kalla írta: Peter, keep us posted on what the GF team comes back with. Best, Riyad 2010/1/31 Major Péter majorpe...@sch.bme.hu Hi, I made some investigation today, and found out the followings: With GlassFishv2 when the bookmarkablepagelink calculates the url, finally it goes to ServletWebRequest#getRelativePathPrefixToWicketHandler() . The difference is on line #270: String forwardUrl = (String)httpRequest.getAttribute(javax.servlet.forward.servlet_path); With v2, the forwardUrl is /asdf (the wrong url again) With v3 the forwardUrl is null! It looks like there were some changes in the servlet API, namely: The HttpServletRequest's dispatcherType is now an enum instead of Integer (I don't know if this is relevant to the issue), and also, the HSR contains a HashMap called specialAttributes, which with GFv2 contains the forward attributes, but not with GFv3. After further tests, I checked the whole thing without wicket with just simple servlets, and this behaviour is appearing there too. Now I'm gonna go and ask the GlassFish team what they think about this issue and return here with the answer. Thanks, Peter 2010-01-30 20:28 keltezéssel, Major Péter írta: Hi, I've an application, which in its web.xml has a 404 page declared: error-page error-code404/error-code location/error/NotFound/location /error-page The filter-mapping for wicket that's why has the ERROR dispatcher. I created a NotFound page and mounted it via: mount(/error, PackageName.forClass(NotFound.class)); and the homepage is mounted via: mountBookmarkablePage(/homepage, HomePage.class); So, if the error page has a bookmarkablepagelink, which is pointing to the Homepage, and I request a wrong URL (e.g. 'asdf'), then the link is 'error/NotFound/homepage' instead of 'homepage'. But when I get the page with error/NotFound the link works just fine. I have a Quickstart app which demonstrates the problem, and it looks like with Jetty and GFv2 it works, but not with GFv3. Should I create a JIRA issue for this? I'm not sure that the web.xml-like errorpage is causing the error or the mount is the problem.. I also checked version-compatibilities, and both with 1.4.1 and 1.3.6 I got the same behaviour. Thanks, Peter - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Mounting problem with GlassFishv3
Nice catch Peter 2010/2/1 Major Péter majorpe...@sch.bme.hu Hi, the result is this ticket: https://issues.apache.org/jira/browse/WICKET-2712 See more details there. Regards, Peter 2010-02-01 16:42 keltezéssel, Riyad Kalla írta: Peter, keep us posted on what the GF team comes back with. Best, Riyad 2010/1/31 Major Péter majorpe...@sch.bme.hu Hi, I made some investigation today, and found out the followings: With GlassFishv2 when the bookmarkablepagelink calculates the url, finally it goes to ServletWebRequest#getRelativePathPrefixToWicketHandler() . The difference is on line #270: String forwardUrl = (String)httpRequest.getAttribute(javax.servlet.forward.servlet_path); With v2, the forwardUrl is /asdf (the wrong url again) With v3 the forwardUrl is null! It looks like there were some changes in the servlet API, namely: The HttpServletRequest's dispatcherType is now an enum instead of Integer (I don't know if this is relevant to the issue), and also, the HSR contains a HashMap called specialAttributes, which with GFv2 contains the forward attributes, but not with GFv3. After further tests, I checked the whole thing without wicket with just simple servlets, and this behaviour is appearing there too. Now I'm gonna go and ask the GlassFish team what they think about this issue and return here with the answer. Thanks, Peter 2010-01-30 20:28 keltezéssel, Major Péter írta: Hi, I've an application, which in its web.xml has a 404 page declared: error-page error-code404/error-code location/error/NotFound/location /error-page The filter-mapping for wicket that's why has the ERROR dispatcher. I created a NotFound page and mounted it via: mount(/error, PackageName.forClass(NotFound.class)); and the homepage is mounted via: mountBookmarkablePage(/homepage, HomePage.class); So, if the error page has a bookmarkablepagelink, which is pointing to the Homepage, and I request a wrong URL (e.g. 'asdf'), then the link is 'error/NotFound/homepage' instead of 'homepage'. But when I get the page with error/NotFound the link works just fine. I have a Quickstart app which demonstrates the problem, and it looks like with Jetty and GFv2 it works, but not with GFv3. Should I create a JIRA issue for this? I'm not sure that the web.xml-like errorpage is causing the error or the mount is the problem.. I also checked version-compatibilities, and both with 1.4.1 and 1.3.6 I got the same behaviour. Thanks, Peter - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Mounting problem with GlassFishv3
Hi, I made some investigation today, and found out the followings: With GlassFishv2 when the bookmarkablepagelink calculates the url, finally it goes to ServletWebRequest#getRelativePathPrefixToWicketHandler() . The difference is on line #270: String forwardUrl = (String)httpRequest.getAttribute(javax.servlet.forward.servlet_path); With v2, the forwardUrl is /asdf (the wrong url again) With v3 the forwardUrl is null! It looks like there were some changes in the servlet API, namely: The HttpServletRequest's dispatcherType is now an enum instead of Integer (I don't know if this is relevant to the issue), and also, the HSR contains a HashMap called specialAttributes, which with GFv2 contains the forward attributes, but not with GFv3. After further tests, I checked the whole thing without wicket with just simple servlets, and this behaviour is appearing there too. Now I'm gonna go and ask the GlassFish team what they think about this issue and return here with the answer. Thanks, Peter 2010-01-30 20:28 keltezéssel, Major Péter írta: Hi, I've an application, which in its web.xml has a 404 page declared: error-page error-code404/error-code location/error/NotFound/location /error-page The filter-mapping for wicket that's why has the ERROR dispatcher. I created a NotFound page and mounted it via: mount(/error, PackageName.forClass(NotFound.class)); and the homepage is mounted via: mountBookmarkablePage(/homepage, HomePage.class); So, if the error page has a bookmarkablepagelink, which is pointing to the Homepage, and I request a wrong URL (e.g. 'asdf'), then the link is 'error/NotFound/homepage' instead of 'homepage'. But when I get the page with error/NotFound the link works just fine. I have a Quickstart app which demonstrates the problem, and it looks like with Jetty and GFv2 it works, but not with GFv3. Should I create a JIRA issue for this? I'm not sure that the web.xml-like errorpage is causing the error or the mount is the problem.. I also checked version-compatibilities, and both with 1.4.1 and 1.3.6 I got the same behaviour. Thanks, Peter - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
