Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
https://github.com/sebfz1/wicket-jquery-ui/issues/359 On Thu, Jun 29, 2023 at 2:43 PM Shawn McKinney wrote: > > > On Jun 29, 2023, at 6:30 AM, Shawn McKinney wrote: > > > > > > Which begs the question. What happens when we use the wicket extensions > instead? > > > > (Don’t know but I’ll find out) > > The answer is it works as expected (with no warnings). > > The solution: use wicket extensions not googlecode. > > Very nice. > > — > Shawn > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
> On Jun 29, 2023, at 6:30 AM, Shawn McKinney wrote: > > > Which begs the question. What happens when we use the wicket extensions > instead? > > (Don’t know but I’ll find out) The answer is it works as expected (with no warnings). The solution: use wicket extensions not googlecode. Very nice. — Shawn - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
> On Jun 29, 2023, at 3:25 AM, Martin Grigorov wrote:
>
> I don't see such code at
> https://github.com/apache/wicket/blob/master/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/IndicatingAjaxButton.java
> Is your IndicatingAjaxButton.java part of some third party library ?
Yes it is. Sorry, should have pointed that out.
```
package com.googlecode.wicket.jquery.ui.form.button;
…
/**
* Provides a jQuery button based on the {@link AjaxButton}, with an ajax
indicator the time the {@link #onSubmit()} process.
*
* @since 6.0
* @author Sebastien Briquet - sebfz1
*/
public abstract class IndicatingAjaxButton extends AjaxButton
```
Which begs the question. What happens when we use the wicket extensions instead?
(Don’t know but I’ll find out)
—
Shawn
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
On Wed, Jun 28, 2023 at 4:08 PM Shawn McKinney wrote:
> Howdy,
>
> I’m a little embarrassed to be asking. It seems so basic, should know it
> already.
>
> But, I’ve already spent a fair amount of time digging with no answers.
>
> My usage of Ajax buttons generates this warning in the logs:
>
> ```
> WARN - 28 Jun 2023 07:35:56,704 - IndicatingAjaxButton -
> IndicatingAjaxButton should be applied on a 'button’ tag
> ```
>
> Looking at the wicket source, I see:
>
>
> ```
> public abstract class IndicatingAjaxButton extends AjaxButton
> ...
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> if (!"button".equalsIgnoreCase(tag.getName()))
> {
> LOG.warn("IndicatingAjaxButton should be applied on a 'button' tag”);
>
I don't see such code at
https://github.com/apache/wicket/blob/master/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/IndicatingAjaxButton.java
Is your IndicatingAjaxButton.java part of some third party library ?
> }
> }
> ```
>
> A head scratcher to me why that warning is in place.
>
> Obviously, there’s something I’m missing.
>
> Here’s my code. It all “seems" to work just fine (other than the warning).
> What am I doing wrong?
>
> ```java
> public Page1Form( String id )
> {
> …
>
> add( new IndicatingAjaxButton( "wspage1.button1" )
> {
> @Override protected void onSubmit( AjaxRequestTarget target )
> {
> logIt( target, “..." );
> }
> }
> ...
> ```
>
> ```html
>
> class="ui-button ui-widget ui-state-default ui-corner-all
> ui-button-text-only”
> wicket:id="wspage1.button1” value="wspage1.button1"
> name="wspage1.button1"/>
>
> ```
>
> I’m using the latest Wicket (v10). This behavior (log warnings) was
> present on earlier versions as well.
>
> Thanks
>
> —
> Shawn
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
> On Jun 28, 2023, at 8:23 AM, Ernesto Reinaldo Barreiro > wrote: > > I think your question has been correctly answered already. But, anyways, it > is pleasant to have questions in wicket's users list :-) Indeed. Handled REALLY quickly! Next time I won’t wait so long to ask my dumb question. No good deed goes unpunished? ;-) — Shawn - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
> On Jun 28, 2023, at 8:27 AM, Bas Gooren wrote: > > Hi Shawn, > > That’s more of a styling issue. > > uses the “value” attribute to render the button text. > > For a you’ll need to put the value inside the button tag: > value goes here > Ah yes, that’s it. Thank you Bas! For completeness, here is what it looks like now: ``` wspage1.button1 ``` Best — Shawn > Met vriendelijke groet, > Kind regards, > > Bas Gooren - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
This is true. Looking at the source code I don't why it needs to be a button :-) On Wed, Jun 28, 2023 at 4:34 PM Martin Grigorov wrote: > For me the real question is why is not supported too > ?! > IMO this is a bug! > > On Wed, Jun 28, 2023 at 4:28 PM Ernesto Reinaldo Barreiro < > reier...@gmail.com> wrote: > > > By the way... in almost all wicket applications I have worked with we > had a > > blocking div covering the page and activated/deactivated via global AJAX > > listeners. > > > > On Wed, Jun 28, 2023 at 4:24 PM Shawn McKinney > > wrote: > > > > > > > > > On Jun 28, 2023, at 8:11 AM, Bas Gooren wrote: > > > > > > > > Hi Shawn, > > > > > > > > The code basically checks if you apply the behavior to a > > > element. > > > > > > > > In other words: > > > > > > > > is considered an “invalid” element for this > > > behavior. > > > > > > > > is considered “valid”. > > > > > > > > > > Hello, > > > > > > As part of my scientific ‘poke and hope’ methodology;-), I had tried > > that. > > > > > > Now, the warning has disappeared. But, the button renders on the page > as > > a > > > tiny dot, that actually works. I doubt my users would be a big fan of > it > > > (tiny buttons), although their eye doctors might? > > > > > > Anyway, all kidding aside, here’s what the html looks like: > > > > > > ``` > > > > >wicket:id="wspage1.button1" > > > value="wspage1.button1" name="wspage1.button1”/> > > > ``` > > > > > > Best > > > > > > — > > > Shawn > > > > > > > Met vriendelijke groet, > > > > Kind regards, > > > > > > > > Bas Gooren > > > > > > > > > - > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > > > > > -- > > Regards - Ernesto Reinaldo Barreiro > > > -- Regards - Ernesto Reinaldo Barreiro
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
I mean something like this:
;Wicket.Event.subscribe('/ajax/call/beforeSend', function(jqEvent,
attributes, jqXHR, errorThrown, textStatus) {
pageLoadingFrame("show");
});
Wicket.Event.subscribe('/ajax/call/failure', function(jqEvent, attributes,
jqXHR, errorThrown, textStatus) {
pageLoadingFrame("hide");
});
This will prevent your users from clicking on components that will no
longer be there when the current AJAX request finishes.
On Wed, Jun 28, 2023 at 4:24 PM Shawn McKinney wrote:
>
> > On Jun 28, 2023, at 8:11 AM, Bas Gooren wrote:
> >
> > Hi Shawn,
> >
> > The code basically checks if you apply the behavior to a
> element.
> >
> > In other words:
> >
> > is considered an “invalid” element for this
> behavior.
> >
> > is considered “valid”.
> >
>
> Hello,
>
> As part of my scientific ‘poke and hope’ methodology;-), I had tried that.
>
> Now, the warning has disappeared. But, the button renders on the page as a
> tiny dot, that actually works. I doubt my users would be a big fan of it
> (tiny buttons), although their eye doctors might?
>
> Anyway, all kidding aside, here’s what the html looks like:
>
> ```
> wicket:id="wspage1.button1"
> value="wspage1.button1" name="wspage1.button1”/>
> ```
>
> Best
>
> —
> Shawn
>
> > Met vriendelijke groet,
> > Kind regards,
> >
> > Bas Gooren
>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>
--
Regards - Ernesto Reinaldo Barreiro
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
For me the real question is why is not supported too ?! IMO this is a bug! On Wed, Jun 28, 2023 at 4:28 PM Ernesto Reinaldo Barreiro < reier...@gmail.com> wrote: > By the way... in almost all wicket applications I have worked with we had a > blocking div covering the page and activated/deactivated via global AJAX > listeners. > > On Wed, Jun 28, 2023 at 4:24 PM Shawn McKinney > wrote: > > > > > > On Jun 28, 2023, at 8:11 AM, Bas Gooren wrote: > > > > > > Hi Shawn, > > > > > > The code basically checks if you apply the behavior to a > > element. > > > > > > In other words: > > > > > > is considered an “invalid” element for this > > behavior. > > > > > > is considered “valid”. > > > > > > > Hello, > > > > As part of my scientific ‘poke and hope’ methodology;-), I had tried > that. > > > > Now, the warning has disappeared. But, the button renders on the page as > a > > tiny dot, that actually works. I doubt my users would be a big fan of it > > (tiny buttons), although their eye doctors might? > > > > Anyway, all kidding aside, here’s what the html looks like: > > > > ``` > > >wicket:id="wspage1.button1" > > value="wspage1.button1" name="wspage1.button1”/> > > ``` > > > > Best > > > > — > > Shawn > > > > > Met vriendelijke groet, > > > Kind regards, > > > > > > Bas Gooren > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > -- > Regards - Ernesto Reinaldo Barreiro >
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
By the way... in almost all wicket applications I have worked with we had a blocking div covering the page and activated/deactivated via global AJAX listeners. On Wed, Jun 28, 2023 at 4:24 PM Shawn McKinney wrote: > > > On Jun 28, 2023, at 8:11 AM, Bas Gooren wrote: > > > > Hi Shawn, > > > > The code basically checks if you apply the behavior to a > element. > > > > In other words: > > > > is considered an “invalid” element for this > behavior. > > > > is considered “valid”. > > > > Hello, > > As part of my scientific ‘poke and hope’ methodology;-), I had tried that. > > Now, the warning has disappeared. But, the button renders on the page as a > tiny dot, that actually works. I doubt my users would be a big fan of it > (tiny buttons), although their eye doctors might? > > Anyway, all kidding aside, here’s what the html looks like: > > ``` > wicket:id="wspage1.button1" > value="wspage1.button1" name="wspage1.button1”/> > ``` > > Best > > — > Shawn > > > Met vriendelijke groet, > > Kind regards, > > > > Bas Gooren > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- Regards - Ernesto Reinaldo Barreiro
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
Hi Shawn, That’s more of a styling issue. uses the “value” attribute to render the button text. For a you’ll need to put the value inside the button tag: value goes here Met vriendelijke groet, Kind regards, Bas Gooren Op 28 juni 2023 bij 15:24:44, Shawn McKinney (smckin...@symas.com) schreef: > On Jun 28, 2023, at 8:11 AM, Bas Gooren wrote: > > Hi Shawn, > > The code basically checks if you apply the behavior to a element. > > In other words: > > is considered an “invalid” element for this behavior. > > is considered “valid”. > Hello, As part of my scientific ‘poke and hope’ methodology;-), I had tried that. Now, the warning has disappeared. But, the button renders on the page as a tiny dot, that actually works. I doubt my users would be a big fan of it (tiny buttons), although their eye doctors might? Anyway, all kidding aside, here’s what the html looks like: ```
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
You need to put something inside the button for it not to be tiny On Wed, Jun 28, 2023 at 4:24 PM Shawn McKinney wrote: > > > On Jun 28, 2023, at 8:11 AM, Bas Gooren wrote: > > > > Hi Shawn, > > > > The code basically checks if you apply the behavior to a > element. > > > > In other words: > > > > is considered an “invalid” element for this > behavior. > > > > is considered “valid”. > > > > Hello, > > As part of my scientific ‘poke and hope’ methodology;-), I had tried that. > > Now, the warning has disappeared. But, the button renders on the page as a > tiny dot, that actually works. I doubt my users would be a big fan of it > (tiny buttons), although their eye doctors might? > > Anyway, all kidding aside, here’s what the html looks like: > > ``` > wicket:id="wspage1.button1" > value="wspage1.button1" name="wspage1.button1”/> > ``` > > Best > > — > Shawn > > > Met vriendelijke groet, > > Kind regards, > > > > Bas Gooren > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- Regards - Ernesto Reinaldo Barreiro
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
> On Jun 28, 2023, at 8:11 AM, Bas Gooren wrote: > > Hi Shawn, > > The code basically checks if you apply the behavior to a element. > > In other words: > > is considered an “invalid” element for this behavior. > > is considered “valid”. > Hello, As part of my scientific ‘poke and hope’ methodology;-), I had tried that. Now, the warning has disappeared. But, the button renders on the page as a tiny dot, that actually works. I doubt my users would be a big fan of it (tiny buttons), although their eye doctors might? Anyway, all kidding aside, here’s what the html looks like: ```
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
I think your question has been correctly answered already. But, anyways, it
is pleasant to have questions in wicket's users list :-)
On Wed, Jun 28, 2023 at 4:08 PM Shawn McKinney wrote:
> Howdy,
>
> I’m a little embarrassed to be asking. It seems so basic, should know it
> already.
>
> But, I’ve already spent a fair amount of time digging with no answers.
>
> My usage of Ajax buttons generates this warning in the logs:
>
> ```
> WARN - 28 Jun 2023 07:35:56,704 - IndicatingAjaxButton -
> IndicatingAjaxButton should be applied on a 'button’ tag
> ```
>
> Looking at the wicket source, I see:
>
>
> ```
> public abstract class IndicatingAjaxButton extends AjaxButton
> ...
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> if (!"button".equalsIgnoreCase(tag.getName()))
> {
> LOG.warn("IndicatingAjaxButton should be applied on a 'button' tag”);
> }
> }
> ```
>
> A head scratcher to me why that warning is in place.
>
> Obviously, there’s something I’m missing.
>
> Here’s my code. It all “seems" to work just fine (other than the warning).
> What am I doing wrong?
>
> ```java
> public Page1Form( String id )
> {
> …
>
> add( new IndicatingAjaxButton( "wspage1.button1" )
> {
> @Override protected void onSubmit( AjaxRequestTarget target )
> {
> logIt( target, “..." );
> }
> }
> ...
> ```
>
> ```html
>
> class="ui-button ui-widget ui-state-default ui-corner-all
> ui-button-text-only”
> wicket:id="wspage1.button1” value="wspage1.button1"
> name="wspage1.button1"/>
>
> ```
>
> I’m using the latest Wicket (v10). This behavior (log warnings) was
> present on earlier versions as well.
>
> Thanks
>
> —
> Shawn
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>
--
Regards - Ernesto Reinaldo Barreiro
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
Hi Shawn,
look at your markup and you will see, that the tag is not a
-tag, it's an -tag. If you change the markup the warning
disappears.
Dirk
Am 28.06.2023 um 15:07 schrieb Shawn McKinney:
Howdy,
I’m a little embarrassed to be asking. It seems so basic, should know it
already.
But, I’ve already spent a fair amount of time digging with no answers.
My usage of Ajax buttons generates this warning in the logs:
```
WARN - 28 Jun 2023 07:35:56,704 - IndicatingAjaxButton -
IndicatingAjaxButton should be applied on a 'button’ tag
```
Looking at the wicket source, I see:
```
public abstract class IndicatingAjaxButton extends AjaxButton
...
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
if (!"button".equalsIgnoreCase(tag.getName()))
{
LOG.warn("IndicatingAjaxButton should be applied on a 'button' tag”);
}
}
```
A head scratcher to me why that warning is in place.
Obviously, there’s something I’m missing.
Here’s my code. It all “seems" to work just fine (other than the warning). What
am I doing wrong?
```java
public Page1Form( String id )
{
…
add( new IndicatingAjaxButton( "wspage1.button1" )
{
@Override protected void onSubmit( AjaxRequestTarget target )
{
logIt( target, “..." );
}
}
...
```
```html
```
I’m using the latest Wicket (v10). This behavior (log warnings) was present on
earlier versions as well.
Thanks
—
Shawn
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
Re: Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
Hi Shawn,
The code basically checks if you apply the behavior to a element.
In other words:
is considered an “invalid” element for this behavior.
is considered “valid”.
Met vriendelijke groet,
Kind regards,
Bas Gooren
Op 28 juni 2023 bij 15:08:52, Shawn McKinney (smckin...@symas.com) schreef:
Howdy,
I’m a little embarrassed to be asking. It seems so basic, should know it
already.
But, I’ve already spent a fair amount of time digging with no answers.
My usage of Ajax buttons generates this warning in the logs:
```
WARN - 28 Jun 2023 07:35:56,704 - IndicatingAjaxButton -
IndicatingAjaxButton should be applied on a 'button’ tag
```
Looking at the wicket source, I see:
```
public abstract class IndicatingAjaxButton extends AjaxButton
...
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
if (!"button".equalsIgnoreCase(tag.getName()))
{
LOG.warn("IndicatingAjaxButton should be applied on a 'button' tag”);
}
}
```
A head scratcher to me why that warning is in place.
Obviously, there’s something I’m missing.
Here’s my code. It all “seems" to work just fine (other than the warning).
What am I doing wrong?
```java
public Page1Form( String id )
{
…
add( new IndicatingAjaxButton( "wspage1.button1" )
{
@Override protected void onSubmit( AjaxRequestTarget target )
{
logIt( target, “..." );
}
}
...
```
```html
```
I’m using the latest Wicket (v10). This behavior (log warnings) was present
on earlier versions as well.
Thanks
—
Shawn
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
Question about log warning: "IndicatingAjaxButton should be applied on a 'button' tag"
Howdy,
I’m a little embarrassed to be asking. It seems so basic, should know it
already.
But, I’ve already spent a fair amount of time digging with no answers.
My usage of Ajax buttons generates this warning in the logs:
```
WARN - 28 Jun 2023 07:35:56,704 - IndicatingAjaxButton -
IndicatingAjaxButton should be applied on a 'button’ tag
```
Looking at the wicket source, I see:
```
public abstract class IndicatingAjaxButton extends AjaxButton
...
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
if (!"button".equalsIgnoreCase(tag.getName()))
{
LOG.warn("IndicatingAjaxButton should be applied on a 'button' tag”);
}
}
```
A head scratcher to me why that warning is in place.
Obviously, there’s something I’m missing.
Here’s my code. It all “seems" to work just fine (other than the warning). What
am I doing wrong?
```java
public Page1Form( String id )
{
…
add( new IndicatingAjaxButton( "wspage1.button1" )
{
@Override protected void onSubmit( AjaxRequestTarget target )
{
logIt( target, “..." );
}
}
...
```
```html
```
I’m using the latest Wicket (v10). This behavior (log warnings) was present on
earlier versions as well.
Thanks
—
Shawn
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
