Re: Wicket7: MediaComponent and Source classes

2015-07-14 Thread Sebastien
I also did changes in Wicket jQuery UI, all seems to be ok too, I will test further the coming days... On Tue, Jul 14, 2015 at 5:36 PM, Martin Grigorov mgrigo...@apache.org wrote: I have made the changes in Wicket Bootstrap and all seems to be fine! Martin Grigorov Freelancer. Available for

Re: Wicket7: MediaComponent and Source classes

2015-07-14 Thread Martin Grigorov
I have made the changes in Wicket Bootstrap and all seems to be fine! Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Jul 10, 2015 at 10:53 AM, Sebastien seb...@gmail.com wrote: Hi Martin, On Fri, Jul 10, 2015 at 8:35 AM,

Re: Wicket7: MediaComponent and Source classes

2015-07-10 Thread Martin Grigorov
On Fri, Jul 10, 2015 at 1:27 AM, Sven Meier s...@meiers.net wrote: Yes, an overriden method with ART parameter will be something to be migrated :/. We can try though! I've greped the Wicket's souce code once again, and only on*()- and respond()-methods kept their ART. All other 'active'

Re: Wicket7: MediaComponent and Source classes

2015-07-10 Thread Sebastien
Hi Martin, On Fri, Jul 10, 2015 at 8:35 AM, Martin Grigorov mgrigo...@apache.org wrote: On Fri, Jul 10, 2015 at 1:27 AM, Sven Meier s...@meiers.net wrote: Yes, an overriden method with ART parameter will be something to be migrated :/. We can try though! I've greped the Wicket's

Re: Wicket7: MediaComponent and Source classes

2015-07-10 Thread Sebastien
Hi Sven, On Fri, Jul 10, 2015 at 12:27 AM, Sven Meier s...@meiers.net wrote: Yes, an overriden method with ART parameter will be something to be migrated :/. We can try though! I've greped the Wicket's souce code once again, and only on*()- and respond()-methods kept their ART. All

Re: Wicket7: MediaComponent and Source classes

2015-07-09 Thread Martin Grigorov
Hi Sven, On Thu, Jul 9, 2015 at 4:31 PM, Sven Meier s...@meiers.net wrote: Hi, I've just changed all relevant places in Wicket from AjaxRequestTarget to IPartialPageRequestHandler. I don't think this change is too disruptive: - client code can still call the existing methods with an ART,

Re: Wicket7: MediaComponent and Source classes

2015-07-09 Thread Sven Meier
Hi Martin, This is what I meant as too disruptive change. If we change the type of the parameter from ART to IPPRH then every application that uses ModalWindow will have to fix the compilation error. but ART *is* an IPPRH, so there will be no compilation error. If we broaden the API from

Re: Wicket7: MediaComponent and Source classes

2015-07-09 Thread Sven Meier
Ok. you're partially right :/ #close(AjaxRequestTarget) to #close(IPartialPageRequestHandler) Every application has to be recompiled as the method argument type has changed. But there won't be any compilation error. But for a migration to Wicket 7 each application will have to be recompiled

Re: Wicket7: MediaComponent and Source classes

2015-07-09 Thread Martin Grigorov
Hi Sebastien, On Wed, Jul 8, 2015 at 10:04 PM, Sebastien seb...@gmail.com wrote: Hi, Sorry, little bit late on the topic... On Fri, Jul 3, 2015 at 7:38 AM, Martin Grigorov mgrigo...@apache.org wrote: HI Maxim, This will lead to a big API break. If we change this signature then we will

Re: Wicket7: MediaComponent and Source classes

2015-07-09 Thread Sven Meier
Hi, I've just changed all relevant places in Wicket from AjaxRequestTarget to IPartialPageRequestHandler. I don't think this change is too disruptive: - client code can still call the existing methods with an ART, e.g. modalWindow.close(ajaxRequestTarget) - all places needing an ART

Re: Wicket7: MediaComponent and Source classes

2015-07-09 Thread Martin Grigorov
On Thu, Jul 9, 2015 at 9:23 PM, Sven Meier s...@meiers.net wrote: Ok. you're partially right :/ The compilation error would happen if an application extends ModalWindow and overrides #close(AjaxRequestTarget) method to do some extra tasks. I have such code for Wicket Bootstrap's Modal

Re: Wicket7: MediaComponent and Source classes

2015-07-09 Thread Sven Meier
Yes, an overriden method with ART parameter will be something to be migrated :/. We can try though! I've greped the Wicket's souce code once again, and only on*()- and respond()-methods kept their ART. All other 'active' methods (e.g. ModalWindow#close()) take a IPartialPageRequestHandler

Re: Wicket7: MediaComponent and Source classes

2015-07-08 Thread Sven Meier
Hi, that change seems to have a hight impact - sorry, I didn't think of these implications. But #add(Component...) is part of IPartialPageRequestHandler so adding a component via websocket will not trigger IListener#onBeforeRespond WebSockerRequestHandler#addListener() was a noop

Re: Wicket7: MediaComponent and Source classes

2015-07-08 Thread Sebastien
Hi, Sorry, little bit late on the topic... On Fri, Jul 3, 2015 at 7:38 AM, Martin Grigorov mgrigo...@apache.org wrote: HI Maxim, This will lead to a big API break. If we change this signature then we will have to change many more to keep it consistent, and this will lead to a lot of work

Re: Wicket7: MediaComponent and Source classes

2015-07-08 Thread Sebastien
Hi Sven, But it seems in wicket-jquery-ui there are more methods of this kind? True, about 85 methods (taking an ART without starting with on-prefix). In these, I should identify the ones that should be changed (like #open, #close, #show, #hide, #refresh, etc), the others, plus 2 calls to

Re: Wicket7: MediaComponent and Source classes

2015-07-06 Thread Maxim Solodovnik
Just have tried :) hopefully it'll help :) On Sun, Jul 5, 2015 at 1:40 PM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: May it helps when you add me to your contact list. kind regards Tobias Am 05.07.2015 um 07:40 schrieb Maxim Solodovnik solomax...@gmail.com: Hello

Re: Wicket7: MediaComponent and Source classes

2015-07-05 Thread Tobias Soloschenko
May it helps when you add me to your contact list. kind regards Tobias Am 05.07.2015 um 07:40 schrieb Maxim Solodovnik solomax...@gmail.com: Hello Tobias, Everything seems to work as expected! sorry for the late response, your emails are still going into Spam :((( On Fri, Jul 3,

Re: Wicket7: MediaComponent and Source classes

2015-07-04 Thread Maxim Solodovnik
Hello Tobias, Everything seems to work as expected! sorry for the late response, your emails are still going into Spam :((( On Fri, Jul 3, 2015 at 6:34 PM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: @Maxim: Is there anything left to be done within the media components?

Re: Wicket7: MediaComponent and Source classes

2015-07-03 Thread Tobias Soloschenko
@Maxim: Is there anything left to be done within the media components? Otherwise I am going to vote +1 kind regards Tobias Am 03.07.2015 um 07:43 schrieb Maxim Solodovnik solomax...@gmail.com: OK, will try Thanks On Fri, Jul 3, 2015 at 11:38 AM, Martin Grigorov mgrigo...@apache.org

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Tobias Soloschenko
Hi Maxim, no problem I am going to add the getter this evening. Thank you for your suggestions! :-) Maybe the SNAPSHOT isn't refreshed because of the downtime of the buildbot server. However the build was triggered already. kind regards Tobias Am 02.07.2015 um 08:45 schrieb Maxim

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
Thanks a lot for the changes Tobias, Unfortunately I'm unable to test it due to latest 7.0.0-SNAPSHOT seems doesn't contain it :( And one more question: I would like to be able to modify PageParameters passed to source, maybe it would be possible to add public getter for it? Thanks in advance

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Martin Grigorov
There is a new build. The snapshots should be updated. Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Jul 2, 2015 at 10:03 AM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: Hi Maxim, no problem I am going to

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
Additionally it looks like WebSocketRequestHandler can not be used as AjaxRequestTarget any longer Previously it was possible to use WebSocketRequestHandler to push updated component . On Thu, Jul 2, 2015 at 2:42 PM, Maxim Solodovnik solomax...@gmail.com wrote: Thanks a lot Tobias! On

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
Thanks a lot Tobias! On Thu, Jul 2, 2015 at 1:03 PM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: Hi Maxim, no problem I am going to add the getter this evening. Thank you for your suggestions! :-) Maybe the SNAPSHOT isn't refreshed because of the downtime of the buildbot

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
Done: https://github.com/sebfz1/wicket-jquery-ui/issues/177 Sorry, forgot about Sebastians vacation :( On Thu, Jul 2, 2015 at 5:23 PM, Martin Grigorov mgrigo...@apache.org wrote: @Maxim: Please create an issue at Wicket jQuery UI github. Sebastien is on vacation. I can do it but first I need a

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
Thanks for the clarifications Martin This seems to be caching issue on my side Could you please answer additional question regarding ListView It seems to be impossible in latest snapshot to create ListViewA(list, new List? extends A()) It was working as expected in M6 and previous versions

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Martin Grigorov
Please see http://markmail.org/message/ji4nixgscvnbgi7z Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Jul 2, 2015 at 11:41 AM, Maxim Solodovnik solomax...@gmail.com wrote: Thanks for the clarifications Martin This seems

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Martin Grigorov
Yes, another minor cleanup: there is now https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPartialPageRequestHandler.java A base interface for Ajax and WebSocket. Martin Grigorov Freelancer. Available for hire! Wicket Training and

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
@Sebastian could you please modify AbstractDialog.open method to be public final void open(IPartialPageRequestHandler target) instead of public final void open(AjaxRequestTarget target) Thanks in advance! On Thu, Jul 2, 2015 at 2:58 PM, Martin Grigorov mgrigo...@apache.org wrote: Yes,

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Ernesto Reinaldo Barreiro
@Tobias, OT: For some obscure reason your massages always goo into my Span account at gmail... On Thu, Jul 2, 2015 at 9:03 AM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: Hi Maxim, no problem I am going to add the getter this evening. Thank you for your suggestions! :-)

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Martin Grigorov
@Maxim: Please create an issue at Wicket jQuery UI github. Sebastien is on vacation. I can do it but first I need a good reason for the change :-) Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Jul 2, 2015 at 12:33 PM, Maxim

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
Thanks a million! Could you please publish SNAPSHOT so I can test it? On Thu, Jul 2, 2015 at 6:11 PM, Martin Grigorov mgrigo...@apache.org wrote: The change is rather big: https://github.com/sebfz1/wicket-jquery-ui/commit/e94f89d8f07f2b1af2b327a4aaec5ddd4b1400af I guess many other methods

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Tobias Soloschenko
Hi, I send a request to the google forum and they answered that I have to bring enought users to unmark my Mails as Spam. So if all who receiving my mails please click at this is not a Spam Mail kind regards Tobias Am 02.07.2015 um 11:25 schrieb Ernesto Reinaldo Barreiro

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Martin Grigorov
The change is rather big: https://github.com/sebfz1/wicket-jquery-ui/commit/e94f89d8f07f2b1af2b327a4aaec5ddd4b1400af I guess many other methods will need to be changed too if one needs to use them with WebSocket. The improvement in the Wicket API looked so innocent ... Martin Grigorov Freelancer.

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Ernesto Reinaldo Barreiro
Doing it all the time :-) On Thu, Jul 2, 2015 at 3:56 PM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: Hi, I send a request to the google forum and they answered that I have to bring enought users to unmark my Mails as Spam. So if all who receiving my mails please click at

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Tobias Soloschenko
Hi, just wanted to mention that there are getter / setter for the PageParameters, now. kind regards Tobias Am 02.07.15 um 16:21 schrieb Maxim Solodovnik: I also doing this regularly :) WBR, Maxim (from mobile, sorry for the typos) On Jul 2, 2015 8:09 PM, Ernesto Reinaldo Barreiro

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
I also doing this regularly :) WBR, Maxim (from mobile, sorry for the typos) On Jul 2, 2015 8:09 PM, Ernesto Reinaldo Barreiro reier...@gmail.com wrote: Doing it all the time :-) On Thu, Jul 2, 2015 at 3:56 PM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: Hi, I send a

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
Hello Martin, I guess following method need to be additionally updated: org.apache.wicket.ajax.AbstractAjaxTimerBehavior.onTimer On Thu, Jul 2, 2015 at 6:11 PM, Martin Grigorov mgrigo...@apache.org wrote: The change is rather big:

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Maxim Solodovnik
OK, will try Thanks On Fri, Jul 3, 2015 at 11:38 AM, Martin Grigorov mgrigo...@apache.org wrote: HI Maxim, This will lead to a big API break. If we change this signature then we will have to change many more to keep it consistent, and this will lead to a lot of work for the application

Re: Wicket7: MediaComponent and Source classes

2015-07-02 Thread Martin Grigorov
HI Maxim, This will lead to a big API break. If we change this signature then we will have to change many more to keep it consistent, and this will lead to a lot of work for the application developers to change AjaxRequestTarget with IPartialPageRequestHandler. We may need to make this change

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Tobias Soloschenko
Hi Maxim, hope the change is like you wanted it to be: https://github.com/apache/wicket/commit/e20bfa738aa64f35b668f05866e0c0b7ca71c1f4 But again: The PackageResourceReference is best practice, because you also can use readBuffered(false) of it - with this option the resource is streamed

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Martin Grigorov
Hi, On Mon, Jun 29, 2015 at 6:41 PM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: Hi Maxim, hope the change is like you wanted it to be: https://github.com/apache/wicket/commit/e20bfa738aa64f35b668f05866e0c0b7ca71c1f4 But again: The PackageResourceReference is best

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread andrea del bene
I could do it if I knew what to do. Who is maintaining the examples site (in addition to you Martin)? Everything is possible. All I need is longer day. 24 hours are not enough... Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Maxim Solodovnik
Thanks Martin :) will look through sources :) can you please tell me why PackageResourceReference is being used in MediaComponent and not ResourceReference? Or maybe Tobias can answer this question? On Mon, Jun 29, 2015 at 2:00 PM, Martin Grigorov mgrigo...@apache.org wrote: Everything is

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Maxim Solodovnik
Is it possible update http://www.wicket-library.com/ to have wicket7 examples as well? I believe this might be very useful :) On Mon, Jun 29, 2015 at 1:49 PM, andrea del bene an.delb...@gmail.com wrote: Hi, in wicket-examples take a look at the project in org.apache.wicket.examples.media

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Maxim Solodovnik
sorry, most probably missed that email Thanks! On Mon, Jun 29, 2015 at 2:14 PM, Martin Grigorov mgrigo...@apache.org wrote: Tobias already explained that it was an oversight and he is going to improve it tonight. Martin Grigorov Freelancer. Available for hire! Wicket Training and

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Tobias Soloschenko
Hi Maxim, there are some examples in the wicket-examples project, which will be released on http://www.wicket-library.com when wicket 7 reaches the final state. You can have a look at the examples on github for now:

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Martin Grigorov
Juergen Donnerstag owns it. He gave me the credentials several years ago. So far it is as simple as deploy the new version and restart Tomcat 6.x. I've tried before to use Tomcat 7.x but it seems there are some (cron?!) scripts by the hosting provider which start Tomcat 6.x no matter what. I'll

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Martin Grigorov
For some reason Tobias' mails are marked as SPAM by GMail... Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Jun 29, 2015 at 11:15 AM, Maxim Solodovnik solomax...@gmail.com wrote: sorry, most probably missed that email

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Tobias Soloschenko
Hi, I answered already: http://apache-wicket.1842946.n4.nabble.com/Wicket7-MediaComponent-and-Source-classes-tp4671386p4671387.html kind regards Tobias P.S.: Maybe it went into the SPAM-Filter. 2015-06-29 10:10 GMT+02:00 Maxim Solodovnik solomax...@gmail.com: Thanks Martin :) will look

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Martin Grigorov
Tobias already explained that it was an oversight and he is going to improve it tonight. Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Jun 29, 2015 at 11:10 AM, Maxim Solodovnik solomax...@gmail.com wrote: Thanks Martin :)

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread andrea del bene
Hi, in wicket-examples take a look at the project in org.apache.wicket.examples.media Andrea. On 29/06/2015 06:47, Maxim Solodovnik wrote: Hello All, Recently I have upgraded to Wicket+wicketstuff 7.0.0-M6 and found lots of improvements: 1) AbstractResource is now supports content-range

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Martin Grigorov
Everything is possible. All I need is longer day. 24 hours are not enough... Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Jun 29, 2015 at 10:53 AM, Maxim Solodovnik solomax...@gmail.com wrote: Is it possible update

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Maxim Solodovnik
Thanks a lot! It was gmail SPAM filter :((( will do migration and examine examples On Mon, Jun 29, 2015 at 2:18 PM, Martin Grigorov mgrigo...@apache.org wrote: For some reason Tobias' mails are marked as SPAM by GMail... Martin Grigorov Freelancer. Available for hire! Wicket Training and

Re: Wicket7: MediaComponent and Source classes

2015-06-29 Thread Maxim Solodovnik
We already using external storage :) This is why this issue is arise :) Thanks for the fix! I asked my only question on GitHub :) On Tue, Jun 30, 2015 at 1:59 AM, Martin Grigorov mgrigo...@apache.org wrote: Hi, On Mon, Jun 29, 2015 at 6:41 PM, Tobias Soloschenko

Wicket7: MediaComponent and Source classes

2015-06-28 Thread Maxim Solodovnik
Hello All, Recently I have upgraded to Wicket+wicketstuff 7.0.0-M6 and found lots of improvements: 1) AbstractResource is now supports content-range and accept-range which is great! I'll remove my custom code for this :) 2) HTML5 Video is supported by wicket itself (was removed from wicketstuff)