Wicketstuff-core configuration

2010-07-02 Thread Martin Grigorov
Hi,

This morning I saw that I broke wicketstuff-core for a second time with
my changes in sub-projects. Apologies !

wicket-stuff trunk #5439: [mocleiri] fixes the org.eclipse.jetty
dependency in push-parent/push-examples that was breaking the build. The
${jetty.version} property redefined in the push-examples pom.xml clashed
with the parent jetty plugin dependency since there are no
org.mortbay.jetty artifacts for the 7.x.y series. The fix is to rename
the property to org.eclipse.jetty and update the dependency versions.
This approach was already taken with the wicket-html5-parent/pom.xml so
the second part of the fix is to push up the definition of the property
into the wicketstuff-core/pom.xml

There is a problem in the current parent pom configuration, though.
The parent pom configures the plugins themselves, not the
pluginDependencies. This makes me some troubles because now I cannot
add jetty-maven-plugin (this is ver. 7.x) to the projects I'm working
on. The fix above fixes only the build but later when I start to use
mvn jetty:run it still uses maven-jetty-plugin (ver 6.x) and fails
with class loader problems.
Trying with the full name fails too (mvn
org.mortbay.jetty:jetty-maven-plugin:run). This now uses the proper
ver.7 of the plugin but again there are mix of ver.6 and ver.7 jars in
the plugin classpath and again class loading problems.

If there are no objections or solution to this problem then I'm going to
move the plugin configuration to pluginManagement. If there are not
too many plugins then I'll fix them all, otherwise just the ones I'm
using in my projects.

Cheers
martin-g


-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Wicketstuff-core configuration

2010-07-02 Thread nino martinez wael
Just go ahead, if it does not breake anything.. :)

2010/7/2 Martin Grigorov mcgreg...@e-card.bg

 Hi,

 This morning I saw that I broke wicketstuff-core for a second time with
 my changes in sub-projects. Apologies !

 wicket-stuff trunk #5439: [mocleiri] fixes the org.eclipse.jetty
 dependency in push-parent/push-examples that was breaking the build. The
 ${jetty.version} property redefined in the push-examples pom.xml clashed
 with the parent jetty plugin dependency since there are no
 org.mortbay.jetty artifacts for the 7.x.y series. The fix is to rename
 the property to org.eclipse.jetty and update the dependency versions.
 This approach was already taken with the wicket-html5-parent/pom.xml so
 the second part of the fix is to push up the definition of the property
 into the wicketstuff-core/pom.xml

 There is a problem in the current parent pom configuration, though.
 The parent pom configures the plugins themselves, not the
 pluginDependencies. This makes me some troubles because now I cannot
 add jetty-maven-plugin (this is ver. 7.x) to the projects I'm working
 on. The fix above fixes only the build but later when I start to use
 mvn jetty:run it still uses maven-jetty-plugin (ver 6.x) and fails
 with class loader problems.
 Trying with the full name fails too (mvn
 org.mortbay.jetty:jetty-maven-plugin:run). This now uses the proper
 ver.7 of the plugin but again there are mix of ver.6 and ver.7 jars in
 the plugin classpath and again class loading problems.

 If there are no objections or solution to this problem then I'm going to
 move the plugin configuration to pluginManagement. If there are not
 too many plugins then I'll fix them all, otherwise just the ones I'm
 using in my projects.

 Cheers
 martin-g


 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org