BTW,
I just wanted to say how much I love Wicket!
(Which you can tell by the minor issues that I'm mailing about on this
list, which underlines the fact that I can't find any major ones...) :-)
The resulting code is so short and so clean, Wicket it is so easy to
work with, and everything
On 11/5/07, Sebastiaan van Erk [EMAIL PROTECTED] wrote:
BTW,
I just wanted to say how much I love Wicket!
As long as you don't give all your Love to Wicket,
you have to keep some for Morena! (and her beautiful wicket site
http://www.denherdervarga.com/ )
johan
Johan Compagner wrote:
On 11/5/07, Sebastiaan van Erk [EMAIL PROTECTED] wrote:
BTW,
I just wanted to say how much I love Wicket!
As long as you don't give all your Love to Wicket,
you have to keep some for Morena! (and her beautiful wicket site
http://www.denherdervarga.com/ )
Don't worry
thats better.
I think that throw exceptions on missing resources shouldn't happen in
deployment mode anyway i think
there is no much use for it a good log statement in the server log should be
enough.
i dont find it very dangerous that it shows the body IF it has a body
because that you see it on
Johan Compagner wrote:
thats better.
I think that throw exceptions on missing resources shouldn't happen in
deployment mode anyway i think
there is no much use for it a good log statement in the server log should be
enough.
i dont find it very dangerous that it shows the body IF it has a body
Hi,
I was wondering if it is possible to configure wicket to make
wicket:message output the key in braces when the key is not found (at
least in development mode), because that would make it a lot easier to
spot missing labels...
That is, what I'd like to do is:
wicket:message
im afraid we cannot do that. because the contract is that when a
resource is not found we output the body, which is supposed to be the
default text.
to do what you want we need to change that contract. i am not opposed
to that per se, but there needs to be a discussion followed by a vote.
-igor
Sebastiaan van Erk wrote:
I was wondering if it is possible to configure wicket to make
wicket:message output the key in braces when the key is not found (at
least in development mode), because that would make it a lot easier to
spot missing labels...
That is, what I'd like to do is:
Thanks for the reply, I was afraid I was going to get this answer. :-) I
can understand it though.
Igor Vaynberg wrote:
im afraid we cannot do that. because the contract is that when a
resource is not found we output the body, which is supposed to be the
default text.
Am I pushing my luck
Mmmm. I must say I agree with this. I'd actually prefer it to throw an
exception. ;-)
I'm surprised we don't do this already!
I would have expected that if
IResourceSettings#getThrowExceptionOnMissingResource returns true, an
exception would be thrown here as well. I think we should fix it.
then you are violating the contract of wicket:message. if we do this
then there is little point to allowing body inside wicket:message
-igor
On 11/3/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
Mmmm. I must say I agree with this. I'd actually prefer it to throw an
exception. ;-)
I'm
Btw, I would mind a decision about this in this weekend, as I'm
finishing the chapter on localization right now :-)
FWIW, I don't like the silent failure we have now, and believe that
using the body as a default isn't very helpful; e.g. if you have the
default body the same as what you intended
Eelco Hillenius wrote:
Btw, I would mind a decision about this in this weekend, as I'm
finishing the chapter on localization right now :-)
FWIW, I don't like the silent failure we have now, and believe that
using the body as a default isn't very helpful; e.g. if you have the
default body the
The easiest solution would be this:
Index:
/Users/eelcohillenius/Documents/workspace_wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/WicketMessageResolver.java
===
---
Yes we could do that. Just remove that default value.
But what i would like to have IF you have a body specified then we don't
throw anything
This way we keep old behavior and we have the new one
Because if i specifiy a body then thats the default value for me. And if not
then i still can see
very
On 11/3/07, Johan Compagner [EMAIL PROTECTED] wrote:
Yes we could do that. Just remove that default value.
But what i would like to have IF you have a body specified then we don't
throw anything
This way we keep old behavior and we have the new one
Because if i specifiy a body then thats the
Johan Compagner wrote:
Yes we could do that. Just remove that default value.
But what i would like to have IF you have a body specified then we don't
throw anything
This way we keep old behavior and we have the new one
FWIW, I entirely agree with this. If we just change it for tags that
have
On 11/3/07, Al Maw [EMAIL PROTECTED] wrote:
Johan Compagner wrote:
Yes we could do that. Just remove that default value.
But what i would like to have IF you have a body specified then we don't
throw anything
This way we keep old behavior and we have the new one
FWIW, I entirely agree
18 matches
Mail list logo
