Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Marius Dumitru Florea]

Isn't it possible to separate the two? i.e. move the part that requires PR
in a separate page where your users don't have edit right and include it
using the Include macro.

On Fri, Dec 9, 2016 at 3:19 PM, Hamster  wrote:

> Actually, it's a bit more complicated than that...
>
> It's a page which holds all bits of information, but they also make notes
> on
> that page. So they should be able to make changes. But those changes break
> the PR stuff, so I need to re-save those pages for the PR stuff to work
> again.
>
>
>
> --
> View this message in context: http://xwiki.475771.n2.nabble.
> com/Menu-crashes-if-changed-by-a-non-admin-user-see-menu-
> application-extension-tp7600481p7602043.html
> Sent from the XWiki- Users mailing list archive at Nabble.com.
>

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Hamster]

Actually, it's a bit more complicated than that...

It's a page which holds all bits of information, but they also make notes on
that page. So they should be able to make changes. But those changes break
the PR stuff, so I need to re-save those pages for the PR stuff to work
again.



--
View this message in context: 
http://xwiki.475771.n2.nabble.com/Menu-crashes-if-changed-by-a-non-admin-user-see-menu-application-extension-tp7600481p7602043.html
Sent from the XWiki- Users mailing list archive at Nabble.com.

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Marius Dumitru Florea]

If you don't want your users to edit those pages then why do you give them
edit right?

On Thu, Dec 8, 2016 at 11:36 AM, Hamster  wrote:

> Can this issue be addressed?
>
> I have to repair pages on a daily notice because people keep changing pages
> which require PR to function OK. It's very annoying. And I keep telling
> them, "No, it's not your fault. No, you can't see at this moment if a page
> requires PR. Yes, you will break those pages if you edit them".
>
> People who have no PR should not be able to edit pages which require PR!
>
> Thanks :-)
>
>
>
> --
> View this message in context: http://xwiki.475771.n2.nabble.
> com/Menu-crashes-if-changed-by-a-non-admin-user-see-menu-
> application-extension-tp7600481p7602029.html
> Sent from the XWiki- Users mailing list archive at Nabble.com.
>

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Hamster]

Can this issue be addressed?

I have to repair pages on a daily notice because people keep changing pages
which require PR to function OK. It's very annoying. And I keep telling
them, "No, it's not your fault. No, you can't see at this moment if a page
requires PR. Yes, you will break those pages if you edit them".

People who have no PR should not be able to edit pages which require PR!

Thanks :-)



--
View this message in context: 
http://xwiki.475771.n2.nabble.com/Menu-crashes-if-changed-by-a-non-admin-user-see-menu-application-extension-tp7600481p7602029.html
Sent from the XWiki- Users mailing list archive at Nabble.com.

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Vincent Massol]

> On 27 Jul 2016, at 18:05, Vincent Massol  wrote:
> 
> 
>> On 27 Jul 2016, at 17:33, Alina Kupgisch  
>> wrote:
>> 
>> Hi Marius,
>> 
>> that works and was easy to realize, thanks! And thanks for your description 
>> as well. I now understand why this is happening.
>> 
>> Vincent also wrote that this behavior is quite normal, but it could be a bit 
>> more user friendly...in my opinion. It would be nice if normal users where 
>> not permitted to edit the page or if they get a warning that the page will 
>> be saved with wrong permissions.
> 
> I agree. The issue is that we can’t guess is some APIs require Programming 
> Rights for example (or Admin Rights).
> 
> However what we’ve done for this is introduce a manual xobject to specify 
> what permission is required for a given page. What we could do is associate a 
> custom edit sheet with that xclass and display a warning if the current users 
> doesn’t have the required permission. Or we could simply modify the default 
> edit sheet to display this information in a panel in the same way as we list 
> included pages in edit mode (in a more visible way).

To be more precise the xclass is XWiki.RequiredRightClass and currently it has 
2 levels defined: “edit” and “programming”. But we could easily add “admin” too.

I’ve just created http://jira.xwiki.org/browse/XWIKI-13601 to not forget this. 
We can decide if we want it or not.

Thanks
-Vincent

> @Devs: WDYT? We have such an xobject for PR right now but I guess we could 
> generalize it for all permissions.
> 
> Thanks
> -Vincent
> 
>> Best regards
>> Alina
>> 
>> 
>> 
>> Am 27.07.2016 um 13:28 schrieb Marius Dumitru Florea:
>>> Hi Alina,
>>> 
>>> On Wed, Jul 27, 2016 at 2:09 PM, Alina Kupgisch <
>>> alina.kupgi...@sourcepark.de> wrote:
>>> 
 Hi Xwiki Team,
 
 it seems as if there is a small bug in the "Menu Application"extension
 (version 8.2). Every time a user, that is not in the XWikiAdminGroup, does
 some changes on the menu page in edit mode, the menu crashes and is no
 longer visible. To fix that an admin user of XWikiAdminGroup has to edit
 and save the page. It is important that a small change has to be done by
 the admin user.
 
>>> This behavior is normal. The menu has a property named "Menu Visibility
>>> Scope" with 3 possible values. The "Current Wiki" value requires the menu
>>> to be saved by someone that has wiki administration rights, because the
>>> menu is visible everywhere on the wiki. You don't want a simple user to add
>>> a new menu that is visible for everyone.
>>> 
>>> You may want to try the following:
>>> 
>>> * put the content of the menu page in a separate page
>>> * give edit rights for this separate page to the simple users that are
>>> allowed to modify the menu
>>> * use the include macro to include the separate page in the menu page. Do
>>> this with someone that has administration rights so that the menu page is
>>> saved with the proper rights.
>>> 
>>> Hope this helps,
>>> Marius
>>> 
>>> 
 
 Best regards
 
 Alina

___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Vincent Massol]

> On 27 Jul 2016, at 17:33, Alina Kupgisch  wrote:
> 
> Hi Marius,
> 
> that works and was easy to realize, thanks! And thanks for your description 
> as well. I now understand why this is happening.
> 
> Vincent also wrote that this behavior is quite normal, but it could be a bit 
> more user friendly...in my opinion. It would be nice if normal users where 
> not permitted to edit the page or if they get a warning that the page will be 
> saved with wrong permissions.

I agree. The issue is that we can’t guess is some APIs require Programming 
Rights for example (or Admin Rights).

However what we’ve done for this is introduce a manual xobject to specify what 
permission is required for a given page. What we could do is associate a custom 
edit sheet with that xclass and display a warning if the current users doesn’t 
have the required permission. Or we could simply modify the default edit sheet 
to display this information in a panel in the same way as we list included 
pages in edit mode (in a more visible way).

@Devs: WDYT? We have such an xobject for PR right now but I guess we could 
generalize it for all permissions.

Thanks
-Vincent

> Best regards
> Alina
> 
> 
> 
> Am 27.07.2016 um 13:28 schrieb Marius Dumitru Florea:
>> Hi Alina,
>> 
>> On Wed, Jul 27, 2016 at 2:09 PM, Alina Kupgisch <
>> alina.kupgi...@sourcepark.de> wrote:
>> 
>>> Hi Xwiki Team,
>>> 
>>> it seems as if there is a small bug in the "Menu Application"extension
>>> (version 8.2). Every time a user, that is not in the XWikiAdminGroup, does
>>> some changes on the menu page in edit mode, the menu crashes and is no
>>> longer visible. To fix that an admin user of XWikiAdminGroup has to edit
>>> and save the page. It is important that a small change has to be done by
>>> the admin user.
>>> 
>> This behavior is normal. The menu has a property named "Menu Visibility
>> Scope" with 3 possible values. The "Current Wiki" value requires the menu
>> to be saved by someone that has wiki administration rights, because the
>> menu is visible everywhere on the wiki. You don't want a simple user to add
>> a new menu that is visible for everyone.
>> 
>> You may want to try the following:
>> 
>> * put the content of the menu page in a separate page
>> * give edit rights for this separate page to the simple users that are
>> allowed to modify the menu
>> * use the include macro to include the separate page in the menu page. Do
>> this with someone that has administration rights so that the menu page is
>> saved with the proper rights.
>> 
>> Hope this helps,
>> Marius
>> 
>> 
>>> 
>>> Best regards
>>> 
>>> Alina
___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Alina Kupgisch]

Hi Marius,

that works and was easy to realize, thanks! And thanks for your 
description as well. I now understand why this is happening.


Vincent also wrote that this behavior is quite normal, but it could be a 
bit more user friendly...in my opinion. It would be nice if normal users 
where not permitted to edit the page or if they get a warning that the 
page will be saved with wrong permissions.



Best regards
Alina



Am 27.07.2016 um 13:28 schrieb Marius Dumitru Florea:

Hi Alina,

On Wed, Jul 27, 2016 at 2:09 PM, Alina Kupgisch <
alina.kupgi...@sourcepark.de> wrote:


Hi Xwiki Team,

it seems as if there is a small bug in the "Menu Application"extension
(version 8.2). Every time a user, that is not in the XWikiAdminGroup, does
some changes on the menu page in edit mode, the menu crashes and is no
longer visible. To fix that an admin user of XWikiAdminGroup has to edit
and save the page. It is important that a small change has to be done by
the admin user.


This behavior is normal. The menu has a property named "Menu Visibility
Scope" with 3 possible values. The "Current Wiki" value requires the menu
to be saved by someone that has wiki administration rights, because the
menu is visible everywhere on the wiki. You don't want a simple user to add
a new menu that is visible for everyone.

You may want to try the following:

* put the content of the menu page in a separate page
* give edit rights for this separate page to the simple users that are
allowed to modify the menu
* use the include macro to include the separate page in the menu page. Do
this with someone that has administration rights so that the menu page is
saved with the proper rights.

Hope this helps,
Marius




Best regards

Alina

___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users


___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users


___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Hamster]

The main problem here is that, as a simple user, you can't see that a page
has been saved with PR.

Thus, simple users will constantly break pages which require PR to function
properly.

A simple user should atleast get a warning that a page has been saved with
PR. Maybe a simple user should be denied to edit a page which has been saved
with PR.



--
View this message in context: 
http://xwiki.475771.n2.nabble.com/Menu-crashes-if-changed-by-a-non-admin-user-see-menu-application-extension-tp7600481p7600488.html
Sent from the XWiki- Users mailing list archive at Nabble.com.
___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Marius Dumitru Florea]

Hi Alina,

On Wed, Jul 27, 2016 at 2:09 PM, Alina Kupgisch <
alina.kupgi...@sourcepark.de> wrote:

> Hi Xwiki Team,
>
> it seems as if there is a small bug in the "Menu Application"extension
> (version 8.2). Every time a user, that is not in the XWikiAdminGroup, does
> some changes on the menu page in edit mode, the menu crashes and is no
> longer visible. To fix that an admin user of XWikiAdminGroup has to edit
> and save the page. It is important that a small change has to be done by
> the admin user.
>

This behavior is normal. The menu has a property named "Menu Visibility
Scope" with 3 possible values. The "Current Wiki" value requires the menu
to be saved by someone that has wiki administration rights, because the
menu is visible everywhere on the wiki. You don't want a simple user to add
a new menu that is visible for everyone.

You may want to try the following:

* put the content of the menu page in a separate page
* give edit rights for this separate page to the simple users that are
allowed to modify the menu
* use the include macro to include the separate page in the menu page. Do
this with someone that has administration rights so that the menu page is
saved with the proper rights.

Hope this helps,
Marius


>
>
> Best regards
>
> Alina
>
> ___
> users mailing list
> users@xwiki.org
> http://lists.xwiki.org/mailman/listinfo/users
>
___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users

Re: [xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Vincent Massol]

Hi,

> On 27 Jul 2016, at 13:09, Alina Kupgisch  wrote:
> 
> Hi Xwiki Team,
> 
> it seems as if there is a small bug in the "Menu Application"extension 
> (version 8.2). Every time a user, that is not in the XWikiAdminGroup, does 
> some changes on the menu page in edit mode, the menu crashes and is no longer 
> visible. To fix that an admin user of XWikiAdminGroup has to edit and save 
> the page. It is important that a small change has to be done by the admin 
> user.

That’s probably because the menu page requires Programming Rights (and not 
Admin rights btw). If that’s the case, it’s not a bug (although there might be 
ways to improve it and not require PR).

Thanks
-Vincent

> 
> 
> Best regards
> 
> Alina

___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users

[xwiki-users] Menu crashes if changed by a non admin user (see menu application extension)

[Alina Kupgisch]

Hi Xwiki Team,

it seems as if there is a small bug in the "Menu Application"extension 
(version 8.2). Every time a user, that is not in the XWikiAdminGroup, 
does some changes on the menu page in edit mode, the menu crashes and is 
no longer visible. To fix that an admin user of XWikiAdminGroup has to 
edit and save the page. It is important that a small change has to be 
done by the admin user.



Best regards

Alina

___
users mailing list
users@xwiki.org
http://lists.xwiki.org/mailman/listinfo/users