Re: Sorting tables on columns with null values

2016-09-21 Thread Dan Haywood
Thanks for this... have applied to 1.13.1 maintenance release On 21 September 2016 at 13:29, Martin Grigorov wrote: > Thank you, Erik! > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Wed, Sep 21, 2016 at 2:20 PM, Erik de Hair wrote: > > > raised an i

Re: Sorting tables on columns with null values

2016-09-21 Thread Martin Grigorov
Thank you, Erik! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Sep 21, 2016 at 2:20 PM, Erik de Hair wrote: > raised an issue [1] and created a pull request > > [1] https://issues.apache.org/jira/browse/ISIS-1493 > > > > On 09/21/2016 11:58 AM, Martin Gri

Re: Sorting tables on columns with null values

2016-09-21 Thread Erik de Hair
raised an issue [1] and created a pull request [1] https://issues.apache.org/jira/browse/ISIS-1493 On 09/21/2016 11:58 AM, Martin Grigorov wrote: Good catch! Please create a Pull Request! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Sep 21, 2016 at 1

Re: Sorting tables on columns with null values

2016-09-21 Thread Martin Grigorov
Good catch! Please create a Pull Request! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Sep 21, 2016 at 11:52 AM, Erik de Hair wrote: > Hi Martin, > > It looks like the code on [1] is messing things up. > > If you replace the method with something like b

Re: Sorting tables on columns with null values

2016-09-21 Thread Erik de Hair
Hi Martin, It looks like the code on [1] is messing things up. If you replace the method with something like below, it works: private static Ordering orderingBy(final ObjectAssociation sortProperty, final boolean ascending) { final Ordering ordering = new Ordering(){

Re: Sorting tables on columns with null values

2016-09-20 Thread Martin Grigorov
Hi Erik, This should be handled by https://github.com/apache/isis/blob/3dffc2d96e240982d16131d57d34fc8f54d1292c/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/CollectionContentsSortableDataProvider.java#L163-L167 It looks correct to me.