Re: [OpenSIPS-Users] Jabber module issue

[Bogdan-Andrei Iancu]

Hello Igor,

Thank you for the report and testing. The patch is now on the GIT repo 
and it will be part of the next releases.


Best regards,

Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com

On 19.09.2016 14:45, Igor Pavlov wrote:


Thank you, Bogdan. Patch works.


14.09.2016 19:01, Bogdan-Andrei Iancu пишет:

Hello Igor,

Could you please try the attached patch ?

Regards,
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com
On 12.09.2016 16:23, Igor Pavlov wrote:


Hi, all. I'm working on opensips-ejabberd integration. Flow opensips 
-> ejabberd working fine, but ejabberd->opensips has trouble - 
message isn't delivered to the recipient.


I think jabber-module construct wrong From header:

Sep  9 08:12:44 vs01 /usr/sbin/opensips[3313]: DBG:core:tcp_send: 
buf=#012MESSAGE sip:1...@example.com SIP/2.0#015#012Via: 
SIP/2.0/TLS 10.10.10.136:5061;branch=z9hG4b
K92f5.78c7b26.0#015#012To: sip:1...@example.com#015#012From: 
*<>*;tag=2b04f16aecab308d711c6336732ee60c-603e#015#012CSeq: 
10 MESSAGE#
015#012Call-ID: 
09df26003f14d685-3296@10.10.10.136#015#012Max-Forwards: 
70#015#012Content-Length: 3#015#012User-agent: 
example#015#012Content-Type: text/plain#015#012

Contact: <*sip:test1*example@example.com*>#015#012#015#012123


As a result:

Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: ERROR:core:parse_to: 
unexpected char [<] in status 5: <<<>> .
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: 
ERROR:core:parse_from_header: bad from header
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: 
DBG:core:set_err_info: ec: 1, el: 3, ei: 'error parsing From header'
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: 
ERROR:core:pv_get_from_attr: cannot parse From header


--

Best regards,
Igor Pavlov


___
Users mailing list
Users@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/users




--

Best regards,
Igor Pavlov


___
Users mailing list
Users@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/users

Re: [OpenSIPS-Users] Jabber module issue

[Igor Pavlov]

Thank you, Bogdan. Patch works.


14.09.2016 19:01, Bogdan-Andrei Iancu пишет:

Hello Igor,

Could you please try the attached patch ?

Regards,
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com
On 12.09.2016 16:23, Igor Pavlov wrote:


Hi, all. I'm working on opensips-ejabberd integration. Flow opensips 
-> ejabberd working fine, but ejabberd->opensips has trouble - 
message isn't delivered to the recipient.


I think jabber-module construct wrong From header:

Sep  9 08:12:44 vs01 /usr/sbin/opensips[3313]: DBG:core:tcp_send: 
buf=#012MESSAGE sip:1...@example.com SIP/2.0#015#012Via: SIP/2.0/TLS 
10.10.10.136:5061;branch=z9hG4b
K92f5.78c7b26.0#015#012To: sip:1...@example.com#015#012From: 
*<>*;tag=2b04f16aecab308d711c6336732ee60c-603e#015#012CSeq: 
10 MESSAGE#
015#012Call-ID: 
09df26003f14d685-3296@10.10.10.136#015#012Max-Forwards: 
70#015#012Content-Length: 3#015#012User-agent: 
example#015#012Content-Type: text/plain#015#012

Contact: <*sip:test1*example@example.com*>#015#012#015#012123


As a result:

Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: ERROR:core:parse_to: 
unexpected char [<] in status 5: <<<>> .
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: 
ERROR:core:parse_from_header: bad from header
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: 
DBG:core:set_err_info: ec: 1, el: 3, ei: 'error parsing From header'
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: 
ERROR:core:pv_get_from_attr: cannot parse From header


--

Best regards,
Igor Pavlov


___
Users mailing list
Users@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/users




--

Best regards,
Igor Pavlov

___
Users mailing list
Users@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/users

Re: [OpenSIPS-Users] Jabber module issue

[Bogdan-Andrei Iancu]

Hello Igor,

Could you please try the attached patch ?

Regards,

Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com

On 12.09.2016 16:23, Igor Pavlov wrote:


Hi, all. I'm working on opensips-ejabberd integration. Flow opensips 
-> ejabberd working fine, but ejabberd->opensips has trouble - message 
isn't delivered to the recipient.


I think jabber-module construct wrong From header:

Sep  9 08:12:44 vs01 /usr/sbin/opensips[3313]: DBG:core:tcp_send: 
buf=#012MESSAGE sip:1...@example.com SIP/2.0#015#012Via: SIP/2.0/TLS 
10.10.10.136:5061;branch=z9hG4b
K92f5.78c7b26.0#015#012To: sip:1...@example.com#015#012From: 
*<>*;tag=2b04f16aecab308d711c6336732ee60c-603e#015#012CSeq: 
10 MESSAGE#
015#012Call-ID: 
09df26003f14d685-3296@10.10.10.136#015#012Max-Forwards: 
70#015#012Content-Length: 3#015#012User-agent: 
example#015#012Content-Type: text/plain#015#012

Contact: <*sip:test1*example@example.com*>#015#012#015#012123


As a result:

Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: ERROR:core:parse_to: 
unexpected char [<] in status 5: <<<>> .
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: 
ERROR:core:parse_from_header: bad from header
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: DBG:core:set_err_info: 
ec: 1, el: 3, ei: 'error parsing From header'
Sep  9 08:12:44 vs01 /usr/sbin/opensips[3307]: 
ERROR:core:pv_get_from_attr: cannot parse From header


--

Best regards,
Igor Pavlov


___
Users mailing list
Users@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/users


diff --git a/modules/jabber/xjab_worker.c b/modules/jabber/xjab_worker.c
index 46344e2..f0c8ce3 100644
--- a/modules/jabber/xjab_worker.c
+++ b/modules/jabber/xjab_worker.c
@@ -1158,11 +1158,10 @@ int xj_send_sip_msg(str *proxy, str *to, str *from, str *msg, int *cbp)
 
 	// from correction
 	tfrom.len = 0;
-	strncpy(buf+tfrom.len, "s, from->len);
 	tfrom.len += from->len;
-	buf[tfrom.len++] = '>';
 
 	tfrom.s = buf;
 
___
Users mailing list
Users@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/users