Re: [Broker-J] management REST API

2018-05-16 Thread Oleksandr Rudyy
I raised JIRA QPID-8192 to make bindingKey parameter mandatory in bind/unbind operations: https://issues.apache.org/jira/browse/QPID-8192 Kind Regards, Alex On 16 May 2018 at 09:52, Rob Godfrey wrote: > I'd argue that we should not have bindingKey as optional, but

Re: [Broker-J] management REST API

2018-05-16 Thread Rob Godfrey
I'd argue that we should not have bindingKey as optional, but allow the value of the binding key to be the empty string (which is what the code actually does if it encounters a null binding key) - presumably the mechanism for invoking operations can distinguish between no binding key being sent,

RE: [Broker-J] management REST API

2018-05-16 Thread VERMEULEN Olivier
- From: Oleksandr Rudyy <oru...@gmail.com> Sent: mardi 15 mai 2018 23:15 To: users@qpid.apache.org Subject: Re: [Broker-J] management REST API My apologies, I completely misread and misinterpreted the method description. Somehow I missed *all the bindings*" in my reading :( The

Re: [Broker-J] management REST API

2018-05-15 Thread Oleksandr Rudyy
My apologies, I completely misread and misinterpreted the method description. Somehow I missed *all the bindings*" in my reading :( The bindingKey is optional here because, for example, for canonical queue binding to fanout exchange the binding key is not needed. Though, it is now possible to

Re: [Broker-J] management REST API

2018-05-15 Thread Rob Godfrey
Hi Alex, I think the wording is at least ambiguous when you take into account the fact that bindingKey is marked as optional; and that if you read it as requiring an exact match of both destination and binding then the wording "Deletes *all the bindings*" is weird - because there can only be 0 or

Re: [Broker-J] management REST API

2018-05-15 Thread Oleksandr Rudyy
Hi Olivier, The current description of unbind operation on master and 7.0.x states : Deletes all the bindings matching the given destination and bindingKey As per description the queue binding is deleted only when both destination and binding key are equal to provided destination and bindingKey