Re: Bug with Tomcat-8.5 and Apache Commons FileUpload

2019-09-30 Thread i...@flyingfischer.ch
Thanks! Setting overheadDataThreshold="0" does fix the issue.

Without overheadDataThreshold the issue is very inconsistent:

Firefox 69.0.1 (64-Bit) on LNX and on other OS does result in the
described error below.

Very strange: Chrome on LNX mostly works, which means I got
intermittently once got "connection closed" with Chrome. On the second
retry the upload worked.
Even stranger: after a successful upload by Chrome it even works with FF
with the same file.

Markus

Am 30.09.19 um 20:49 schrieb Mark Thomas:
> That sounds like the client has tripped the overhead threshold protection.
>
> As a short term fix you probably want to see a lower value for:
> overheadDataThreshold
>
> see: http://tomcat.apache.org/tomcat-8.5-doc/config/http2.html
>
> possibly as low as zero.
>
> Longer term you should ideally look into why the client is sending
> small, non-final DATA frames since that as inefficient and has been
> identified as a potential DoS vector in some servers (not Tomcat but we
> block it as abusive behaviour anyway).
>
> Depending on what the client is doing, you may need to adjust the other
> over head thresholds as well. If you have a reproducible test case,
> enabling debug for http2 in logging.properties should shed some light on
> exactly what is going on.
>
> Mark
>
>
> On 30/09/2019 17:48, i...@flyingfischer.ch wrote:
>> I stumbled over a new problem which very likely appeared after
>> apache-tomcat-8.5.43 and between apache-tomcat-8.5.46
>>
>> Using Apache Commons FileUpload gives for some kind of PDF files:
>>
>> [https-openssl-apr-443-exec-15]
>> org.apache.struts.upload.CommonsMultipartRequestHandler.handleRequest
>> Failed to parse multipart request
>>
>> org.apache.commons.fileupload.FileUploadBase$IOFileUploadException:
>> Processing of multipart/form-data request failed. java.io.IOException:
>> The socket associated with this connection has been closed.
>>
>> This only happens when using HTTP/2. Upload works when downgrading
>> tomcat to HTTP/1.
>>
>> There has been posted a similiar error report on Stackoverflow, which
>> indicates that the sizes of the files may be the reason:
>>
>> https://stackoverflow.com/questions/58118776/apache-commons-fileupload-problems-uploading-files-greater-than-100kb-using-htt
>>
>> Thanks for considering
>> Markus
>>
>>
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: users-h...@tomcat.apache.org
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Bug with Tomcat-8.5 and Apache Commons FileUpload

2019-09-30 Thread Mark Thomas
That sounds like the client has tripped the overhead threshold protection.

As a short term fix you probably want to see a lower value for:
overheadDataThreshold

see: http://tomcat.apache.org/tomcat-8.5-doc/config/http2.html

possibly as low as zero.

Longer term you should ideally look into why the client is sending
small, non-final DATA frames since that as inefficient and has been
identified as a potential DoS vector in some servers (not Tomcat but we
block it as abusive behaviour anyway).

Depending on what the client is doing, you may need to adjust the other
over head thresholds as well. If you have a reproducible test case,
enabling debug for http2 in logging.properties should shed some light on
exactly what is going on.

Mark


On 30/09/2019 17:48, i...@flyingfischer.ch wrote:
> I stumbled over a new problem which very likely appeared after
> apache-tomcat-8.5.43 and between apache-tomcat-8.5.46
> 
> Using Apache Commons FileUpload gives for some kind of PDF files:
> 
> [https-openssl-apr-443-exec-15]
> org.apache.struts.upload.CommonsMultipartRequestHandler.handleRequest
> Failed to parse multipart request
> 
> org.apache.commons.fileupload.FileUploadBase$IOFileUploadException:
> Processing of multipart/form-data request failed. java.io.IOException:
> The socket associated with this connection has been closed.
> 
> This only happens when using HTTP/2. Upload works when downgrading
> tomcat to HTTP/1.
> 
> There has been posted a similiar error report on Stackoverflow, which
> indicates that the sizes of the files may be the reason:
> 
> https://stackoverflow.com/questions/58118776/apache-commons-fileupload-problems-uploading-files-greater-than-100kb-using-htt
> 
> Thanks for considering
> Markus
> 
> 
> 
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Bug with Tomcat-8.5 and Apache Commons FileUpload

2019-09-30 Thread i...@flyingfischer.ch
I stumbled over a new problem which very likely appeared after
apache-tomcat-8.5.43 and between apache-tomcat-8.5.46

Using Apache Commons FileUpload gives for some kind of PDF files:

[https-openssl-apr-443-exec-15]
org.apache.struts.upload.CommonsMultipartRequestHandler.handleRequest
Failed to parse multipart request

org.apache.commons.fileupload.FileUploadBase$IOFileUploadException:
Processing of multipart/form-data request failed. java.io.IOException:
The socket associated with this connection has been closed.

This only happens when using HTTP/2. Upload works when downgrading
tomcat to HTTP/1.

There has been posted a similiar error report on Stackoverflow, which
indicates that the sizes of the files may be the reason:

https://stackoverflow.com/questions/58118776/apache-commons-fileupload-problems-uploading-files-greater-than-100kb-using-htt

Thanks for considering
Markus



-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org