Re: Disable connector by property

2020-05-14 Thread T. Papke 
Hello Mark,

if an application is shipped with tomcat and a predefined server.xml, some
configurations shall still be modified from "outside" without modifing the
server.xml. The existing property placeholder approach is already flexible
and allows the "extraction" of certain configurations to an external
property file. But currently it is not possible to enable or disable e.g.
ajp with a property or to enable/disable the http connector with a property
(e.g. tomcat.ajp.enabled=true or tomcat.ajp.port=-1). At the end, a
approach slightly similar to the configuration of tomcat in context of
spring-boot.

Kind regards,
Thomas

Am Do., 14. Mai 2020 um 00:28 Uhr schrieb Mark Thomas :

> On 13/05/2020 20:16, T. Papke wrote:
> > Hello all,
> >
> > Currently adding or removing a connector requires changes to the XML
> > structure of the server.xml (at least 9.x)
> >
> > Is there any option to enable or disable a connector with a system
> > property? If not, does it make sense to add a "enabled" attribute to the
> > connector or implicit interpret a Port = "-1" as disabled?
>
> What problem are you trying to solve?
>
> Mark
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>
>

RE: Disable connector by property

2020-05-13 Thread jonmcalexander 

-Original Message-
From: Mark Thomas  
Sent: Wednesday, May 13, 2020 5:28 PM
To: users@tomcat.apache.org
Subject: Re: Disable connector by property

On 13/05/2020 20:16, T. Papke wrote:
> Hello all,
> 
> Currently adding or removing a connector requires changes to the XML 
> structure of the server.xml (at least 9.x)
> 
> Is there any option to enable or disable a connector with a system 
> property? If not, does it make sense to add a "enabled" attribute to 
> the connector or implicit interpret a Port = "-1" as disabled?

> What problem are you trying to solve?

> Mark

> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org

Isn't it just as easy that if you don't want a connector enabled, don't define 
it or comment it out?

Re: Disable connector by property

2020-05-13 Thread Mark Thomas 
On 13/05/2020 20:16, T. Papke wrote:
> Hello all,
> 
> Currently adding or removing a connector requires changes to the XML
> structure of the server.xml (at least 9.x)
> 
> Is there any option to enable or disable a connector with a system
> property? If not, does it make sense to add a "enabled" attribute to the
> connector or implicit interpret a Port = "-1" as disabled?

What problem are you trying to solve?

Mark

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org