Re: Native WebSockets - exceptions and sendRedirect inside WebSocketResponse

2016-01-01 Thread Martin Grigorov
Hi, On Mon, Dec 28, 2015 at 4:49 PM, Daniel Stoch wrote: > Hi, > > As I wrote in my previous post "Native WebSockets - cookies and last > handler question": In WebSocketResponse many methods throws > UnsupportedOperationException. Some of them can be customized now >

Re: Native WebSockets - exceptions and sendRedirect inside WebSocketResponse

2016-01-01 Thread Martin Grigorov
Hi, On Tue, Dec 29, 2015 at 2:14 PM, Daniel Stoch wrote: > Another problem with WebSocketRequest: > > @Override > public Url getUrl() > { > return null; > } > > @Override > public Url getClientUrl() > { > return null; > } >

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Martin Grigorov
Hi, On Fri, Jan 1, 2016 at 8:17 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Hi, > > tests only from what is possible - if there is markup which can be tested. > > @martin - Are there integration tests @ Wicket bootstrap? > No. > > kind regards > > Tobias > > > Am

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Tobias Soloschenko
Hi, yep - good point about squashing. kind regards Tobias > Am 01.01.2016 um 21:34 schrieb Martin Grigorov : > > Hi, > > On Fri, Jan 1, 2016 at 8:17 PM, Tobias Soloschenko < > tobiassolosche...@googlemail.com> wrote: > >> Hi, >> >> tests only from what is possible -

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Ernesto Reinaldo Barreiro
Thanks for feedback. I think this component will work as it is also with 6.x branch... Additionally I also have other bootstrap based components that I use on my project that I might contribute to wicket-bootstrap. Let me see If I find the time to integrate them :-) On Fri, Jan 1, 2016 at 11:36

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Ernesto Reinaldo Barreiro
Hi, I have added all the essential features I need for my project. You can see the result in action here http://ns331816.ip-188-165-220.eu/demo/slider I will for sure add more features while integrating it with my project... But for now we have a minimal working integration. Please feel free to

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Tobias Soloschenko
Hi, great - and that fast! Looking forward to review the PR. :-) kind regards Tobias > Am 01.01.2016 um 11:14 schrieb Ernesto Reinaldo Barreiro : > > Hi, > > I have added all the essential features I need for my project. You can see > the result in action here > >

Re: Wicket CSRF/XSRF protection

2016-01-01 Thread Andrea Del Bene
Hi, I think you might need to roll out your own RequestCycleListener to check for the XSRF-TOKEN. Or alternatively if you are using wicketstuff REST support you could use hook method onBeforeMethodInvoked to check the token before REST API is invoked. See

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Ernesto Reinaldo Barreiro
I confirm component works too for wicket 6.x applications: my project still uses latest wicket 6 On Fri, Jan 1, 2016 at 11:45 AM, Ernesto Reinaldo Barreiro < reier...@gmail.com> wrote: > Thanks for feedback. I think this component will work as it is also with > 6.x branch... Additionally I also

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Tobias Soloschenko
Hi, thank you for checking it and for your contributions! :-) I suggest to first create a PR against wicket-bootstrap 6.x. It would be great to create a package for it and write some unit tests. After it is integrated with all changes of comments in the PR it can easily be cherry picked for

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Tobias Soloschenko
Hi, tests only from what is possible - if there is markup which can be tested. @martin - Are there integration tests @ Wicket bootstrap? kind regards Tobias > Am 01.01.2016 um 18:03 schrieb Ernesto Reinaldo Barreiro : > > Are you talking about client side tests? Mind

Re: wrapper for http://www.eyecon.ro/bootstrap-slider/

2016-01-01 Thread Ernesto Reinaldo Barreiro
Are you talking about client side tests? Mind that component is just 90% JavaScript and java is just a thin layer on top. On Fri, Jan 1, 2016 at 2:54 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Hi, > > thank you for checking it and for your contributions! :-) > > I