Re: 8.0.0-M8 StoreSettings.setAsynchronous(false) appears not to be honoured

2017-11-27 Thread Greg Johnson
https://issues.apache.org/jira/browse/WICKET-6501

Many thanks, regards, Greg Johnson

> On 27 Nov 2017, at 05:46, Martin Grigorov  wrote:
> 
> Yes, it is a regression!
> Please file a ticket!
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
> On Sun, Nov 26, 2017 at 10:31 AM, Greg Johnson > wrote:
> 
>> Setting 8.0.0-M8 StoreSettings.setAsynchronous(false) does not prevent
>> pageStore from being wrapped with AsynchronousPageStore - am I missing
>> something?
>> 
>> Thanks, regards, Greg Johnson
>> 
>> DefaultPageManagerProvider.java:
>> 
>>if (dataStore.canBeAsynchronous()) {
>>int capacity = storeSettings.getAsynchronousQueueCapacity();
>>dataStore = new AsynchronousDataStore(dataStore, capacity);
>>pageStore = newPageStore(dataStore);
>>if (pageStore.canBeAsynchronous()) {
>>pageStore = new AsynchronousPageStore(pageStore,
>> capacity);
>>}
>>} else {
>>pageStore = newPageStore(dataStore);
>>}
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>> 
>> 


-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: 8.0.0-M8 StoreSettings.setAsynchronous(false) appears not to be honoured

2017-11-26 Thread Martin Grigorov
Yes, it is a regression!
Please file a ticket!

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Nov 26, 2017 at 10:31 AM, Greg Johnson  wrote:

> Setting 8.0.0-M8 StoreSettings.setAsynchronous(false) does not prevent
> pageStore from being wrapped with AsynchronousPageStore - am I missing
> something?
>
> Thanks, regards, Greg Johnson
>
> DefaultPageManagerProvider.java:
>
> if (dataStore.canBeAsynchronous()) {
> int capacity = storeSettings.getAsynchronousQueueCapacity();
> dataStore = new AsynchronousDataStore(dataStore, capacity);
> pageStore = newPageStore(dataStore);
> if (pageStore.canBeAsynchronous()) {
> pageStore = new AsynchronousPageStore(pageStore,
> capacity);
> }
> } else {
> pageStore = newPageStore(dataStore);
> }
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>