Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
Guten Tag Martin Grigorov, am Mittwoch, 30. März 2016 um 15:54 schrieben Sie: > Please create a patch / Pull Request and a ticket. https://issues.apache.org/jira/browse/WICKET-6133 Mit freundlichen Grüßen, Thorsten Schöning -- Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de AM-SoFT IT-Systeme http://www.AM-SoFT.de/ Telefon...05151- 9468- 55 Fax...05151- 9468- 88 Mobil..0178-8 9468- 04 AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
I also think that this are bugs of the tests. The specific test receive a different locale then the environment and so different resources are compared. You can see it in the Base64 encoded image test. kind regards Tobias > Am 30.03.2016 um 15:45 schrieb Martin Grigorov: > > If I try to build Wicket 7.x with de_DE locale the build fails at > wicket-core: > > Failed tests: > > MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115 > expected: but was: > > ResouceBundleTest.concatBundle:48->Assert.assertEquals:144->Assert.assertEquals:115 > expected: but was: > > ResourceReferenceLocatingTest.locateMinifiedJavaScriptResourceReference:214->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956 > TestCase [locale=null, style=null, variation=null, extension=null] > Expected: is "// b.min.js" > but: was "// b_de.js" > > ResourceReferenceLocatingTest.locateMinifiedPackageResourceReference:223->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956 > TestCase [locale=null, style=null, variation=null, extension=null] > Expected: is "// b.min.js" > but: was "// b_de.js" > > ResourceReferenceLocatingTest.locateNonMinifiedJavaScriptResourceReference:196->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956 > TestCase [locale=null, style=null, variation=null, extension=null] > Expected: is "// b.js" > but: was "// b_de.js" > > ResourceReferenceLocatingTest.locateNonMinifiedPackageResourceReference:205->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956 > TestCase [locale=null, style=null, variation=null, extension=null] > Expected: is "// b.js" > but: was "// b_de.js" > > CssUrlReplacerTest.base64EncodedImage:153->Assert.assertThat:923->Assert.assertThat:956 > Expected: a string containing ".class {background-image: > url(data:image/gif;base64,R0lGODlh1wATAXAAACH5BAEAAP8ALADXA" > but: was ".class {background-image: > url(data:image/gif;base64,R0lGODlhUAB4ANUAANbX1hQSEXV0c/f. > > > Sigh. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Wed, Mar 30, 2016 at 2:52 PM, Thorsten Schöning > wrote: > >> Guten Tag Thorsten Schöning, >> am Mittwoch, 30. März 2016 um 14:16 schrieben Sie: >> >>> "mvn --version" should provide all requested info: >> >> No change even with a more current version of Maven: >> >>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; >> 2015-11-10T17:41:47+01:00) >>> Maven home: C:\Program Files\Apache Software Foundation\Maven\bin\.. >>> Java version: 1.7.0_80, vendor: Oracle Corporation >>> Java home: C:\Program Files\Java\jdk1.7.0_80\jre >>> Default locale: de_DE, platform encoding: Cp1252 >>> OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows" >> >> The test doesn't even seem to be very platform or locale dependent to >> me. I don't use a more current JDK 8 because that already fails during >> compiling or tests in wicket-util. Not sure how to read the output... >> >> Mit freundlichen Grüßen, >> >> Thorsten Schöning >> >> -- >> Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de >> AM-SoFT IT-Systeme http://www.AM-SoFT.de/ >> >> Telefon...05151- 9468- 55 >> Fax...05151- 9468- 88 >> Mobil..0178-8 9468- 04 >> >> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln >> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow >> >> >> - >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
Guten Tag Martin Grigorov, am Mittwoch, 30. März 2016 um 15:45 schrieben Sie: > If I try to build Wicket 7.x with de_DE locale the build fails at > wicket-core: Not on Windows BTW, I'm building on Ubuntu and Windows and the wicket-spring problem is currently only on Windows, while the wicket-core one is only in my Ubuntu. :-) Mit freundlichen Grüßen, Thorsten Schöning -- Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de AM-SoFT IT-Systeme http://www.AM-SoFT.de/ Telefon...05151- 9468- 55 Fax...05151- 9468- 88 Mobil..0178-8 9468- 04 AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
Please create a patch / Pull Request and a ticket. Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 3:49 PM, Thorsten Schöningwrote: > Guten Tag Thorsten Schöning, > am Mittwoch, 30. März 2016 um 14:52 schrieben Sie: > > > No change even with a more current version of Maven: > > I have the feeling that the error is non deterministic somehow, > because yesterday after upgrading 7.3.0.0 I was so damn sure that the > error didn't occur anymore, that I removed skipping of the tests from > my shell script invoking the build. Today the test is failing the > whole morning. > > Now after upgrading Maven I additionally tried without a .m2 folder > and the tests pass. Another execution directly afterwards with the > same commands and such, only a present .m2 folder now, the test fails > for every invocation. So I deleted the .m2 folder again and the tests > pass now. Executed again with the available .m2 folder and the tests > fail, pass(!), fail, fail... > > This test is buggy, at least "ConfigContextWithGenerics.getStrings" > doesn't make sense compared to the other method and field names. > > Mit freundlichen Grüßen, > > Thorsten Schöning > > -- > Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de > AM-SoFT IT-Systeme http://www.AM-SoFT.de/ > > Telefon...05151- 9468- 55 > Fax...05151- 9468- 88 > Mobil..0178-8 9468- 04 > > AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln > AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
If I try to build Wicket 7.x with de_DE locale the build fails at wicket-core: Failed tests: MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115 expected: but was: ResouceBundleTest.concatBundle:48->Assert.assertEquals:144->Assert.assertEquals:115 expected: but was: ResourceReferenceLocatingTest.locateMinifiedJavaScriptResourceReference:214->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956 TestCase [locale=null, style=null, variation=null, extension=null] Expected: is "// b.min.js" but: was "// b_de.js" ResourceReferenceLocatingTest.locateMinifiedPackageResourceReference:223->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956 TestCase [locale=null, style=null, variation=null, extension=null] Expected: is "// b.min.js" but: was "// b_de.js" ResourceReferenceLocatingTest.locateNonMinifiedJavaScriptResourceReference:196->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956 TestCase [locale=null, style=null, variation=null, extension=null] Expected: is "// b.js" but: was "// b_de.js" ResourceReferenceLocatingTest.locateNonMinifiedPackageResourceReference:205->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956 TestCase [locale=null, style=null, variation=null, extension=null] Expected: is "// b.js" but: was "// b_de.js" CssUrlReplacerTest.base64EncodedImage:153->Assert.assertThat:923->Assert.assertThat:956 Expected: a string containing ".class {background-image: url(data:image/gif;base64,R0lGODlh1wATAXAAACH5BAEAAP8ALADXA" but: was ".class {background-image: url(data:image/gif;base64,R0lGODlhUAB4ANUAANbX1hQSEXV0c/f. Sigh. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 2:52 PM, Thorsten Schöningwrote: > Guten Tag Thorsten Schöning, > am Mittwoch, 30. März 2016 um 14:16 schrieben Sie: > > > "mvn --version" should provide all requested info: > > No change even with a more current version of Maven: > > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 2015-11-10T17:41:47+01:00) > > Maven home: C:\Program Files\Apache Software Foundation\Maven\bin\.. > > Java version: 1.7.0_80, vendor: Oracle Corporation > > Java home: C:\Program Files\Java\jdk1.7.0_80\jre > > Default locale: de_DE, platform encoding: Cp1252 > > OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows" > > The test doesn't even seem to be very platform or locale dependent to > me. I don't use a more current JDK 8 because that already fails during > compiling or tests in wicket-util. Not sure how to read the output... > > Mit freundlichen Grüßen, > > Thorsten Schöning > > -- > Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de > AM-SoFT IT-Systeme http://www.AM-SoFT.de/ > > Telefon...05151- 9468- 55 > Fax...05151- 9468- 88 > Mobil..0178-8 9468- 04 > > AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln > AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
Guten Tag Thorsten Schöning, am Mittwoch, 30. März 2016 um 14:52 schrieben Sie: > No change even with a more current version of Maven: I have the feeling that the error is non deterministic somehow, because yesterday after upgrading 7.3.0.0 I was so damn sure that the error didn't occur anymore, that I removed skipping of the tests from my shell script invoking the build. Today the test is failing the whole morning. Now after upgrading Maven I additionally tried without a .m2 folder and the tests pass. Another execution directly afterwards with the same commands and such, only a present .m2 folder now, the test fails for every invocation. So I deleted the .m2 folder again and the tests pass now. Executed again with the available .m2 folder and the tests fail, pass(!), fail, fail... This test is buggy, at least "ConfigContextWithGenerics.getStrings" doesn't make sense compared to the other method and field names. Mit freundlichen Grüßen, Thorsten Schöning -- Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de AM-SoFT IT-Systeme http://www.AM-SoFT.de/ Telefon...05151- 9468- 55 Fax...05151- 9468- 88 Mobil..0178-8 9468- 04 AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
But wicket-spring passes even with de_DE. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 3:45 PM, Martin Grigorovwrote: > If I try to build Wicket 7.x with de_DE locale the build fails at > wicket-core: > > Failed tests: > > MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115 > expected: but was: > > ResouceBundleTest.concatBundle:48->Assert.assertEquals:144->Assert.assertEquals:115 > expected: but was: > > ResourceReferenceLocatingTest.locateMinifiedJavaScriptResourceReference:214->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956 > TestCase [locale=null, style=null, variation=null, extension=null] > Expected: is "// b.min.js" > but: was "// b_de.js" > > ResourceReferenceLocatingTest.locateMinifiedPackageResourceReference:223->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956 > TestCase [locale=null, style=null, variation=null, extension=null] > Expected: is "// b.min.js" > but: was "// b_de.js" > > ResourceReferenceLocatingTest.locateNonMinifiedJavaScriptResourceReference:196->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956 > TestCase [locale=null, style=null, variation=null, extension=null] > Expected: is "// b.js" > but: was "// b_de.js" > > ResourceReferenceLocatingTest.locateNonMinifiedPackageResourceReference:205->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956 > TestCase [locale=null, style=null, variation=null, extension=null] > Expected: is "// b.js" > but: was "// b_de.js" > > CssUrlReplacerTest.base64EncodedImage:153->Assert.assertThat:923->Assert.assertThat:956 > Expected: a string containing ".class {background-image: > url(data:image/gif;base64,R0lGODlh1wATAXAAACH5BAEAAP8ALADXA" > but: was ".class {background-image: > url(data:image/gif;base64,R0lGODlhUAB4ANUAANbX1hQSEXV0c/f. > > > Sigh. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Wed, Mar 30, 2016 at 2:52 PM, Thorsten Schöning > wrote: > >> Guten Tag Thorsten Schöning, >> am Mittwoch, 30. März 2016 um 14:16 schrieben Sie: >> >> > "mvn --version" should provide all requested info: >> >> No change even with a more current version of Maven: >> >> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; >> 2015-11-10T17:41:47+01:00) >> > Maven home: C:\Program Files\Apache Software Foundation\Maven\bin\.. >> > Java version: 1.7.0_80, vendor: Oracle Corporation >> > Java home: C:\Program Files\Java\jdk1.7.0_80\jre >> > Default locale: de_DE, platform encoding: Cp1252 >> > OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows" >> >> The test doesn't even seem to be very platform or locale dependent to >> me. I don't use a more current JDK 8 because that already fails during >> compiling or tests in wicket-util. Not sure how to read the output... >> >> Mit freundlichen Grüßen, >> >> Thorsten Schöning >> >> -- >> Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de >> AM-SoFT IT-Systeme http://www.AM-SoFT.de/ >> >> Telefon...05151- 9468- 55 >> Fax...05151- 9468- 88 >> Mobil..0178-8 9468- 04 >> >> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln >> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow >> >> >> - >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> >
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
Guten Tag Thorsten Schöning, am Mittwoch, 30. März 2016 um 14:16 schrieben Sie: > "mvn --version" should provide all requested info: No change even with a more current version of Maven: > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 2015-11-10T17:41:47+01:00) > Maven home: C:\Program Files\Apache Software Foundation\Maven\bin\.. > Java version: 1.7.0_80, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_80\jre > Default locale: de_DE, platform encoding: Cp1252 > OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows" The test doesn't even seem to be very platform or locale dependent to me. I don't use a more current JDK 8 because that already fails during compiling or tests in wicket-util. Not sure how to read the output... Mit freundlichen Grüßen, Thorsten Schöning -- Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de AM-SoFT IT-Systeme http://www.AM-SoFT.de/ Telefon...05151- 9468- 55 Fax...05151- 9468- 88 Mobil..0178-8 9468- 04 AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
Guten Tag Martin Grigorov, am Mittwoch, 30. März 2016 um 12:42 schrieben Sie: > The tests pass successfully here and at the CI server. > Which version of JDK and Maven do you use? What is the system locale ? "mvn --version" should provide all requested info: > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 > 17:22:22+0200) > Maven home: C:\Program Files (x86)\Apache Maven\bin\.. > Java version: 1.7.0_80, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_80\jre > Default locale: de_DE, platform encoding: Cp1252 > OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows" Mit freundlichen Grüßen, Thorsten Schöning -- Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de AM-SoFT IT-Systeme http://www.AM-SoFT.de/ Telefon...05151- 9468- 55 Fax...05151- 9468- 88 Mobil..0178-8 9468- 04 AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Failing test SpringBeanWithGenericsTest in 7.3.0.0 SNAPSHOT
Hi, The tests pass successfully here and at the CI server. Which version of JDK and Maven do you use? What is the system locale ? Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 30, 2016 at 12:05 PM, Thorsten Schöningwrote: > Hi all, > > I try to build 7.3.0.0-SNAPSHOT from source, but there's at least the > following failing test. Skipping the tests builds OK and the results > seem to work, but that shouldn't be necessary, right? > > [...] > > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.398 > sec - in org.apache.wicket.spring.injection.annot.SpringBeanTest > > Running > org.apache.wicket.spring.injection.annot.SpringBeanWithGenericsTest > > Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.557 > sec <<< FAILURE! - in > org.apache.wicket.spring.injection.annot.SpringBeanWithGenericsTestlistField(org.apache.wicket.spring.injection.annot.SpringBeanWithGenericsTest) > > Time elapsed: 0.072 sec <<< FAILURE! > > java.lang.AssertionError: expected:<3> but was:<1> > > at org.junit.Assert.fail(Assert.java:88) > > at org.junit.Assert.failNotEquals(Assert.java:834) > > at org.junit.Assert.assertEquals(Assert.java:645) > > at org.junit.Assert.assertEquals(Assert.java:631) > > at > org.apache.wicket.spring.injection.annot.SpringBeanWithGenericsTest.listField(SpringBeanWithGenericsTest.java:143) > [...] > > The mentioned line is the last one of the following quote: > > > @Test > > public void listField() throws Exception > > { > > AnnotatedListField page = > > tester.startPage(new AnnotatedListField()); > > > > assertNotNull(page.getStringsList()); > > assertEquals(3, page.getStringsList().size()); > > I've found the following commit, which introduced "getStringsList": > > > https://github.com/apache/wicket/commit/f0340a3ef62a18df14badb26acee01bf102b9a2c > > The interesting part for me about that commit is that > "ConfigContextWithGenerics.getStrings" in the same file was NOT > changed as well. So I renamed to .stringsList and that did have an > effect, now another test is failing instead: > > > Failed tests: > > > > SpringBeanWithGenericsTest.listField:147->Assert.assertThat:923->Assert.assert > > That:956 > > Expected: is <3> > > but: was <1> > > The only 1 element list in the class is "myList", so I guess that > "arrayListStrings" can't be found properly as well, only this time not > because of a wrong name, but maybe signature problems. > > In the end, this test seems broken to me... Any further ideas, should > I file a bug? Thanks! > > Mit freundlichen Grüßen, > > Thorsten Schöning > > -- > Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de > AM-SoFT IT-Systeme http://www.AM-SoFT.de/ > > Telefon...05151- 9468- 55 > Fax...05151- 9468- 88 > Mobil..0178-8 9468- 04 > > AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln > AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow > > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >