Hi,
Thanks for this change!
My suggestions and optimalization notes:
1. In some cases there is no necessary to create an anonymous class
for each ImageItem (using AbstractImageItem). When @ImageBundle
interface has not locale specified, then SimpleImageItem(String
imageSrc, String imageStyle)
My suggestions and optimalization notes:
1. In some cases there is no necessary to create an anonymous class
for each ImageItem (using AbstractImageItem). When @ImageBundle
interface has not locale specified, then SimpleImageItem(String
imageSrc, String imageStyle) can be used.
2. The
On 2010-04-20, at 19:28, Anantha Kumaran wrote:
Maybe for methods returning an ImageItem a Locale should be a method
argument (but only if image is locale relative). So:
// for not locale relative images
ImageItem getSomeImage();
// for locale related
ImageItem getSomeImage(Locale locale);
And one more thing:
ImageItem interface (and posiibly ImageItemProvider too) should extend
Serializable (or maybe better IClusterable?).
--
Daniel
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional
http://ananthakumaran.github.com/imagebundler-wicket/
version 1.2 released
* localization support added
* style and src of the image is available through the ImageItem interface
your comments are welcome
Anantha Kumaran(http://ananthakumaran.github.com)
Very cool Anantha, do you have a site online that uses the bundler that we
could take a peek at as a running example?
On Tue, Jan 26, 2010 at 7:42 AM, Anantha Kumaran
ananthakuma...@gmail.comwrote:
http://ananthakumaran.github.com/imagebundler-wicket
i will try to put it in the google appspot later. Here is the source code of
a sample http://github.com/ananthakumaran/imagebundler-wicket
On Tue, Jan 26, 2010 at 7:20 AM, Riyad Kalla rka...@gmail.com wrote:
Very cool Anantha, do you have a site online that uses the bundler that we
could take
This is very very cool.
Congrats Anantha!
On Jan 26, 2010, at 9:07 AM, Anantha Kumaran wrote:
i will try to put it in the google appspot later. Here is the source code of
a sample http://github.com/ananthakumaran/imagebundler-wicket
On Tue, Jan 26, 2010 at 7:20 AM, Riyad Kalla
Do the comments in the inspiration design document about localization
also apply to your Wicket ImageBundle implementation? If Wicket's
built in image handling functions as a locale-specific factory does
image localization work as expected with bundles?
Ed.
On Tue, Jan 26, 2010 at 12:23 PM,
Looks cool - but rather than generating a static string, why don't you
generate a string that includes a call to urlFor(Class, imageName) so that
you can allow for internationalization? (Wicket will generate the proper
internationalized URL for you this way)...
--
Jeremy Thomerson
Just ran across another base64-based method of spriting images that
Cappuccino is using:
http://cappuccino.org/discuss/2009/11/11/just-one-file-with-cappuccino-0-8
pretty interesting and supports back to IE6. Just wanted to share incase
anyone else reading on this subject was curious about other
Thanks for the Reply. I will look into it.
On Tue, Jan 26, 2010 at 12:59 PM, Jeremy Thomerson
jer...@wickettraining.com wrote:
Looks cool - but rather than generating a static string, why don't you
generate a string that includes a call to urlFor(Class, imageName) so that
you can allow for
12 matches
Mail list logo
